From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11626 invoked by alias); 30 Mar 2005 16:34:48 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 11561 invoked from network); 30 Mar 2005 16:34:43 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 30 Mar 2005 16:34:43 -0000 Received: (qmail 28465 invoked from network); 30 Mar 2005 16:34:42 -0000 Received: from localhost (HELO ?10.1.1.125?) (julian@127.0.0.1) by mail.codesourcery.com with SMTP; 30 Mar 2005 16:34:42 -0000 Message-ID: <424AD518.9000101@codesourcery.com> Date: Thu, 31 Mar 2005 00:34:00 -0000 From: Julian Brown User-Agent: Debian Thunderbird 1.0 (X11/20050116) MIME-Version: 1.0 To: Richard Earnshaw CC: Paul Brook , binutils@sources.redhat.com, julian@codesourcery.com Subject: Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols References: <424716CD.5030909@codesourcery.com> <4249C7E9.8000100@codesourcery.com> <1112175967.12337.36.camel@pc960.cambridge.arm.com> <200503301527.50626.paul@codesourcery.com> <424AC63F.7000706@codesourcery.com> <1112200206.1680.6.camel@pc960.cambridge.arm.com> In-Reply-To: <1112200206.1680.6.camel@pc960.cambridge.arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00904.txt.bz2 Richard Earnshaw wrote: > On Wed, 2005-03-30 at 16:31, Julian Brown wrote: > > >> * bfd/cpu-arm.c (bfd_elf32_is_arm_mapping_symbol_name): ...to here, >> renamed and made global. > > > This function isn't elf specific, which is one of the reasons I > suggested moving it to cpu-arm.c. So why have you put elf32 in the > name? Doh, sorry. I was confused by the mapping symbols being defined by the AAELF spec, and didn't realise they would be used elsewhere too. Is the original name best, or would bfd_is_arm_mapping_symbol_name be better? Julian