From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-39334-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 20762 invoked by alias); 1 Apr 2005 14:30:11 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 20315 invoked from network); 1 Apr 2005 14:29:59 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 1 Apr 2005 14:29:59 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j31ETxnJ009105
	for <binutils@sources.redhat.com>; Fri, 1 Apr 2005 09:29:59 -0500
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j31ETwO16598;
	Fri, 1 Apr 2005 09:29:58 -0500
Received: from [172.31.0.98] (vpnuser2.surrey.redhat.com [172.16.9.2])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j31ETvpH030406;
	Fri, 1 Apr 2005 15:29:57 +0100
Message-ID: <424D5A42.4090803@redhat.com>
Date: Fri, 01 Apr 2005 14:30:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Jan Beulich <JBeulich@novell.com>
CC: binutils@sources.redhat.com
Subject: Re: [PATCH] Re: .macro behavior
References: <s2498374.062@emea1-mh.id2.novell.com>
In-Reply-To: <s2498374.062@emea1-mh.id2.novell.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-04/txt/msg00034.txt.bz2

Hi Jan,

> gas/
> 2005-03-29  Jan Beulich  <jbeulich@novell.com>
> 
> 	* NEWS: Mention these changes and their effects.
> 	* macro.c (get_token): Use is_name_beginner/is_part_of_name/
> 	is_name_ender.
> 	(check_macro): Likewise.
> 	(buffer_and_nest): Likewise. Permit multiple labels. Don't discard
> 	labels together with the closing pseudo-op.
> 	(macro_expand_body): Adjust comment. Range-check input before use.
> 	Adjust mis-spelled diagnostic. Use is_name_beginner.
> 	* read.c (try_macro): New.
> 	(read_a_source_file): New static variable last_eol. Don't list
> 	macro expansion lines more than once. Call try_macro.
> 	(s_macro): Set section of line_label to absolute instead of undefined.
> 
> gas/testsuite/
> 2005-03-29  Jan Beulich  <jbeulich@novell.com>
> 
> 	* gas/macros/dot.[ls]: New.
> 	* gas/macros/macros.exp: Run new test.

Approved - please apply.

One request though.  Would it be possible to add entry to the assembler 
documentation about this new feature, and in particular a lengthier 
description of:

"...this is known to cause problems in certain sources when the
  respective target uses characters inconsistently, and thus macro
  parameter references are no longer recognized as such."

With an example and a suggested workaround.

Cheers
   Nick