Re: PATCH: Add -N to readelf to display section name

Re: PATCH: Add -N to readelf to display section name

[Nick Clifton]

Hi Guys,

>>>>It is very annoying that readelf won't display full section names. This

I realise that the patch has already been applied, but it seems to me 
that adding a new switch to control the displaying of the full section 
name is wrong - I think that this ought to be controlled by the already 
existing "--wide" switch.  ie if you specify --wide on the command line 
you get the full section names and wider-than-80-character output, 
whereas if you omit the switch you get possibly truncated section names 
and restricted-to-a-maximum-of-80-characters output.

Cheers
   Nick

Re: PATCH: Add -N to readelf to display section name

[Alan Modra]

On Fri, Apr 01, 2005 at 11:55:55AM +0100, Nick Clifton wrote:
> Hi Guys,
> 
> >>>>It is very annoying that readelf won't display full section names. This
> 
> I realise that the patch has already been applied, but it seems to me 
> that adding a new switch to control the displaying of the full section 
> name is wrong - I think that this ought to be controlled by the already 
> existing "--wide" switch.  ie if you specify --wide on the command line 
> you get the full section names and wider-than-80-character output, 
> whereas if you omit the switch you get possibly truncated section names 
> and restricted-to-a-maximum-of-80-characters output.

I think this was discussed before, with someone making a point that
--wide is supposed to not split output lines.  HJ's patch puts the
section name on a separate line.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: PATCH: Add -N to readelf to display section name

[Nick Clifton]

Hi Alan,

>>I realise that the patch has already been applied, but it seems to me 
>>that adding a new switch to control the displaying of the full section 
>>name is wrong - I think that this ought to be controlled by the already 
>>existing "--wide" switch.  ie if you specify --wide on the command line 
>>you get the full section names and wider-than-80-character output, 
>>whereas if you omit the switch you get possibly truncated section names 
>>and restricted-to-a-maximum-of-80-characters output.

> I think this was discussed before, with someone making a point that
> --wide is supposed to not split output lines.  HJ's patch puts the
> section name on a separate line.

Ah - OK - thanks for the explanation.

By the way, just being picky, but shouldn't a new switch like this be 
documented in binutils/doc/binutils.texi and mentioned in 
binutils/NEWS... ? :-)

Cheers
   Nick

Re: PATCH: Add -N to readelf to display section name

[H. J. Lu]

On Fri, Apr 01, 2005 at 12:25:46PM +0100, Nick Clifton wrote:
> Hi Alan,
> 
> >>I realise that the patch has already been applied, but it seems to me 
> >>that adding a new switch to control the displaying of the full section 
> >>name is wrong - I think that this ought to be controlled by the already 
> >>existing "--wide" switch.  ie if you specify --wide on the command line 
> >>you get the full section names and wider-than-80-character output, 
> >>whereas if you omit the switch you get possibly truncated section names 
> >>and restricted-to-a-maximum-of-80-characters output.
> 
> >I think this was discussed before, with someone making a point that
> >--wide is supposed to not split output lines.  HJ's patch puts the
> >section name on a separate line.
> 
> Ah - OK - thanks for the explanation.
> 
> By the way, just being picky, but shouldn't a new switch like this be 
> documented in binutils/doc/binutils.texi and mentioned in 
> binutils/NEWS... ? :-)
> 

Here is the patch. I also added -g.


H.J.
-----
2005-04-01  H.J. Lu  <hongjiu.lu@intel.com>

	* NEWS: Mention new readelf options, "-N/--full-section-name"
	and "-g/--section-groups".

	* doc/binutils.texi: Document new readelf options,
	"-N/--full-section-name" and "-g/--section-groups".

--- binutils/NEWS.nn	2005-03-30 19:49:08.000000000 -0800
+++ binutils/NEWS	2005-04-01 06:35:19.744280021 -0800
@@ -1,5 +1,7 @@
 -*- text -*-
 
+* Add "-N/--full-section-name" to readelf to display full section name.
+
 * Add "-M entry:<addr>" switch to objdump to specify a function entry address
   when disassembling VAX binaries.
 
@@ -8,6 +10,8 @@
 
 Changes in 2.16:
 
+* Add "-g/--section-groups" to readelf to display section group.
+
 * objcopy recognizes two new options --strip-unneeded-symbol and
   --strip-unneeded-symbols, namely for use together with the wildcard
   matching the original --strip-symbol/--strip-symbols provided, but
--- binutils/doc/binutils.texi.nn	2005-03-30 19:49:09.000000000 -0800
+++ binutils/doc/binutils.texi	2005-04-01 06:41:00.358170821 -0800
@@ -3242,6 +3242,8 @@ readelf [@option{-a}|@option{--all}] 
         [@option{-h}|@option{--file-header}]
         [@option{-l}|@option{--program-headers}|@option{--segments}]
         [@option{-S}|@option{--section-headers}|@option{--sections}]
+        [@option{-g}|@option{--section-groups}]
+        [@option{-N}|@option{--full-section-name}]
         [@option{-e}|@option{--headers}]
         [@option{-s}|@option{--syms}|@option{--symbols}]
         [@option{-n}|@option{--notes}]
@@ -3312,6 +3314,17 @@ has any.
 Displays the information contained in the file's section headers, if it
 has any.
 
+@item -g
+@itemx --section-groups
+@cindex ELF section group information
+Displays the information contained in the file's section groups, if it
+has any.
+
+@item -N
+@itemx --full-section-name
+@cindex ELF section name information
+Displays the full section name for @option{-S}.
+
 @item -s
 @itemx --symbols
 @itemx --syms

PATCH: Document readelf -g

[H. J. Lu]

On Fri, Apr 01, 2005 at 12:25:46PM +0100, Nick Clifton wrote:
> 
> By the way, just being picky, but shouldn't a new switch like this be 
> documented in binutils/doc/binutils.texi and mentioned in 
> binutils/NEWS... ? :-)
> 

Here is a patch for 2.16.


H.J.
----
2005-04-01  H.J. Lu  <hongjiu.lu@intel.com>

	* NEWS: Mention new readelf option, "-N/--full-section-name".

	* doc/binutils.texi: Document new readelf option,
	"-g/--section-groups".

Index: NEWS
===================================================================
RCS file: /cvs/src/src/binutils/NEWS,v
retrieving revision 1.48
diff -u -p -r1.48 NEWS
--- NEWS	19 Jan 2005 23:43:00 -0000	1.48
+++ NEWS	1 Apr 2005 14:47:27 -0000
@@ -1,5 +1,7 @@
 -*- text -*-
 
+* Add "-g/--section-groups" to readelf to display section group.
+
 * objcopy recognizes two new options --strip-unneeded-symbol and
   --strip-unneeded-symbols, namely for use together with the wildcard
   matching the original --strip-symbol/--strip-symbols provided, but
Index: doc/binutils.texi
===================================================================
RCS file: /cvs/src/src/binutils/doc/binutils.texi,v
retrieving revision 1.68
diff -u -p -r1.68 binutils.texi
--- doc/binutils.texi	3 Mar 2005 11:46:13 -0000	1.68
+++ doc/binutils.texi	1 Apr 2005 14:47:30 -0000
@@ -3222,6 +3222,7 @@ readelf [@option{-a}|@option{--all}] 
         [@option{-h}|@option{--file-header}]
         [@option{-l}|@option{--program-headers}|@option{--segments}]
         [@option{-S}|@option{--section-headers}|@option{--sections}]
+        [@option{-g}|@option{--section-groups}]
         [@option{-e}|@option{--headers}]
         [@option{-s}|@option{--syms}|@option{--symbols}]
         [@option{-n}|@option{--notes}]
@@ -3292,6 +3293,12 @@ has any.
 Displays the information contained in the file's section headers, if it
 has any.
 
+@item -g
+@itemx --section-groups
+@cindex ELF section group information
+Displays the information contained in the file's section groups, if it
+has any.
+
 @item -s
 @itemx --symbols
 @itemx --syms

Re: PATCH: Add -N to readelf to display section name

[Nick Clifton]

Hi H. J.


> 2005-04-01  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* NEWS: Mention new readelf options, "-N/--full-section-name"
> 	and "-g/--section-groups".
> 
> 	* doc/binutils.texi: Document new readelf options,
> 	"-N/--full-section-name" and "-g/--section-groups".

Approved - please apply.

Cheers
   Nick