public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Bob Wilson <bwilson@tensilica.com>
To: binutils@sources.redhat.com
Subject: fix broken Xtensa property tables
Date: Fri, 08 Apr 2005 17:33:00 -0000	[thread overview]
Message-ID: <4256C056.4000503@tensilica.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Xtensa object files include "property tables" to provide extra information about 
the contents of other sections.  This patch disables the creation of property 
tables for merged string sections.  The problem is that if a string (or other 
data object) is merged, any property table entry associated with that object is 
left hanging around, and this can lead to invalid property tables.  It's 
unlikely that property tables will be needed for merged sections, anyway, since 
they are primarily used for link-time relaxation of sections containing code.

Tested with an xtensa-elf target, and committed on the mainline and 2.16 branch.


2005-04-08  Bob Wilson  <bob.wilson@acm.org>

	* config/tc-xtensa.c (xtensa_create_xproperty_segments): Skip
	SEC_MERGE sections.



[-- Attachment #2: no-merge-proptab.diff --]
[-- Type: text/x-patch, Size: 678 bytes --]

Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.29
diff -u -p -r1.29 tc-xtensa.c
--- config/tc-xtensa.c	5 Apr 2005 23:37:34 -0000	1.29
+++ config/tc-xtensa.c	8 Apr 2005 17:24:18 -0000
@@ -10393,9 +10393,9 @@ xtensa_create_xproperty_segments (frag_f
       flagword flags;
 
       flags = bfd_get_section_flags (stdoutput, sec);
-      if (flags & SEC_DEBUGGING)
-	continue;
-      if (!(flags & SEC_ALLOC))
+      if ((flags & SEC_DEBUGGING)
+	  || !(flags & SEC_ALLOC)
+	  || (flags & SEC_MERGE))
 	continue;
 
       if (section_has_xproperty (sec, flag_fn))

                 reply	other threads:[~2005-04-08 17:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4256C056.4000503@tensilica.com \
    --to=bwilson@tensilica.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).