public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* fix broken Xtensa property tables
@ 2005-04-08 17:33 Bob Wilson
  0 siblings, 0 replies; only message in thread
From: Bob Wilson @ 2005-04-08 17:33 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Xtensa object files include "property tables" to provide extra information about 
the contents of other sections.  This patch disables the creation of property 
tables for merged string sections.  The problem is that if a string (or other 
data object) is merged, any property table entry associated with that object is 
left hanging around, and this can lead to invalid property tables.  It's 
unlikely that property tables will be needed for merged sections, anyway, since 
they are primarily used for link-time relaxation of sections containing code.

Tested with an xtensa-elf target, and committed on the mainline and 2.16 branch.


2005-04-08  Bob Wilson  <bob.wilson@acm.org>

	* config/tc-xtensa.c (xtensa_create_xproperty_segments): Skip
	SEC_MERGE sections.



[-- Attachment #2: no-merge-proptab.diff --]
[-- Type: text/x-patch, Size: 678 bytes --]

Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.29
diff -u -p -r1.29 tc-xtensa.c
--- config/tc-xtensa.c	5 Apr 2005 23:37:34 -0000	1.29
+++ config/tc-xtensa.c	8 Apr 2005 17:24:18 -0000
@@ -10393,9 +10393,9 @@ xtensa_create_xproperty_segments (frag_f
       flagword flags;
 
       flags = bfd_get_section_flags (stdoutput, sec);
-      if (flags & SEC_DEBUGGING)
-	continue;
-      if (!(flags & SEC_ALLOC))
+      if ((flags & SEC_DEBUGGING)
+	  || !(flags & SEC_ALLOC)
+	  || (flags & SEC_MERGE))
 	continue;
 
       if (section_has_xproperty (sec, flag_fn))

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-04-08 17:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-08 17:33 fix broken Xtensa property tables Bob Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).