From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29738 invoked by alias); 12 Apr 2005 08:37:53 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 29657 invoked from network); 12 Apr 2005 08:37:45 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Apr 2005 08:37:45 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3C8bjg8026865 for ; Tue, 12 Apr 2005 04:37:45 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3C8bdO14658; Tue, 12 Apr 2005 04:37:39 -0400 Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j3C8bbbB021031; Tue, 12 Apr 2005 09:37:38 +0100 Message-ID: <425B8860.6050403@redhat.com> Date: Tue, 12 Apr 2005 08:37:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Alan Modra CC: "H. J. Lu" , binutils@sources.redhat.com Subject: Re: housekeeping, -Wno-error References: <20050412025055.GC3321@bubble.modra.org> <20050412043621.GA27008@lucon.org> <20050412054212.GD3321@bubble.modra.org> In-Reply-To: <20050412054212.GD3321@bubble.modra.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00282.txt.bz2 Hi Alan, >>Are we assuming that gcc is the only supported compiler for binutils? > Good question. I hadn't even thought about that, just followed Nick's > lead with -Wno-error in gas/. -W{no-,}error probably ought to only > happen by default for gcc. Actually I was waiting for Maciej's patch to fix this problem in the configure files. In the meantime however I was about to apply a Makefile based patch like this: + # Disable -Werror, if it has been enabled, when building generated C source + # files since old versions of bison & yacc will produce working code which + # contain compile time warnings. + GENERATED_OFILES := $(GENERATED_CFILES:.c=.o) + NO_WERROR_COMPILE = $(COMPILE:Werror=Wno-error) + $(GENERATED_OFILES): + $(NO_WERROR_COMPILE) -c `basename $@ .o`.c + Which does not depend upon the host compiler being GCC. My bad for not applying this patch sooner. Ideally the configure based solution would be best since it could check for known good versions of bison/yacc/flex etc and keep -Werror enabled for them. Cheers Nick