PATCH: objdump: Skip linker created section

PATCH: objdump: Skip linker created section

[H. J. Lu]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

I checked a objdump patch to support SEC_GROUP. Should objdump skip
linker created section? Readelf doesn't display it.


H.J.
----
2005-04-17  H.J. Lu  <hongjiu.lu@intel.com>

	* objdump.c (dump_section_header): Skip linker created section.

--- binutils/objdump.c.grp	2005-04-04 09:58:38.000000000 -0700
+++ binutils/objdump.c	2005-04-17 07:27:08.000000000 -0700
@@ -300,6 +300,11 @@ dump_section_header (bfd *abfd, asection
   char *comma = "";
   unsigned int opb = bfd_octets_per_byte (abfd);
 
+  /* Ignore linker created section.  See elfNN_ia64_object_p in
+     bfd/elfxx-ia64.c.  */
+  if (section->flags & SEC_LINKER_CREATED)
+    return;
+
   printf ("%3d %-13s %08lx  ", section->index,
 	  bfd_get_section_name (abfd, section),
 	  (unsigned long) bfd_section_size (abfd, section) / opb);

[-- Attachment #2: binutils-group-1.patch --]
[-- Type: text/plain, Size: 504 bytes --]

2005-04-17  H.J. Lu  <hongjiu.lu@intel.com>

	* objdump.c (dump_section_header): Support SEC_GROUP.

--- binutils/objdump.c.grp	2005-04-04 09:58:38.000000000 -0700
+++ binutils/objdump.c	2005-04-17 07:27:08.000000000 -0700
@@ -337,6 +342,7 @@ dump_section_header (bfd *abfd, asection
   if (bfd_get_flavour (abfd) == bfd_target_coff_flavour)
     PF (SEC_COFF_SHARED, "SHARED");
   PF (SEC_THREAD_LOCAL, "THREAD_LOCAL");
+  PF (SEC_GROUP, "GROUP");
 
   if ((section->flags & SEC_LINK_ONCE) != 0)
     {

Re: PATCH: objdump: Skip linker created section

[James E Wilson]

On Sun, 2005-04-17 at 07:37, H. J. Lu wrote:
> Should objdump skip
> linker created section? Readelf doesn't display it.

readelf does not display the section because it doesn't exist in the
object file.  Objdump displays the section because we create it always
when bfd initializes, even if not linking.  readelf is correct here. 
Objdump shouldn't be claiming the section exists.

Perhaps there is a linker hook we can use instead of the elf_object_p
hook?  That would fix objdump.

Alternatively, if it is always the case that a section with
SEC_LINKER_CREATED is not in the object file, then your objdump.c patch
looks OK to me.  This does appear to be the case, as there is no section
header flag for SEC_LINKER_CREATED, so I think this can only happen for
your fake section group.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com

Re: PATCH: objdump: Skip linker created section

[H. J. Lu]

On Tue, Apr 19, 2005 at 11:15:29AM -0700, James E Wilson wrote:
> On Sun, 2005-04-17 at 07:37, H. J. Lu wrote:
> > Should objdump skip
> > linker created section? Readelf doesn't display it.
> 
> readelf does not display the section because it doesn't exist in the
> object file.  Objdump displays the section because we create it always
> when bfd initializes, even if not linking.  readelf is correct here. 
> Objdump shouldn't be claiming the section exists.
> 
> Perhaps there is a linker hook we can use instead of the elf_object_p
> hook?  That would fix objdump.
> 
> Alternatively, if it is always the case that a section with
> SEC_LINKER_CREATED is not in the object file, then your objdump.c patch
> looks OK to me.  This does appear to be the case, as there is no section
> header flag for SEC_LINKER_CREATED, so I think this can only happen for
> your fake section group.

I believe that a SEC_LINKER_CREATED section never exists in the input
file. Otherwise, it is a bug.


H.J.

Re: PATCH: objdump: Skip linker created section

[Nick Clifton]

Hi H. J.

> 2005-04-17  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* objdump.c (dump_section_header): Skip linker created section.

Approved - please apply.

Cheers
   Nick