From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17781 invoked by alias); 20 Apr 2005 09:29:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 17712 invoked from network); 20 Apr 2005 09:29:12 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 20 Apr 2005 09:29:12 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j3K9TCaP016452 for ; Wed, 20 Apr 2005 05:29:12 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j3K9T6O28698; Wed, 20 Apr 2005 05:29:06 -0400 Received: from [172.31.0.98] (vpnuser7.surrey.redhat.com [172.16.9.7]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j3K9T5kk029609; Wed, 20 Apr 2005 10:29:05 +0100 Message-ID: <42662095.6090509@redhat.com> Date: Wed, 20 Apr 2005 09:29:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: "H. J. Lu" CC: binutils@sources.redhat.com Subject: Re: Why does gas have both S_IS_EXTERNAL and S_IS_EXTERN? References: <20050419191948.GB19412@lucon.org> <20050420042726.GA27124@lucon.org> In-Reply-To: <20050420042726.GA27124@lucon.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00544.txt.bz2 Hi H. J. >>>S_IS_EXTERN just calls S_IS_EXTERNAL. Why does gas need it? >>It doesn't. >> >>In the non BFD_ASSEMBLER case, in obj-coff.h, S_IS_EXTERN and >>S_IS_EXTERNAL are not identical. Specifically, S_IS_EXTERNAL will >>return true for a common symbol, and S_IS_EXTERN will not. This is >>almost certainly a bug. > Should I submit a patch to remove S_IS_EXTERN? Yes please. Cheers Nick