public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: John Levon <levon@movementarian.org>
Cc: binutils@sources.redhat.com, Philippe Elie <phil.el@wanadoo.fr>
Subject: Re: [PATCH] Re: Multiple apparent leaks in dwarf2.c
Date: Thu, 05 May 2005 14:34:00 -0000	[thread overview]
Message-ID: <427A2C88.6090806@redhat.com> (raw)
In-Reply-To: <20050423205950.GA3035@compsoc.man.ac.uk>

Hi John,

> Here's a patch that fixes up the issues I found in dwarf2.c. With this
> patch applied to CVS, our application is valgrind-clean.

Thanks very much for submitting this.  I have applied your patch 
together with this ChangeLog entry:

bfd/ChangeLog
2005-05-05  John Levon  <levon@movementarian.org>

	* dwarf2.c (read_abbrevs): If bfd_realloc fails, free currently
	allocated memory before returning.
	(decode_line_info): Likewise.
	(_bfd_dwarf2_cleanup_debug_info): New function:  Frees memory
	allocated by functions in this file.
	* elf-bfd.h (_bfd_dwarf2_cleanup_debug_info): Prototype.
	* elf.c (bfd_elf_close_and_cleanup): Call
	_bfd_dwarf2_cleanup_debug_info.

Cheers
   Nick

      reply	other threads:[~2005-05-05 14:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-21  6:03 John Levon
2005-04-23 21:00 ` [PATCH] " John Levon
2005-05-05 14:34   ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=427A2C88.6090806@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sources.redhat.com \
    --cc=levon@movementarian.org \
    --cc=phil.el@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).