From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19692 invoked by alias); 13 May 2005 17:35:35 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 19653 invoked from network); 13 May 2005 17:35:27 -0000 Received: from unknown (HELO mailapp.tensilica.com) (65.205.227.29) by sourceware.org with SMTP; 13 May 2005 17:35:27 -0000 Received: from localhost ([127.0.0.1] ident=amavis) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1DWe4M-0006LD-PQ for binutils@sources.redhat.com; Fri, 13 May 2005 10:35:26 -0700 Received: from mailapp.tensilica.com ([127.0.0.1]) by localhost (mailapp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 24312-02 for ; Fri, 13 May 2005 10:35:26 -0700 (PDT) Received: from heron.hq.tensilica.com ([192.168.11.123]) by mailapp.tensilica.com with esmtp (Exim 4.34) id 1DWe4M-0006L7-Eu for binutils@sources.redhat.com; Fri, 13 May 2005 10:35:26 -0700 Received: from [192.168.11.123] (heron.hq.tensilica.com [192.168.11.123]) by heron.hq.tensilica.com (8.13.1/8.13.1) with ESMTP id j4DHZQjH022273 for ; Fri, 13 May 2005 10:35:26 -0700 Message-ID: <4284E55E.5070106@tensilica.com> Date: Fri, 13 May 2005 18:15:00 -0000 From: Bob Wilson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 MIME-Version: 1.0 To: binutils@sources.redhat.com Subject: a few more Xtensa GAS fixes Content-Type: multipart/mixed; boundary="------------090604040104020207050704" X-SW-Source: 2005-05/txt/msg00455.txt.bz2 This is a multi-part message in MIME format. --------------090604040104020207050704 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 538 This patch clarifies a confusing error message and fixes an obscure problem in the Xtensa port that was exposed by an unrelated bug in Tensilica's code. I don't know how to write a testcase that will show the problem. Committed on the mainline. 2005-05-13 Sterling Augustine Bob Wilson * config/tc-xtensa.c (xtensa_insnbuf_set_operand): Clarify error message. (xtensa_mark_zcl_first_insns): Fix incorrect nesting of conditional for handling RELAX_CHECK_ALIGN_NEXT_OPCODE. --------------090604040104020207050704 Content-Type: text/x-patch; name="gas-fixes.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gas-fixes.patch" Content-length: 1623 Index: config/tc-xtensa.c =================================================================== RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v retrieving revision 1.40 diff -u -p -r1.40 tc-xtensa.c --- config/tc-xtensa.c 6 May 2005 21:27:47 -0000 1.40 +++ config/tc-xtensa.c 12 May 2005 03:48:59 -0000 @@ -2707,12 +2707,16 @@ xtensa_insnbuf_set_operand (xtensa_insnb if (xtensa_operand_is_PCrelative (xtensa_default_isa, opcode, operand) == 1) as_bad_where ((char *) file, line, - _("operand %u is out of range for '%s'"), value, - xtensa_opcode_name (xtensa_default_isa, opcode)); + _("operand %d of '%s' has out of range value '%u'"), + operand + 1, + xtensa_opcode_name (xtensa_default_isa, opcode), + value); else as_bad_where ((char *) file, line, - _("operand %u is invalid for '%s'"), value, - xtensa_opcode_name (xtensa_default_isa, opcode)); + _("operand %d of '%s' has invalid value '%u'"), + operand + 1, + xtensa_opcode_name (xtensa_default_isa, opcode), + value); return; } @@ -7135,11 +7139,9 @@ xtensa_mark_zcl_first_insns (void) /* Of course, sometimes (mostly for toy test cases) a zero-cost loop instruction is the last in a section. */ if (targ_frag) - { - targ_frag->tc_frag_data.is_first_loop_insn = TRUE; - if (fragP->fr_subtype == RELAX_CHECK_ALIGN_NEXT_OPCODE) - frag_wane (fragP); - } + targ_frag->tc_frag_data.is_first_loop_insn = TRUE; + if (fragP->fr_subtype == RELAX_CHECK_ALIGN_NEXT_OPCODE) + frag_wane (fragP); } } } --------------090604040104020207050704--