From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shrimp.cherry.relay.mailchannels.net (shrimp.cherry.relay.mailchannels.net [23.83.223.164]) by sourceware.org (Postfix) with ESMTPS id 82A493857B93 for ; Tue, 10 Oct 2023 18:03:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82A493857B93 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 597E1501CCF; Tue, 10 Oct 2023 18:03:44 +0000 (UTC) Received: from pdx1-sub0-mail-a246.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D1692501F4B; Tue, 10 Oct 2023 18:03:43 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696961024; a=rsa-sha256; cv=none; b=hL2Kakb2cS2KNVwoTjeGpuH22rYZp1hL7uPQlT70KmAKNsz6W528TG0IsRqIzj4dgbJbR0 pX03CRxEWmblNI76ah6cfPzda5TPGVUQBYsL6phFuZ9a+WYL6ymDtk4YiigvxaZE+RLPHq 1AAQG66sFhj11iQqjxh4RK5XAMIXVURWxxcy1SKY8qwUnFRMjKEDXNyuqOdW/3YVCplhAR vdO7fibBV3nwbsk4sGUgvQahy8rTAsVQ98ZdH2X7GoBnIUTXTdQJ3T6hk400Xy9l/Ppnm6 glPVaSTK7lydb15DaeXEBn7U845GBgx57uXpuQJFijkvB5E5V5h/1vvepsg0sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696961023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PI7FOVQmybCZr9z3JpXLifFhnYI+l6s3Fj7h2Nsfzzw=; b=n2S7a7duQBBk7KwSOSNsQ7ogjN+5HgbWld6FUK0QpQOB1oJOCt6AA7nUyXav1E6siNTQkk AG3+MdXmOOM/6QODBCjqzXngK/SRnEZIEBrPrEZQAGqypWjxra2NVCGjvzgPzM+z3rJ6na ATWUabXSNesW81Uo8GmJ8IqcK5uXeLA+LWsQpkb3by6Iph/Mx07qobDTXPOT3eTj6QcvFZ inBOMoOF9BC0+VOs06L83BjAWpZDehwr3KVphcscXSABJi0yQ+yyWf1NeMZbFGgtgK61po tk0eTie22m/ZlmW/Apr1uXuDT0mx5/ceCjsGYjOgwOnEd6ZOqmLDvnNbp+VrXQ== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-nvl9b; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Stupid-Bottle: 759a88107d493e12_1696961024199_3311903185 X-MC-Loop-Signature: 1696961024199:1561215037 X-MC-Ingress-Time: 1696961024198 Received: from pdx1-sub0-mail-a246.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.68.32 (trex/6.9.1); Tue, 10 Oct 2023 18:03:44 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a246.dreamhost.com (Postfix) with ESMTPSA id 4S4kKq1B4qzl8; Tue, 10 Oct 2023 11:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1696961023; bh=PI7FOVQmybCZr9z3JpXLifFhnYI+l6s3Fj7h2Nsfzzw=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=SFS+6+rd1jiw4JW/v8+zQZEQVVI5/T3BMXW6TEquMdXe4FiRS8Avitxf8Mp24beCT q1SIQ07GuCyCp9C9+XYf9B7RPvBQ6KOOUClIWHhmkqZf2k14cXa4wdf4ZIvsuOO0uO 7wabsV6uRz07JBxvhKnfr5f05jKwaqQYvEcR9V3sK28w5oqr6G7HOyS79jmD1iviJT qwSv0UCwRnRq3H6uiCuqMSMhsaGzX+2EQoRMdwsOK77NAwhekro9BMq61LdPK0Cn/e VdJDGvnFwPfQ9UnZfjosdwgYcAAvg+ibNhzKYhVJWFHjADoaJdiLQloLgMPVQff16K F4jSLAW7UBmJQ== Message-ID: <4297d8dd-f276-6547-abe7-edea6c9270aa@eagercon.com> Date: Tue, 10 Oct 2023 11:03:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 1/1] opcodes: microblaze: Add new bit-field instructions Content-Language: en-US To: Neal Frager , binutils@sourceware.org Cc: ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com, nickc@redhat.com, mark@klomp.org, eager@eagerm.com, macro@orcam.me.uk References: <20231010075906.2185416-1-neal.frager@amd.com> From: Michael Eager In-Reply-To: <20231010075906.2185416-1-neal.frager@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/10/23 00:59, Neal Frager wrote: > This patches adds new bsefi and bsifi instructions. > BSEFI- The instruction shall extract a bit field from a > register and place it right-adjusted in the destination register. > The other bits in the destination register shall be set to zero. > BSIFI- The instruction shall insert a right-adjusted bit field > from a register at another position in the destination register. > The rest of the bits in the destination register shall be unchanged. > > Further documentation of these instructions can be found here: > https://docs.xilinx.com/v/u/en-US/ug984-vivado-microblaze-ref > > This patch has been tested for years of AMD Xilinx Yocto > releases as part of the following patch set: > > https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils > > Signed-off-by: nagaraju > Signed-off-by: Ibai Erkiaga > Signed-off-by: Neal Frager > --- > V1->V2: > -corrected relocation values for the linker > V2->V3: > - fixed build issue for 32-bit hosts > - added test cases for bsefi and bsifi instructions > V3->V4: > - fixed GNU coding standard issues > V4->V5: > - fixed a remaining line of code > 80 chars Please do NOT send me incremental changes to this (or any other) patch. They clutter up my inbox and I will not review or apply incomplete patches. Please provide a FINAL patch which addresses all of the issues previously noted. Include the summary of the binutils test suite runs (gas, ld, binutils) or a diff of the .sum file, before and after applying the patch, showing no regressions. -- Michael Eager