From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2077.outbound.protection.outlook.com [40.107.249.77]) by sourceware.org (Postfix) with ESMTPS id 104C43858D28 for ; Fri, 6 Jan 2023 09:48:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 104C43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r2UoB+kxV8zrWkA7ESPHQnTke6YEpPXOY1NTRgyY5kg=; b=GTtO0+H0nE3ZuZJqSUVa5nOHr5cibo6D0MAUvCDJvgjAsWoXfeGZ1nzbPyIejTxycLJ6QN6YjjrV1Dew3isf8hUMWU6u+obBuWcuLQiq9ljU/NNPs1Wo09w3F/tpOItVEoGksuxFGpmW79P6D45iZi3KdPr7iQBwUcitghS8iN0= Received: from AM5PR04CA0032.eurprd04.prod.outlook.com (2603:10a6:206:1::45) by AM0PR08MB5314.eurprd08.prod.outlook.com (2603:10a6:208:184::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.7; Fri, 6 Jan 2023 09:48:17 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::54) by AM5PR04CA0032.outlook.office365.com (2603:10a6:206:1::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.15 via Frontend Transport; Fri, 6 Jan 2023 09:48:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19 via Frontend Transport; Fri, 6 Jan 2023 09:48:16 +0000 Received: ("Tessian outbound 8038f0863a52:v132"); Fri, 06 Jan 2023 09:48:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cc8993d6fbb12d62 X-CR-MTA-TID: 64aa7808 Received: from 2ff9eafa0e9c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B0B12C86-EE51-477B-BF38-6C4369AC1487.1; Fri, 06 Jan 2023 09:48:15 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ff9eafa0e9c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Jan 2023 09:48:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P9mJQ4pSu+JYdIQ6qikwThQdgcQSRtYomwU+DG136h2mTKMzsrQCCdqOC+OCU2NFKXCJdFcst7/D+IJuLELj6v8YhcI03pvbfdEUYVtWEVr1RWQcVN3KTy93JdyTrZbpoe4kPIRly8SufMQGruIWut80BZu1Lg9TeliObiASh/6O3a8SJ2T3qSQhQTfHgXqTA5eOnq92Zs3QQNlSWeH9yusFCrHBhhvY0ouDIHDH+SZD+yFqMa7oAToYPOlIIDD3nXxzMasoixKw7NuM++v0I4aZFmJSaE1uCupv8ZARyIhyH5o3fQq32leVmlyyfeiPIHDrBrvDlUbCL6ixfT7r+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r2UoB+kxV8zrWkA7ESPHQnTke6YEpPXOY1NTRgyY5kg=; b=ALsQetNebTftRiI2EMPl180sRzgYui0MpLwMgw25yon9LElDCHSi56kR+kYRdy/hlKS3mhFAXuvjD26cqXafrNFLD7TMPi7bChlh5w/g+xDZ/4So/xMII23QhNWQKaF6+EFDz5jE1R38tem6gWJ3MNK98h8Xl6pnWB8v/Qjp/Hw3KkY1N+IgCV8RfCMdzeedU0RJ54cHVULF/6tijLRRp71nygeFpKtvJizq7h5PoaxzTz8SzWv8cIbWYyFNxtGnZfsf8vjeqQu1+X4iaYXzTAHDViUvKv+bOy2z8kv8aIjY0b6kg8bwm6G3QTZEcQ93/cKkGUEYdyzfSFBfHKHxDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r2UoB+kxV8zrWkA7ESPHQnTke6YEpPXOY1NTRgyY5kg=; b=GTtO0+H0nE3ZuZJqSUVa5nOHr5cibo6D0MAUvCDJvgjAsWoXfeGZ1nzbPyIejTxycLJ6QN6YjjrV1Dew3isf8hUMWU6u+obBuWcuLQiq9ljU/NNPs1Wo09w3F/tpOItVEoGksuxFGpmW79P6D45iZi3KdPr7iQBwUcitghS8iN0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) by PAVPR08MB9529.eurprd08.prod.outlook.com (2603:10a6:102:315::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.7; Fri, 6 Jan 2023 09:48:04 +0000 Received: from VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::d034:a319:3a2a:7897]) by VI1PR08MB3390.eurprd08.prod.outlook.com ([fe80::d034:a319:3a2a:7897%6]) with mapi id 15.20.5986.014; Fri, 6 Jan 2023 09:48:02 +0000 Message-ID: <42d1673b-bca4-a4ce-daf2-ae4c24ca923e@arm.com> Date: Fri, 6 Jan 2023 10:47:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/7] Fix size of external_reloc for pe-aarch64 To: Mark Harmstone , binutils@sourceware.org, Tamar.Christina@arm.com, nickc@redhat.com, pinskia@gmail.com, Richard.Earnshaw@foss.arm.com, nightstrike@gmail.com, wej22007@outlook.com, zac.walker@linaro.org References: <20230106012509.7918-1-mark@harmstone.com> Content-Language: en-US From: Christophe Lyon In-Reply-To: <20230106012509.7918-1-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1PR05CA0020.namprd05.prod.outlook.com (2603:10b6:806:2d2::22) To VI1PR08MB3390.eurprd08.prod.outlook.com (2603:10a6:803:7d::27) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3390:EE_|PAVPR08MB9529:EE_|AM7EUR03FT027:EE_|AM0PR08MB5314:EE_ X-MS-Office365-Filtering-Correlation-Id: 06e79777-ad30-49fc-abce-08daefcb22b9 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3R+cIBzFPLjQxrzemiILgenIT9aHSQNF1OCfMGhP+KXY7lRot7sXUt3C6Xthx9evFNDvcf0FuifAXCpo7Oz7QKo0qggTvdkH6gv4/v9HK4WnAPh7FVA9mfP+LxF9pXbWVcsVZSD1WtFp/iqbcjrSzl6GKrZlh5Qe7PtTxc3d//8mlshB5PCdwbjHVLQQJjSvPf90UD34DzM7aSHC/Y6OVqCVh8QKmohOOS/S36oDhtoTIo0oxs4YgDShwkbilXbsCGyd8NCztzGCaQSivBYvlvYIPbirzoPqdBigutNYDstx3NvMQiz+iK8W8rLpYWu5zgWdnHcaky5uHvaQJtbX4UaS9syqC/59VCnGvl6cT8dwSL722RbH8FCGFfqHo0A0hHniWK+mhtJluN42rfJbY9GJXNaGCtUB/+M30Xhis/VjnHjIhnD0VPIOdFPkysrciwjEPN/SZK5+jSf/X8rrEjJZ0XF98+a7aIjITjz9vAXuuDPtvf0K4Nff+vZiKiwYWNDYn0twHECDzldvLAJrJ2YVGKfa/bgzVbKCJ0MPRCACB64vTXUVWuTKrkohx0GVHOxgszBR+exThlunX8kBJTl1na6CLA9QuRlDi0B/JlGI453ncIVp7N/izAPy/+qSpFv/StHDk+XuSKhEssIZkP45IWKm50dV385yivH+v0eZ+8YBg7bq8ynCbEGUglovMLBaLjjzCnsHbz52sSSqnNx3ybqmm3DZAm20LSwlMwk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3390.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199015)(6486002)(26005)(6506007)(83380400001)(53546011)(6666004)(478600001)(2906002)(2616005)(86362001)(31696002)(38100700002)(316002)(6512007)(31686004)(186003)(5660300002)(8936002)(41300700001)(66476007)(44832011)(36756003)(8676002)(66946007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9529 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3fc6ccc3-cb3c-4eaf-87de-08daefcb19ec X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S/My06u52mwxAU57Db68VHaJLw5jGZeqfNSId2vNKOxi9SwniUS+TAlmDLOtDHgIvxc/2iqVUrBqgddyt+RVJZATfje+y1uVvEt3RxxyCrB2uiv7RZr8MbFqdCEwTVpCNgzR7+lykhFiqlvoF9rSl3NLFwwitYNPsJXp+h+DGg/H0bKi8Z3zDT2iyUEQm+h4GV30rQgD2C0IhIGpByF5jRPm3/C3wEQc6idf/oq2HmIAGctEX7/ur7ZEEGptKE4qZbYZxK+2fYVDKpBjBSvFrRub2rw4xL+zqdT98VQ7ua4DZWptEiL6nQGLdiVyZpe6w2DD8kwvKSQzv/mhfLzrkkLtarLMfSNUqX5ti1wqcEd5CR1cKdcrW1lEREzAKSd7FdBlmZ1D6qBFeh3sw0di97qBDfibIiFxmWpFf20XBA1v8O0p1ncTHbRzziMhRkM8QJOTs8meyi+Z2te8Rz8l/lqFg6iRjkN3gidt3DDzuqPN3/Lrce3KkDN25mtsfgV3lkM+JdZ6GHFboWu3A89pOeWU79A01hlqct14dzxk5PRv5alMZkoguLW/3urlB/NySjvMUnmOIlJn5dWdm+cK2Y8Mtlwm9v62jL7JyzemVxasOSDA/amQQIW44RAcSG0P+YqqiudTFOw40qsBn999rGu+8VZughrdh8JdLWFAqOp0VBiHXR0S73sjssx6w9h2Vt188+hQSx/ikg5UOqHNgnp/tWzB5fI4uv8gA+S+m/o= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(136003)(39860400002)(451199015)(40470700004)(46966006)(36840700001)(83380400001)(31686004)(81166007)(2616005)(316002)(40460700003)(6666004)(36756003)(86362001)(31696002)(356005)(6486002)(40480700001)(53546011)(6512007)(186003)(336012)(26005)(82740400003)(6506007)(82310400005)(478600001)(36860700001)(5660300002)(8936002)(2906002)(70206006)(47076005)(8676002)(41300700001)(44832011)(70586007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 09:48:16.5714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06e79777-ad30-49fc-abce-08daefcb22b9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5314 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! I am not a maintainer, but would you mind adding proper commit messages describing what each patch does (or intends to)? Thanks, Christophe On 1/6/23 02:25, Mark Harmstone wrote: > Resubmission of aarch64-w64-mingw32 patches against Nick's arm64pe patch. > > --- > bfd/coff-aarch64.c | 4 ---- > include/coff/aarch64.h | 3 +-- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/bfd/coff-aarch64.c b/bfd/coff-aarch64.c > index 8a514b278ee..236cbb79ffb 100644 > --- a/bfd/coff-aarch64.c > +++ b/bfd/coff-aarch64.c > @@ -188,10 +188,6 @@ coff_aarch64_rtype_lookup (unsigned int code) > #define bfd_pe_print_pdata NULL > #endif > > -/* Handle include/coff/aarch64.h external_reloc. */ > -#define SWAP_IN_RELOC_OFFSET H_GET_32 > -#define SWAP_OUT_RELOC_OFFSET H_PUT_32 > - > /* Return TRUE if this relocation should > appear in the output .reloc section. */ > > diff --git a/include/coff/aarch64.h b/include/coff/aarch64.h > index 7592661553f..4616cfef2b8 100644 > --- a/include/coff/aarch64.h > +++ b/include/coff/aarch64.h > @@ -54,11 +54,10 @@ struct external_reloc > char r_vaddr[4]; > char r_symndx[4]; > char r_type[2]; > - char r_offset[4]; > }; > > #define RELOC struct external_reloc > -#define RELSZ 14 > +#define RELSZ 10 > > /* ARM64 relocations types. */ >