From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2045.outbound.protection.outlook.com [40.107.22.45]) by sourceware.org (Postfix) with ESMTPS id 2F4FB3858C83 for ; Wed, 19 Oct 2022 14:13:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F4FB3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbJWqoJjtG5ZEElzUamlKDBQTcXAhoHBWUU3DsW2BYJ+LzQ57hTUTooPXFaxtvhcb+KPzzsu+Wj6RsF7mjkZhIaB+gZP6ZcDyHIpYCpeOBH36ZttlTDVAce68CqfT6MwCJYqftBUjRaDuDmFdZuy4LrK9asFGp/Q9Xj8sd0vysTkRYkDTgTnz/D4gTHNjUBKocghTgO8FbSC2QyLcgoBU1fKcvSE/NQy76VZOxRCu4iva4OuhI+fFE8e91GO/IGH7U5jtd0NMHWZ786urBUF+UFXFoloPhw0cUX0aWRCrmhPe9/fkub42WoPA7VfhWhqZNp5mZmq7VrVS3xfY2Fdpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E8AOkXY2iJ1Gf5WmxPDoHeloCUPfnBLj1mBDE0PTtxM=; b=OmPJzLP1qAzWwWqqM+1B1FfVat9VGdQSHEhd5EGdyvNXKu8qrcJIcY2uboskoz3scSPcCXn0guSLQporOz/eMsC30allKkBvgiRFVOMZ0JzaGNMOyTFJGAN1XVGlcAoB73PtuVHbuIG0kJbkUGx8VhpD9UO+jmcxO9DPJ/a2e8ImcBUATc5oXWQv4EvP7FmWcG2sS7EzB7FLBNEyok7GgQ2lu4zBjYAps4ucBSBM2+qbMzWdFhl7CPakn3nraI4BOaa9GNj6PadBUumMHvEh7hCdb4U1Fw/ym0PAezY+OCpPme09CkaQwf+O2osVioqiUExrLQjkGX4NeHMNEYbsBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E8AOkXY2iJ1Gf5WmxPDoHeloCUPfnBLj1mBDE0PTtxM=; b=c43D1Wo6GtVU7HD6GgwJzrDm7VuiyT22CW7uyMUBUMA6hYOkNJYIjJJYZZ5XwV/FH4d+YeBl93ISH/iYlWlKZ/72iRXSwE1J1Gc434B/MPHNROvoJyoDnjhxpYrT8XBpYbe5Fsl7erC2HYy0H7JXtIHBRVxpD4B6k5XtqlgXf7/AMFjlTDSCEr8CKXnf/i1WiTljc5NpxR8t5MAX8yLQTmUZMBA/XbtcrVM+XnpHUjN2AIvQhokBpbts+nlsvEJ9MG1V0+XnVuSM+cvZnDnbC+Cr+rjTx5XYd+cGPfHWlFgHo8f3FEWLaoXltvE6SFxvAFY57rACWUyEV1L/m+1zTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7474.eurprd04.prod.outlook.com (2603:10a6:20b:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 14:13:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 14:13:30 +0000 Message-ID: <4355cd11-c99b-0d2c-8307-fb35cbc95f4c@suse.com> Date: Wed, 19 Oct 2022 16:13:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Cui, Lili" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0059.eurprd02.prod.outlook.com (2603:10a6:20b:3a::36) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM8PR04MB7474:EE_ X-MS-Office365-Filtering-Correlation-Id: dfff0ffe-a682-4bb3-1bc1-08dab1dc1934 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +IzInWpwvOo07kaywMkCrVI8sNguzcmF4nHRseswVsayv37HYl4A+urDKpnJq0T+fpbKRcl/E/IcnEkNxdk8u0OJYk03RYYQmxoRHP3iG3lmdkQGxie3y+SoJc9PMfX8aWVu/BR4Buc1na6LvVsQQym8Jzw9tMSBbfV3QdYd8zZ9leHi0tbrlvkmmDJF/lOz5zvpVsnviqb3J6uEpRRVkp01kLYhnlYEkYCqkxxebq6II/aRHEIvlLCVoc62nNGswCq8qo3Dj/elCf2uLC9IbbdEvTXlg9q0U0sdg6Haj89CAoPamVEf2idBsoiK40J0jIUw4YWZH5+W1iGnKzxtugRxktZ79UKu8+sIsKAcyiYRbq+8dwYK8K+SW9tWy1Kr/Ny3RJvj54Khy0jwRGDRA8x4j55yGBK8dfDsD7PUh6UNfFKmuN+zrltm18n5dtZZG+u8JUsS9oWi2pHvjhEs60R+TNetuhzV3inw/atfSVF9zfBSkdI/YUXP0mzuSvgTp+UKZ6lsUBkYs1cbTCNaTH9WkCAv4dvgktG11diumAqSRBpGQiE1mwB7vpSs1q1KlJCOfcMjDS4BzDL41SSziv63Knk6sF7CrinVM4Gj4BmrPZZY8v1gnFX2qvmhL20Z6xKOMCUzzoYNq8iJrE6BNkSDbuweTq13BFfMWHgpyPoYGyscNsHOrdqTUU0lISZcdKhNZZJeKyti9LP1pbsf0ihn47JTr2Y7cB+e2qZr9KzrQ0eqfEqZK2kmgvUdz/0+M2HGwXGPaudjabpd2glPeWKU1lb1vIOdXaIR0lhj6kM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(346002)(366004)(39860400002)(376002)(451199015)(31696002)(83380400001)(86362001)(54906003)(66556008)(6916009)(66476007)(186003)(38100700002)(8936002)(66946007)(5660300002)(53546011)(4326008)(2906002)(41300700001)(8676002)(6506007)(26005)(2616005)(6512007)(6486002)(478600001)(316002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3F5bG9tTjVFdUcvOThsYlJUcWxyUzRPMmk4UE85STNKSDVEY3FVc1BRNERm?= =?utf-8?B?SWVaZTJIUEY2NUtQdk1BZFp4NlVaL1pEa3ZWVllGS1FBYWdJTk03UTZRbkZl?= =?utf-8?B?cCs5ZndoNlVyUzZ2Z0lycjRvNndONG1KYzBwcThRcWNqYkEvakRHbExMWWFn?= =?utf-8?B?YkU5SkFTUFZEWWFrUTVxWDRFTnQ1bU9jU2V3ZUpnNjVFRnRhYVcyY2srNVRK?= =?utf-8?B?UEV5SG5ud0lPZnNSeG92aWZQbndIbnB3VURWZUc5YTQ0bi9UVTRmQ2JJbE5u?= =?utf-8?B?YWRqMTQ4RjVzeE1TeWtmMW0zdklsQVVDSGJSV1BIMHMwMElUNnFQbDRnanRM?= =?utf-8?B?R1VmOXdPR3o5WjdJVU5MS1FHQlVyY3pVRUdLMTBzZDdwRzJPN3dYL01wUUww?= =?utf-8?B?T2tKc3FNVjJqVEN1WDRrN3VvNW9SVlMrVlFCbi9mOWFsWGQwQWJGcVRtZGZ2?= =?utf-8?B?R055R1pDeE15UGZBMGtwNnpveGEwdVFsblNQbTdyNTdRNkloMWI4VkN6RHJq?= =?utf-8?B?UFd5VituNU9wdGp1eHNtdzA0UDh6MXRyMGlWVGNhb2M2Ni9TRVpLK2ZGaUUw?= =?utf-8?B?V0FKeGxPL09ORjl2YStYc0lZdFRxUzVtT3Z3dXAydjJaWWt2Zks2UHc0ZjNW?= =?utf-8?B?bmd1V1ZJU1hsR1ZlVkxwM3J3cHEvdkFBaDU1THllMlEzT0gwdHI5aG1jL3lS?= =?utf-8?B?NlBWNjdLV1lBdC91Tm4xSWhlRWdxWXpVbjdzUVhyc2RrVVBkN3JYZm8ySkNa?= =?utf-8?B?NG9Udi9tUVZhTHNidkp1NXBwRHNrZzFPNkp5OG9XM2RLZUlUNVlGWHN0Q0hM?= =?utf-8?B?V2ZWK05yL2NOaW54RFFkTkYvdm9oY0M2UmdVZzZPNE96OWh6MGpxZjFCUTlz?= =?utf-8?B?bTFFRFdBNG9Dc3RuWkpWRlJmMWJ3YldyQ3NwN2NiMFBKTXNESTNocks1aGFi?= =?utf-8?B?clJaNnVIV3F3T1I1a0gyakh0Y2t4aUQybmdkZHVEbFBBaHN1RHJQNUs2d3N6?= =?utf-8?B?Z1pNR25oeGx4K1NIbkdEbHZSa2poak41SGlFQ1E5Q1psQVFjTFhDc2RpQXJX?= =?utf-8?B?cWNPM3ZjejBaVlBjUlYwTThvUENFV2Y3WUpvNGEzdUdoVDVFcDNjU3ZUbXdW?= =?utf-8?B?bkU3MmR6bDQ2eUhVZWNBVnBvTElpcHV5RElwU2NaWGtiaFZmT1ZFUFBXdFl3?= =?utf-8?B?eUFPZjZWR3JEckNaKzR5NzVBa1JYdVFvaGltUnVLM0NCYnQ3UllwdE9Bdkdu?= =?utf-8?B?cWlEK1MzeS9yMWpwbW1mQ3RSUU5xSzhJUjNDSHlMUENFamw0QnlCblRXdEdH?= =?utf-8?B?NEx1MVVCcFR1d0FNUEpxTHlNVFhiUHdZQytMbEdJQzRnWmJna0dzdnB4NFlJ?= =?utf-8?B?REE5MkFmdEVXYjBDTWgyTHlTMUc3ODVTRkoyVkNOVG1yMFBiRlZDQlJrZFFw?= =?utf-8?B?NEFtRTBWZ3Y1b1hrUi9GUHNDK0hFa0FqckFmUlY1VllvY0hyZGovTmNyU1VO?= =?utf-8?B?Q1NpK0lKM2tWSDNCcDVaQjgvOVhnMDgvRlk3SVRkcGE5b1UzOE9kbDQ5bUVM?= =?utf-8?B?U2s5WnRkZ2orQ3prbkoya0JINjRPdngrQmFvaEZ6czhlUlVjVU1GSFNZeGt3?= =?utf-8?B?cTQ1UWdMUmlWaVRYNXowRFVuOEI3ZTRBTWVaZlFxeDE3UFpyQTIwMlVTNFg4?= =?utf-8?B?QmJsYjQ5bFgxb0ZPS2U1aDNnbWNhLzZxbzZMTHBRSzUzbTdGUnpER2djYnhO?= =?utf-8?B?NlVHRlBrTWtoZ1p0Y1NUMVNBTitnTmxZOWZSTzZpOHU0MFgraVppaUNxcVNk?= =?utf-8?B?TTc2U3NRclpxbDhlQWROdmJPVVp2NXQrL1J5aEszdTVxTHlrUUVBOEdFTVZM?= =?utf-8?B?TzJudmJjaklkNVJ2bXFqZGV0N2s1enZ3ZHRDMU1HU1hEWmJ2NTJGYS9wekVI?= =?utf-8?B?WXptUG1oY3pkeWxYdmNZcG95NTROYnZ2RkxXSzdkalhyWjl2V0h5NERVWkZ4?= =?utf-8?B?L0t6VFZQK0JtTGRpWUIwRzBwTFZvM1FxT21ycDRXZ1JTdExtUlo5ais3alBK?= =?utf-8?B?bFdaYUNCaFRrQTlyOGlXbFl1UjFFMi9RRzRDcFQ2Qy9TWkJpbmZDS1hGVU44?= =?utf-8?Q?ps03kKqH4hdHe7y8LQWOZKZ0t?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfff0ffe-a682-4bb3-1bc1-08dab1dc1934 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 14:13:30.1519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5PbnjHUfiQuq41ddrK5FdU6Tu0T1T28l+EKVJbhtZzzTN954OIRB30k/1hUPMicfJEhptOaylSkfNeKgB5kZuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7474 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.10.2022 16:01, Jiang, Haochen wrote: >> -----Original Message----- >> From: Cui, Lili >> Sent: Wednesday, October 19, 2022 6:34 PM >> >>>>>> - "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16" }, >>>>>> + "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16|CpuAMX_FP16" }, >>>>>> { "CPU_ANY_MSRLIST_FLAGS", >>>>>> "CpuMSRLIST" }, >>>>>> + { "CPU_ANY_AMX_FP16_FLAGS", >>>>>> + "CpuAMX_FP16" }, >>>>>> }; >>>>> >>>>> Same here then. >>>> Done. >>> >>> I guess my comment here was a little misleading (I'm sorry for that), >>> in that in addition I was expecting you to consider the comment >>> regarding the need for the *_ANY_* constants that I did give for several of the >> patches in this series. >>> I think the question applies here as well: Are there dependent >>> features known to appear? If not, there's no need for the extra constant. >>> >> Get you, there are no known dependencies now, and I will pay attention on it in >> future ISAs. > > But I suppose for AMX-FP16, the possibility of potential dependency is bigger than > some like CMPCCXADD, MSRLIST. Since FP16 type is not that rare. If you go look you'll find that we don't have ANY_* for a fair part (if not a majority) of the features). Plus AMX-FP16 as a feature name suggests more generality than there really is - the feature is about a specific multiplication insn, not (like e.g. AVX512-FP16) about the introduction of a set of insns on a basic data type (whether the set of insns could of course widen down the road, and where the further ISAs would depend on the more basic operations on that data type). Jan