public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* fix Xtensa --text-section-literals option for GNU/Linux
@ 2006-03-06 19:16 Bob Wilson
  0 siblings, 0 replies; only message in thread
From: Bob Wilson @ 2006-03-06 19:16 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

It appears that I broke the Xtensa assembler's --text-section-literals option 
for GNU/Linux over a year ago.  I changed the linker to require that all dynamic 
relocations be inside marked literal pools, but the assembler has not been 
marking those literal pools when using the --text-section-literals option.  This 
patch simply changes gas to always mark the literal pools.  Tested by linking a 
small program built with --text-section-literals for an xtensa-linux target, and 
also by running the testsuite for an xtensa-elf target.  Committed on the mainline.

2006-03-06  Bob Wilson  <bob.wilson@acm.org>

	* config/tc-xtensa.c (xtensa_post_relax_hook): Generate literal tables
	even when using the text-section-literals option.


[-- Attachment #2: gas-lit-tables.diff --]
[-- Type: text/x-patch, Size: 803 bytes --]

Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.57
diff -u -p -r1.57 tc-xtensa.c
--- config/tc-xtensa.c	14 Feb 2006 00:58:05 -0000	1.57
+++ config/tc-xtensa.c	6 Mar 2006 17:32:07 -0000
@@ -10078,11 +10078,10 @@ xtensa_post_relax_hook (void)
 
   xtensa_find_unmarked_state_frags ();
 
-  if (use_literal_section)
-    xtensa_create_property_segments (get_frag_is_literal,
-				     NULL,
-				     XTENSA_LIT_SEC_NAME,
-				     xt_literal_sec);
+  xtensa_create_property_segments (get_frag_is_literal,
+				   NULL,
+				   XTENSA_LIT_SEC_NAME,
+				   xt_literal_sec);
   xtensa_create_xproperty_segments (get_frag_property_flags,
 				    XTENSA_PROP_SEC_NAME,
 				    xt_prop_sec);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-03-06 19:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-06 19:16 fix Xtensa --text-section-literals option for GNU/Linux Bob Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).