From: Nick Clifton <nickc@redhat.com>
To: Julian Brown <julian@codesourcery.com>
Cc: binutils@sources.redhat.com, Paul Brook <paul@codesourcery.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH, ARM] Fix Neon floating-point constant encoding & support floating-point syntax
Date: Wed, 26 Apr 2006 11:58:00 -0000 [thread overview]
Message-ID: <444F3E81.3070902@redhat.com> (raw)
In-Reply-To: <444EC119.2030802@codesourcery.com>
Hi Julian,
> Thanks! I've got a slightly-improved version of this patch thanks to
> offline discussion with Paul Brook though, which uses a generic function
> to help with the printing of float immediates. It relies on this
> (applied) fix:
>
> http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00925.html
>
> The only differences are in arm-dis.c, and a small cleanup in
> is_quarter_float. Sorry for the hassle (the difference is probably small
> enough to count as obvious), but is this still OK to apply on mainline?
> (And also on the CSL branch?).
OK for mainline.
Check with CodeSourcery for permission to check into the CSL branch, but
I expect that since you have been talking to Paul that they will have no
objection.
Cheers
Nick
> ChangeLog (gas):
>
> * gas/config/tc-arm.c (neon_is_quarter_float): Move, and rename
> to...
> (is_quarter_float): Rename from above. Simplify slightly.
> (parse_qfloat_immediate): Parse a "quarter precision" floating-point
> number.
> (parse_neon_mov): Parse floating-point constants.
> (neon_qfloat_bits): Fix encoding.
> (neon_cmode_for_move_imm): Tweak to use floating-point encoding in
> preference to integer encoding when using the F32 type.
>
> ChangeLog (gas/testsuite):
>
> * gas/testsuite/gas/arm/neon-const.s: New testcase. Neon
> floating-point constants.
> * gas/testsuite/gas/arm/neon-const.d: Expected output of above.
> * gas/testsuite/gas/arm/neon-cov.d: Expect floating-point
> disassembly for VMOV.F32.
>
> ChangeLog (opcodes):
>
> * arm-dis.c (print_insn_neon): Disassemble floating-point constant
> VMOV.
PS. Usually you would either delete these files or else put them into
your global .cvsignore before performing the diff:
> ? bfd/doc/bfd.info
> ? binutils/doc/binutils.info
> ? gas/doc/as.info
> ? ld/ld.info
next prev parent reply other threads:[~2006-04-26 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 12:28 Julian Brown
2006-04-25 19:46 ` Nick Clifton
2006-04-26 8:55 ` Julian Brown
2006-04-26 11:58 ` Nick Clifton [this message]
2006-04-27 0:35 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444F3E81.3070902@redhat.com \
--to=nickc@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sources.redhat.com \
--cc=julian@codesourcery.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).