From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9932 invoked by alias); 26 Apr 2006 09:34:04 -0000 Received: (qmail 9922 invoked by uid 22791); 26 Apr 2006 09:34:04 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Apr 2006 09:34:02 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3Q9Y1xe014524; Wed, 26 Apr 2006 05:34:01 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3Q9XtV0010291; Wed, 26 Apr 2006 05:33:55 -0400 Received: from [10.32.68.7] (vpn-68-7.surrey.redhat.com [10.32.68.7]) by pobox.surrey.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3Q9XsLA006896; Wed, 26 Apr 2006 10:33:54 +0100 Message-ID: <444F3E81.3070902@redhat.com> Date: Wed, 26 Apr 2006 11:58:00 -0000 From: Nick Clifton User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: Julian Brown CC: binutils@sources.redhat.com, Paul Brook , Richard Earnshaw Subject: Re: [PATCH, ARM] Fix Neon floating-point constant encoding & support floating-point syntax References: <444BE24D.1010405@codesourcery.com> <444E5DC6.70404@redhat.com> <444EC119.2030802@codesourcery.com> In-Reply-To: <444EC119.2030802@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00374.txt.bz2 Hi Julian, > Thanks! I've got a slightly-improved version of this patch thanks to > offline discussion with Paul Brook though, which uses a generic function > to help with the printing of float immediates. It relies on this > (applied) fix: > > http://gcc.gnu.org/ml/gcc-patches/2006-04/msg00925.html > > The only differences are in arm-dis.c, and a small cleanup in > is_quarter_float. Sorry for the hassle (the difference is probably small > enough to count as obvious), but is this still OK to apply on mainline? > (And also on the CSL branch?). OK for mainline. Check with CodeSourcery for permission to check into the CSL branch, but I expect that since you have been talking to Paul that they will have no objection. Cheers Nick > ChangeLog (gas): > > * gas/config/tc-arm.c (neon_is_quarter_float): Move, and rename > to... > (is_quarter_float): Rename from above. Simplify slightly. > (parse_qfloat_immediate): Parse a "quarter precision" floating-point > number. > (parse_neon_mov): Parse floating-point constants. > (neon_qfloat_bits): Fix encoding. > (neon_cmode_for_move_imm): Tweak to use floating-point encoding in > preference to integer encoding when using the F32 type. > > ChangeLog (gas/testsuite): > > * gas/testsuite/gas/arm/neon-const.s: New testcase. Neon > floating-point constants. > * gas/testsuite/gas/arm/neon-const.d: Expected output of above. > * gas/testsuite/gas/arm/neon-cov.d: Expect floating-point > disassembly for VMOV.F32. > > ChangeLog (opcodes): > > * arm-dis.c (print_insn_neon): Disassemble floating-point constant > VMOV. PS. Usually you would either delete these files or else put them into your global .cvsignore before performing the diff: > ? bfd/doc/bfd.info > ? binutils/doc/binutils.info > ? gas/doc/as.info > ? ld/ld.info