From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-45607-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 11308 invoked by alias); 26 Apr 2006 09:38:12 -0000
Received: (qmail 11296 invoked by uid 22791); 26 Apr 2006 09:38:11 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Apr 2006 09:38:09 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3Q9c7os015854; 	Wed, 26 Apr 2006 05:38:07 -0400
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) 	by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3Q9c63G011202; 	Wed, 26 Apr 2006 05:38:07 -0400
Received: from [10.32.68.7] (vpn-68-7.surrey.redhat.com [10.32.68.7]) 	by pobox.surrey.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k3Q9c4TP007210; 	Wed, 26 Apr 2006 10:38:04 +0100
Message-ID: <444F3F7C.6010800@redhat.com>
Date: Wed, 26 Apr 2006 12:16:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Thunderbird 1.5 (X11/20051201)
MIME-Version: 1.0
To: "H. J. Lu" <hjl@lucon.org>
CC: Andrew STUBBS <andrew.stubbs@st.com>, binutils@sources.redhat.com
Subject: Re: PATCH: binutils/2593: Problem setting the CONTENTS flag
References: <4448D6E0.2090907@st.com> <20060421143558.GA13559@lucon.org> <20060421232208.GA16651@lucon.org> <444E3E55.2080308@redhat.com> <20060425200425.GA31700@lucon.org>
In-Reply-To: <20060425200425.GA31700@lucon.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2006-04/txt/msg00375.txt.bz2

Hi H.J.

>> There are a couple of minor problems with this version of the patch:
> I will look into them.

Thanks.

> Here is a patch to add 2 tests for objcopy. The second test both
> fail on i386-aout and i386-coff. They don't set .text to DATA.

This patch (to add the tests) is approved.

Cheers
   Nick

> 2006-04-25  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR binutils/2593
> 	* binutils-all/copy-1.d: New file.
> 	* binutils-all/copy-1.s: Likewise.
> 	* binutils-all/copy-2.d: Likewise.
> 
> 	* binutils-all/objcopy.exp: Add run_dump_test "copy-1" and
> 	run_dump_test "copy-2".
> 
> 	* lib/utils-lib.exp (run_dump_test): New.
> 	(slurp_options): Likewise.
> 	(regexp_diff): Likewise.
> 	(file_contents): Likewise.
> 	(verbose_eval): Likewise.