From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2320 invoked by alias); 2 May 2006 09:48:08 -0000 Received: (qmail 2308 invoked by uid 22791); 2 May 2006 09:48:07 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 May 2006 09:48:05 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k429m3xI029459; Tue, 2 May 2006 05:48:03 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k429m276020248; Tue, 2 May 2006 05:48:02 -0400 Received: from [10.32.68.10] (vpn-68-10.surrey.redhat.com [10.32.68.10]) by pobox.surrey.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k429lw7n022322; Tue, 2 May 2006 10:48:01 +0100 Message-ID: <44572AAF.4080203@redhat.com> Date: Tue, 02 May 2006 09:48:00 -0000 From: Nick Clifton User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: "H. J. Lu" CC: binutils@sources.redhat.com Subject: Re: PATCH: Fix buffer overflow in gas References: <20060501184006.GA2583@lucon.org> In-Reply-To: <20060501184006.GA2583@lucon.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00028.txt.bz2 Hi H. J. > There are some potential buffer overflows in gas. 8byte isn't enough > to hold a negative byte. This patch fixes them. Also we should use > snprintf instead of sprintf. Did you test this patch ? if so, please could you say how. > 2006-05-01 H.J. Lu > > * config/tc-i386.c (output_invalid_buf): Change size to 16. > * config/tc-tic30.c (output_invalid_buf): Likewise. > > * config/tc-i386.c (output_invalid): Use snprintf instead of > sprintf. > * config/tc-ia64.c (declare_register_set): Likewise. > (emit_one_bundle): Likewise. > (check_dependencies): Likewise. > * config/tc-tic30.c (output_invalid): Likewise. Assuming that you have tested the targets involved and that there were no regressions then this patch is approved. Cheers Nick