public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Denis Vlasenko <vda@ilport.com.ua>, binutils@sourceware.org
Subject: Re: as bug
Date: Sun, 07 May 2006 23:03:00 -0000	[thread overview]
Message-ID: <445E08B9.2080305@redhat.com> (raw)
In-Reply-To: <20060506065836.GF11597@bubble.grove.modra.org>

Hi Alan,

> +		      /* Don't error on first few frag relax passes.  */
> +		      if (pass < 2)
> +			{
> +			  /* Force another pass.  */
> +			  ret = 1;
> +			  break;
> +			}

I think that it might help if you include a comment saying *why* the 
first two passes should ignore a negative growth value.

Cheers
   Nick

  reply	other threads:[~2006-05-07 14:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060419094630.GA14800@elte.hu>
     [not found] ` <20060420152609.GA21993@elte.hu>
     [not found]   ` <20060421074858.GA28858@elte.hu>
2006-05-05  8:41     ` as bug (was: Re: smp/up alternatives crash when CONFIG_HOTPLUG_CPU) Denis Vlasenko
2006-05-05  8:46       ` Denis Vlasenko
2006-05-05  9:41         ` Denis Vlasenko
2006-05-05 12:23         ` Alan Modra
2006-05-05 12:26           ` Alan Modra
2006-05-05 13:38           ` Denis Vlasenko
2006-05-05 14:21             ` Denis Vlasenko
2006-05-06 11:24             ` Alan Modra
2006-05-06 11:26               ` Alan Modra
2006-05-07 23:03                 ` Nick Clifton [this message]
2006-05-08 12:15                   ` as bug Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=445E08B9.2080305@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=vda@ilport.com.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).