public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Julian Brown <julian@codesourcery.com>
To: Alan Modra <amodra@bigpond.net.au>
Cc: binutils@sourceware.org,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	  Paul Brook <paul@codesourcery.com>
Subject: Re: [PATCH] Fix section symbols in objcopy when removing sections  with  relocations from Elf objects
Date: Thu, 25 May 2006 23:10:00 -0000	[thread overview]
Message-ID: <4475E10B.8090504@codesourcery.com> (raw)
In-Reply-To: <20060525145627.GH25824@bubble.grove.modra.org>

Hi,

Alan Modra wrote:
>	* elf.c (sym_is_global): Return a bfd_boolean.
> 	(ignore_section_sym): New function.
> 	(elf_map_symbols): Use ignore_section_sym to discard some syms.
> 	(_bfd_elf_symbol_from_bfd_symbol): Ensure section belongs to
> 	bfd before using elf_section_syms.

Thanks very much for looking into this! It's far preferable that the fix 
is in Elf-specific code rather than the generic code, I agree. FYI, this 
patch fixes the original problem just fine, and I've committed it on our 
binutils-csl-2_17-branch.

Cheers,

Julian

      reply	other threads:[~2006-05-25 16:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24 16:20 Julian Brown
2006-05-24 17:23 ` Julian Brown
2006-05-25  0:58   ` H. J. Lu
2006-05-25 13:28 ` Alan Modra
2006-05-25 21:44   ` Alan Modra
2006-05-25 23:10     ` Julian Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4475E10B.8090504@codesourcery.com \
    --to=julian@codesourcery.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sourceware.org \
    --cc=paul@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).