public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Julian Brown <julian@codesourcery.com>
To: binutils@sourceware.org
Subject: [PATCH, ARM] Fix disassembly of 32-bit immediates for VMOV, etc.  on 64-bit hosts
Date: Fri, 09 Jun 2006 17:01:00 -0000	[thread overview]
Message-ID: <4489A888.3090005@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi,

This patch fixes some testsuite failures where differences in the size 
of long lead to differences in disassembly on arm-none-eabi. This patch 
leads to the same behaviour as 32-bit hosts -- top-bit-set constants are 
output as signed rather than unsigned integers.

OK to apply?

Cheers,

Julian

ChangeLog (opcodes):

     * arm-dis.c (print_insn_neon): Disassemble 32-bit immediates as
     signed on 64-bit hosts.

[-- Attachment #2: neon-opcodes-64bit-host-1 --]
[-- Type: text/plain, Size: 977 bytes --]

Index: arm-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/arm-dis.c,v
retrieving revision 1.66
diff -c -p -r1.66 arm-dis.c
*** arm-dis.c	7 Jun 2006 14:08:19 -0000	1.66
--- arm-dis.c	9 Jun 2006 16:42:08 -0000
*************** print_insn_neon (struct disassemble_info
*** 2417,2423 ****
                                        value);
                                }
                              else
!                               func (stream, "#%ld\t; 0x%.8lx", value, value);
                              break;
  
                            case 64:
--- 2417,2425 ----
                                        value);
                                }
                              else
!                               func (stream, "#%ld\t; 0x%.8lx",
! 				(long) ((value & 0x80000000)
! 					? value | ~0xffffffffl : value), value);
                              break;
  
                            case 64:

             reply	other threads:[~2006-06-09 16:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-09 17:01 Julian Brown [this message]
2006-06-12 11:00 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4489A888.3090005@codesourcery.com \
    --to=julian@codesourcery.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).