Re: [PATCH]: Set little endian flag when linking SH arch tests for little endian multilibs

[Nick Clifton <nickc@redhat.com>]

Hi Andrew,

>>> For reasons I do not understand I found that if I included the above 
>>> part of the patch to arch.exp I ended up with *more* SH linker 
>>> testsuite failures (for little endian multilibs) than without it.  

>> Hmmm, did you use both parts of the patch?

Well I used my version of it, but essentially yes.

> Well, I did the tests with and without my two-part patch.
> 
> Without:
>                 === ld Summary for sh-sim/-ml ===
> 
> # of expected passes            133
> # of unexpected failures        357
> # of expected failures          1
> # of unresolved testcases       14
> # of untested testcases         378

> With:
>                 === ld Summary for sh-sim/-ml ===
> 
> # of expected passes            797
> # of unexpected failures        80
> # of expected failures          1
> # of untested testcases         21

> So that's quite considerably better. I have not looked at what causes 
> the 65 additional failures in little endian, 

This is where I thought that the second part of the patch was giving 
problems.  Without it I get only 33 unexpected failures for the "-ml" 
multilib... I suspect however that this was connected to the fact that 
some architecture variants do not support little endian and the tests do 
not current make allowances for this.

Anyway thanks very much for looking into this, and I am sure that at 
some date somebody will finish off the work and fix the remaining failures.

Cheers
   Nick