From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14213 invoked by alias); 4 Aug 2006 14:50:22 -0000 Received: (qmail 14203 invoked by uid 22791); 4 Aug 2006 14:50:21 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 04 Aug 2006 14:50:16 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k74EoE9k017703; Fri, 4 Aug 2006 10:50:14 -0400 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k74EoAat030036; Fri, 4 Aug 2006 10:50:13 -0400 Received: from [10.32.68.8] (vpn-68-8.surrey.redhat.com [10.32.68.8]) by pobox.surrey.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k74Eo9Vb019477; Fri, 4 Aug 2006 15:50:10 +0100 Message-ID: <44D35EA1.3060603@redhat.com> Date: Fri, 04 Aug 2006 14:50:00 -0000 From: Nick Clifton User-Agent: Thunderbird 1.5.0.4 (X11/20060516) MIME-Version: 1.0 To: "H. J. Lu" , Marcelo Tosatti CC: binutils@sources.redhat.com Subject: Re: [binutils patch]: -print-gc-sections option: print garbage collected sections References: <20060701231428.GA23415@dmt> <20060707222120.GA29900@lucon.org> In-Reply-To: <20060707222120.GA29900@lucon.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00047.txt.bz2 Hi H.J., Hi Marcelo, > I am forwarding it to the binutils mailing list. I apologise for taking so long to getting round to reviewing this patch. As it stands the patch is OK, but incomplete. So I have taken the liberty of applying it along with the following changes: * I added a --no-print-gc-sections switch so that the option can be turned off. * I added documentation to the ld.texinfo file describing the new switches. * I added an entry to the ld/NEWS file describing the new feature. * I changed the message that is printed so that it explicitly states that it is telling the user about a deleted section, and I used the bfd error handler routine so that the correct filename can be displayed. * I created a set of ChangeLog entries for the patch. Cheers Nick ld/ChangeLog 2006-08-04 Marcelo Tosatti * ldmain.c (main): Initialise print_gc_sections field of link_info structure. * lexsup.c: Add --print-gc-sections and --no-print-gc-sections switches. * ld.texinfo: Document new switches. * NEWS: Mention new switches. include/ChangeLog 2006-08-04 Marcelo Tosatti * bfdlink.h (struct bfd_link_info): New field: print_gc_sections. bfd/ChangeLog 2006-08-04 Marcelo Tosatti * elflink.c (elf_gc_sweep): If info.print_gc_sections is true, list removed sections to stderr.