public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH]: Trivial testsuite fix for arm-coff
@ 2006-08-04 18:52 Pedro Alves
  2006-08-06 14:04 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Pedro Alves @ 2006-08-04 18:52 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

Hi all,

There is a FAIL in the gas testsuite for arm-coff targets,
on the gas/arm/thumb2_add test.
This FAIL is related to the usage of the elf-only pseudo ".type",
so I think it is a test bug.

Attached is a patch that fixes the issue by simply removing the 
offending line.

Tested on arm-none-coff and arm-none-eabi.

2006-08-04  Pedro Alves  <pedro_alves@portugalmail.pt>

gas/testsuite
	* gas/arm/thumb2_add.s: Don't use elf specific ".type"
	pseudo-op.

Cheers,
Pedro Alves


[-- Attachment #2: thumb2_add.s.diff --]
[-- Type: text/plain, Size: 431 bytes --]

Index: thumb2_add.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arm/thumb2_add.s,v
retrieving revision 1.1
diff -u -r1.1 thumb2_add.s
--- thumb2_add.s	18 Jul 2006 16:44:47 -0000	1.1
+++ thumb2_add.s	4 Aug 2006 18:45:09 -0000
@@ -4,7 +4,6 @@
 	.global	thumb2_add
 	.thumb
 	.thumb_func
-	.type	thumb2_add, %function
 thumb2_add:
 	add r0, pc, #0x800
 	add r9, pc, #0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH]: Trivial testsuite fix for arm-coff
  2006-08-04 18:52 [PATCH]: Trivial testsuite fix for arm-coff Pedro Alves
@ 2006-08-06 14:04 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2006-08-06 14:04 UTC (permalink / raw)
  To: Pedro Alves; +Cc: binutils

Hi Pedro,

> 2006-08-04  Pedro Alves  <pedro_alves@portugalmail.pt>
> gas/testsuite
>     * gas/arm/thumb2_add.s: Don't use elf specific ".type"
>     pseudo-op.

Approved - please apply.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-06 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-08-04 18:52 [PATCH]: Trivial testsuite fix for arm-coff Pedro Alves
2006-08-06 14:04 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).