Nick Clifton wrote:
> Hi Pedro,
> 
>> Updated patch for gas attached.
> 
> There are still a few minor problems with this part of the patch:
> 
>> +#ifdef TE_PE
>> +static void pe_directive_secrel PARAMS ((int));
> 
> There is no need for this declaration, it is redundant.  Plus we are not 
> using the PARAMS macro any more.
> 
>> +static void
>> +pe_directive_secrel (dummy)
>> +int dummy ATTRIBUTE_UNUSED;
> 
> We are following the ISO-C90 standard now, so the type qualifiers for 
> function arguments should be included in the declaration, ie:
> 
>   pe_directive_secrel (int dummy ATTRIBUTE_UNUSED)
> 
> 
> With these two changes the entire patch is approved.
> 

Thanks.

Attached is the updated gas patch with Nick's requested changes, and 
also the previous bfd and ld testsuite patches.

Nick, just to be sure, with "entire patch", you mean bfd+gas+ld, or just
gas?

Also, since I don't have commit privileges, could someone else (Nick?)
please commit them?

(Same for:
http://sourceware.org/ml/binutils/2006-08/msg00057.html
http://sourceware.org/ml/binutils/2006-08/msg00056.html)

Cheers,
Pedro Alves



----

bfd/ChangeLog
2006-08-05  Pedro Alves  <pedro_alves@portugalmail.pt>

     * bfd.c (bfd_get_sign_extend_vma): Add cases for pe-arm-little
     and pei-arm-little.
     * coff-arm.c (coff_arm_rtype_to_howto) [COFF_WITH_PE]: Handle
     ARM_SECREL.
     (coff_arm_reloc_type_lookup): Map BFD_RELOC_32_SECREL to
     ARM_SECREL.
     * pe-arm.c [COFF_SECTION_ALIGNMENT_ENTRIES]: Define.
     * pei-arm.c [TARGET_UNDERSCORE]: Define for ARM_WINCE like in
     pe-arm.c.
     [COFF_SECTION_ALIGNMENT_ENTRIES]: Define.

---

gas/ChangeLog
2006-08-05  Pedro Alves  <pedro_alves@portugalmail.pt>

     * config/tc-arm.c: Move "dwarf2dbg.h" inclusion out of OBJ_ELF
     only block.
     (pe_directive_secrel) [TE_PE]: New function.
     (md_pseudo_table) [!OBJ_ELF]: Handle 2byte, 4byte, 8byte, file,
     loc, loc_mark_labels.
     [TE_PE]: Handle secrel32.
     (output_relax_insn): Remove OBJ_ELF around dwarf2_emit_insn
     call.
     (output_inst): Remove OBJ_ELF around dwarf2_emit_insn call.
     (arm_frob_label): Remove OBJ_ELF around dwarf2_emit_label call.
     (md_section_align): Only round section sizes here for AOUT
     targets.
     (tc_arm_regname_to_dw2regnum): Move out for OBJ_ELF only block.
     (tc_pe_dwarf2_emit_offset): New function.
     (md_apply_fix) [TE_PE]: Handle BFD_RELOC_32_SECREL.
     (cons_fix_new_arm): Handle O_secrel.
     * config/tc-arm.h : Move DWARF2_LINE_MIN_INSN_LENGTH,
     DWARF2_DEFAULT_RETURN_COLUMN and DWARF2_CIE_DATA_ALIGNMENT out
     of OBJ_ELF only block.
     [TE_PE]: Define O_secrel, TC_DWARF2_EMIT_OFFSET, and declare
     tc_pe_dwarf2_emit_offset.

---

ld/testsuite
2006-08-05  Pedro Alves  <pedro_alves@portugalmail.pt>

     * ld-pe/pe.exp: Enable tests on arm-wince-pe.
     * ld-pe/secrel.d: Adjust test to work on arm-wince-pe too.