From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10383 invoked by alias); 24 Aug 2006 13:07:28 -0000 Received: (qmail 8999 invoked from network); 24 Aug 2006 13:07:13 -0000 Received: from unknown (195.23.133.213) by sourceware.org with QMTP; 24 Aug 2006 13:07:13 -0000 Received: (qmail 28445 invoked from network); 24 Aug 2006 13:07:11 -0000 Received: from unknown (HELO mailfrt10.isp.novis.pt) ([195.23.133.202]) (envelope-sender ) by mailrly03.isp.novis.pt with compressed SMTP; 24 Aug 2006 13:07:11 -0000 Received: (qmail 8925 invoked from network); 24 Aug 2006 13:07:07 -0000 Received: from unknown (HELO [127.0.0.1]) ([195.23.225.236]) (envelope-sender ) by mailfrt10.isp.novis.pt with SMTP; 24 Aug 2006 13:07:07 -0000 Message-ID: <44EDA482.3080109@portugalmail.pt> Date: Thu, 24 Aug 2006 15:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/20060719 Thunderbird/1.5.0.5 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: binutils@sourceware.org Subject: Re: [PATCH]: Fix ld bug triggered in arm-*-pe (?) References: <44E0FE94.5080503@portugalmail.pt> <20060815014754.GA19960@bubble.grove.modra.org> In-Reply-To: <20060815014754.GA19960@bubble.grove.modra.org> Content-Type: multipart/mixed; boundary="------------050201050302030206010008" X-Antivirus: avast! (VPS 0634-2, 24-08-2006), Outbound message X-Antivirus-Status: Clean X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-08/txt/msg00274.txt.bz2 This is a multi-part message in MIME format. --------------050201050302030206010008 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 653 Alan Modra wrote: > On Mon, Aug 14, 2006 at 11:52:04PM +0100, Pedro Alves wrote: >> * ldlang.c (lang_size_sections_1, lang_assignment_statement_enum): >> Adjust the current address of DEFAULT_MEMORY_REGION even >> when dot hasn't changed. > > This is OK. > Thanks, Could someone commit this, please? Attached is the same patch, but with the formatting fixed, for your convenience. Cheers, Pedro Alves --- ld/ChangeLog 2006-08-24 Pedro Alves * ldlang.c (lang_size_sections_1, lang_assignment_statement_enum): Adjust the current address of DEFAULT_MEMORY_REGION even when dot hasn't changed. --------------050201050302030206010008 Content-Type: text/plain; name="ldlang.c.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ldlang.c.diff" Content-length: 849 Index: ldlang.c =================================================================== RCS file: /cvs/src/src/ld/ldlang.c,v retrieving revision 1.235 diff -u -p -r1.235 ldlang.c --- ldlang.c 22 Aug 2006 07:41:05 -0000 1.235 +++ ldlang.c 24 Aug 2006 12:56:38 -0000 @@ -4621,7 +4621,7 @@ lang_size_sections_1 output_section_statement->bfd_section, &newdot); - if (newdot != dot && !output_section_statement->ignored) + if (!output_section_statement->ignored) { if (output_section_statement == abs_output_section) { @@ -4630,7 +4630,7 @@ lang_size_sections_1 lang_memory_region_lookup (DEFAULT_MEMORY_REGION, FALSE)->current = newdot; } - else + else if (newdot != dot) { /* Insert a pad after this statement. We can't put the pad before when relaxing, in case the --------------050201050302030206010008--