public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH] PREL_11_0 and PC12 Thumb-2 relocations
       [not found] <44F6FADC.9090102@codesourcery.com>
@ 2006-09-01 15:42 ` Richard Earnshaw
  2006-09-01 15:52   ` Mark Shinwell
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Earnshaw @ 2006-09-01 15:42 UTC (permalink / raw)
  To: Mark Shinwell; +Cc: binutils

On Thu, 2006-08-31 at 16:06, Mark Shinwell wrote:
> Here is bfd support for the ARM Thumb-2 PREL_11_0 and PC12 relocs.
> At this stage gas support is not provided, but that is a QoI issue
> rather than an EABI-compliance issue.
> 
> Since gas support is lacking, this patch has been tested manually.
> Anyone who is interested can see the details of that testing below.
> 
> OK?
> 
Yes; however, is there some reason why this


> @@ -848,12 +848,12 @@ static reloc_howto_type elf32_arm_howto_
>  	 13,			/* bitsize */
>  	 TRUE,			/* pc_relative */
>  	 0,			/* bitpos */
> -	 complain_overflow_signed,/* complain_on_overflow */
> +	 complain_overflow_dont,/* complain_on_overflow */
>  	 bfd_elf_generic_reloc,	/* special_function */
>  	 "R_ARM_THM_PC12",	/* name */
>  	 FALSE,			/* partial_inplace */
> -	 0x040070ff,		/* src_mask */
> -	 0x040070ff,		/* dst_mask */
> +	 0x0fffffff,		/* src_mask */
> +	 0x0fffffff,		/* dst_mask */
>  	 TRUE),			/* pcrel_offset */

uses 0x_0_fffffff rather than 0x_f_fffffff ?

R.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PREL_11_0 and PC12 Thumb-2 relocations
  2006-09-01 15:42 ` [PATCH] PREL_11_0 and PC12 Thumb-2 relocations Richard Earnshaw
@ 2006-09-01 15:52   ` Mark Shinwell
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Shinwell @ 2006-09-01 15:52 UTC (permalink / raw)
  To: Richard Earnshaw; +Cc: binutils

Richard Earnshaw wrote:
> Yes; however, is there some reason why this
> 
> 
>> @@ -848,12 +848,12 @@ static reloc_howto_type elf32_arm_howto_
>>  	 13,			/* bitsize */
>>  	 TRUE,			/* pc_relative */
>>  	 0,			/* bitpos */
>> -	 complain_overflow_signed,/* complain_on_overflow */
>> +	 complain_overflow_dont,/* complain_on_overflow */
>>  	 bfd_elf_generic_reloc,	/* special_function */
>>  	 "R_ARM_THM_PC12",	/* name */
>>  	 FALSE,			/* partial_inplace */
>> -	 0x040070ff,		/* src_mask */
>> -	 0x040070ff,		/* dst_mask */
>> +	 0x0fffffff,		/* src_mask */
>> +	 0x0fffffff,		/* dst_mask */
>>  	 TRUE),			/* pcrel_offset */
> 
> uses 0x_0_fffffff rather than 0x_f_fffffff ?

No, I will change that.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-01 15:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <44F6FADC.9090102@codesourcery.com>
2006-09-01 15:42 ` [PATCH] PREL_11_0 and PC12 Thumb-2 relocations Richard Earnshaw
2006-09-01 15:52   ` Mark Shinwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).