From: Mark Shinwell <shinwell@codesourcery.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Thumb-2 BL support for bfd
Date: Fri, 01 Sep 2006 15:52:00 -0000 [thread overview]
Message-ID: <44F85746.4080100@codesourcery.com> (raw)
In-Reply-To: <1157125888.1429.21.camel@pc960.cambridge.arm.com>
Richard Earnshaw wrote:
> This is ok except for:
>
>
>> +/* Determine if we're dealing with a Thumb-2 object. */
>> +
>> +static int using_thumb2 (struct elf32_arm_link_hash_table *globals)
>> +{
>> + int arch = elf32_arm_get_eabi_attr_int (globals->obfd, Tag_CPU_arch);
>> + return arch == 8 || arch >= 10;
>> +}
>
> Don't use manifest constants here. Define some macros for the constants
> and use those instead.
ok. Will correct and apply.
Mark
prev parent reply other threads:[~2006-09-01 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 15:48 Mark Shinwell
2006-09-01 15:51 ` Richard Earnshaw
2006-09-01 15:52 ` Mark Shinwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44F85746.4080100@codesourcery.com \
--to=shinwell@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).