From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8679 invoked by alias); 26 Sep 2006 16:14:11 -0000 Received: (qmail 8615 invoked by uid 22791); 26 Sep 2006 16:14:09 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.134) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Sep 2006 16:14:00 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id 9D173B96F5; Tue, 26 Sep 2006 12:13:58 -0400 (EDT) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [67.116.42.147]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Tue, 26 Sep 2006 12:13:58 -0400 (EDT) Received: from [192.168.7.26] ([192.168.7.26]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 26 Sep 2006 09:13:57 -0700 Message-ID: <451951C5.20703@avtrex.com> Date: Tue, 26 Sep 2006 16:22:00 -0000 From: David Daney User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc3 (X11/20050929) MIME-Version: 1.0 To: Eric Botcazou Cc: Jakub Jelinek , binutils@sources.redhat.com Subject: Re: [PATCH] Fix DW_CFA_set_loc handling References: <20060926123840.GA4556@sunsite.mff.cuni.cz> <200609261456.40370.ebotcazou@adacore.com> In-Reply-To: <200609261456.40370.ebotcazou@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00317.txt.bz2 Eric Botcazou wrote: > Jakub, > > >>Recent http://gcc.gnu.org/PR22313 change (including gcc 4.1 branch) started >>(unnecessarily) using DW_CFA_set_loc at the start of all FDEs, but >>unfortunately linker .eh_frame optimizations didn't handle that well. >>If FDE encoding is pc relative or linker is changing it from absptr >>to pc relative, we need to adjust the DW_CFA_set_loc operand accordingly. >> >>Tested with make check on x86_64-linux, visual inspection of x86_64 >>readelf -wf libc.so.6 (this was seriously broken before) and visual >>inspection of a hacked up test for absptr -> pcrel conversion. > > > This sounds a bit frightening, not everyone can afford to use binutils > mainline with the 4.1.x compiler. We already found a nasty fallout > http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00285.html > so the change seems to be really destabilizing at this point. > > Would you be OK to jointly ask Roger to back it out on the 4.1 branch? > This has already been 'fixed'. See: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29132 David Daney.