From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by sourceware.org (Postfix) with ESMTPS id D04BF3888C43 for ; Thu, 15 Dec 2022 08:28:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D04BF3888C43 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZJl920R/MjXnFqbKMYnk3Ylelw3NXLb+an4cVqXlaoyW95dS4E/UQEtcGwLIFiTOlKWKT80hV9KimvUC4fJAkwJIzDmP9qyqBsDnhxS0JjOD6phk/3eN3LQMTJdh36ANhf4+YwByxYsTdGcNMClzTxmddRMgQpGKqJrfhyW5Lx5ZvcMJe54bLHwxVIHpcy0623fvtQX29hqxufuYAbCNAlx3N0N1hzrnB21hXtguFthH44Q3VvGSGI3HO9pGRFi4if3ELqQh/5UDZwX4Fbd3AeYKusAt24Az8zvrdcjYmoMOxgdRfDV+qc3gF2DUcMNheI4tTR4OsjFYcLEEDOUPNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpUmMt23pCXMA7bG873hy6H5Rbm9fDAvTDCxRr7gmoo=; b=XIw+ZpJpGZE3YOKr6JWIr2FAHgkMM61HAGOPINh+f/KPHCEJC7K6mnw0kZJtNvqsBcrDXnrCaXU2t5BEYEN4e9C9274PXAvsczn3ZCbqo+J9Z75UYlmCZaC4jBOxlv77isSLePyYi1aRKyEDeaohOIK3inEI9OR/Bt15s2kFKvo3nPuiuuTgU4ZKyuUtC7uBLZyMRFt6e+wehyj3UH/CB7LuOborhWdv7GOCRacBAJV9AfFlftgi+1ajsQXnmv575i7Gft8mYhT0/WdBqVTZ89cj1zEQGjuI+9HORAqHT0KroP1tKOlm11DVc306vSENXzh2CxZ++vwq6LITI4qS9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpUmMt23pCXMA7bG873hy6H5Rbm9fDAvTDCxRr7gmoo=; b=SaC9U2T29Ipru7F9q5jz/owwApoI9OUi3+qQ488AyLm6Ll7SdhobHiu32oKF4eqUyDusaQJEVrvsccxFZ2kMrr2m1v+PaHVAZ5OYNuNd7twrCiS2j8nczufb7p9pi6EaGfJZbvhVa5R8au3hRZ+MzUDp+AU1jrROgsW9I9dBRHO/5QUYPfAyyv4V7BMz0ETp45UWqWJR2+qK8AUypz87h0aZcd1jI/GPKcxcPyr0kgdVd/DTXVh7IKDdXU3eqfewqKclHAerHk+6oEhWZOLnINKSh/PImaJPishzN/EriwvrL9oOlL+uL5HSKJguV/wyN90yfXjkSZZAIZK6REd6gg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8248.eurprd04.prod.outlook.com (2603:10a6:20b:3fd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.12; Thu, 15 Dec 2022 08:28:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5924.011; Thu, 15 Dec 2022 08:28:53 +0000 Message-ID: <45290c42-f30a-ca1b-efb5-6283caaa172b@suse.com> Date: Thu, 15 Dec 2022 09:28:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 2/2] gas: re-work line number tracking for macros and their expansions Content-Language: en-US To: Andrew Burgess Cc: Nick Clifton , "ramana.radhakrishnan@arm.com" , Richard Earnshaw , Marcus Shawcroft , Alan Modra , Peter Bergner , Geoff Keating , Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , "H.J. Lu" , Luis Machado , Binutils References: <1d528267-9450-12c7-4c4c-fe4deb3b0617@suse.com> <8eff1de6-871d-24cc-8804-9af7da0a86cf@suse.com> <87edt20ycr.fsf@redhat.com> <87a63p2a81.fsf@redhat.com> From: Jan Beulich In-Reply-To: <87a63p2a81.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8248:EE_ X-MS-Office365-Filtering-Correlation-Id: 1de84574-833d-4afa-edd4-08dade76668c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GXoC93XZ/yAG/7f4p5PuDC0PAsstc9YDUwaHqUCinHCg1RnmCpyPp8DQ7Wc4TprU2E1WKYT8Jo5eBMWFtVNzpFZcu5lllj7akubOyh/A2SjcSN8NRVfYpHWA6GIhvchBAr2Uq9q28slq3t1jdbo/SnWQvIW3h9ZZope/nbN+70UpxQzdwyzQhZAigc0PVehWcZYTYMR0R9n16sTrhL1zYDY6mRqm+pitJBgyUYPkubxO6sUNqMJ5PGAuNag5Sh2qtqXX1vTY5scIdftxTySaHD9R2G7YFKh9RA9/7CgfiNlthiylQm1bWM1uDrjE5V3yYaACWG9ocCQtBzGnoZ3op7xG0aidzKHjIMeWt+ZRR6gN2SfQVJQJz2sQrT/YUvpg+RIWy0xS2w0jilTytAGu9hu7zpN2GCt+pEQBk0xpybv5Vb7K8LTN/XTm5zbCBwSKzDfwNR5l6tLTWUFRFwOBbg08EEJhjHU4AknY5aq4gcK1WNxeJol1y3gL6P9hGkwneeUHCCkNYzUHve8ByQmpx2Pw2boHgjSaNozMSErTDS/+Ghb7len3u1BuTe1uGfFfHs2wzGcUneHr6pbZIdjh9qpbTCq69+l2YIk+LaWvIz2Om36Vf+NcdSLW3qQLooPrTNeD252oJaWq8AsUbYTV8HmCCquGRz+6oX+C1y7NRWxlt1Til6S/ZbSxUnFq8LO/G3vJwanu2DxYzkBAWkTIH1sUv37AUpTtUmpYWXHSdMs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(346002)(39860400002)(376002)(451199015)(2616005)(83380400001)(31686004)(86362001)(31696002)(54906003)(316002)(478600001)(6916009)(36756003)(38100700002)(6506007)(53546011)(6512007)(26005)(186003)(7416002)(2906002)(6486002)(66946007)(8936002)(41300700001)(5660300002)(4326008)(8676002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGxscWhReXdtQ0tKVjhES2czVW1OMklhamFhcnRPZ2pHbTZWVXRtL3V1TkJa?= =?utf-8?B?WXgySS9OM09nc3ZMNDloYmY4K09lb0pNdkVMTUQvNW4ydHBhdmxrZHIyM0pz?= =?utf-8?B?N3RsNU5OY1NiTFhCWWJ0K1JrQWxhUUNJYXAxRnc5Y2MyNHpEamN2cGczN0Nq?= =?utf-8?B?dUtMc2lpLzdMeldObUZYbmJsUDV6ZlJMcmt6YzFhVlFoZlNPMitsdFFMSTFU?= =?utf-8?B?M3hkc0xWeTFKNC9VRDVWeEg3Zm92RGltdC9WVEF1ZUNjSUFCZzYwOU4zSU1N?= =?utf-8?B?SzNBdkRTK2Z1WTFha3NrMkV5SlNVbzZpQktBV1ROc0ZuODlaTloybzduL2pn?= =?utf-8?B?SmkrYVIyRVRhejh1SFZFbFVDNklwMTR2NDBEdXF6V25LRnpEL1hvbVB1UDlt?= =?utf-8?B?SFJieUdGYmh0VEFWK08zc2FyMlpCb3ZJeHVVSzRpcVdJZEUrY1ZMSnR3ZUND?= =?utf-8?B?THdGOFcwQUVFNjVuajlMNzJEU3VWSDB5WHFwcUdXZ1ErSFFpS3MyRjNEcG8v?= =?utf-8?B?VHR3ZUgxeGZReEdVb3F6U2o2VmRweDd0YzlnYXNDeGQwOHVkbXJDNU1CcE8v?= =?utf-8?B?VVVQZEsvNVFmNDI0Q1E5b3lObk1kVnJxTkpseUk2c0lCNFV6eEZuOGJjZkFI?= =?utf-8?B?OFVsRFFSZ2lzYjhIYWMwdXVZMmtTalFvWi9VOVNHODN2TTI5NysrVTZpQWZn?= =?utf-8?B?cGlRT2xiQXlZd0VJTEdTODd5VkdXYldjOC9sc3J3Z1BMWExPTVhyNDZ0amxr?= =?utf-8?B?eHpzMDltSFFvSlFTRXdLbFdQYXFpWHI0MnE1dkUzNmZjSDNvZnh2NnlVd0Q3?= =?utf-8?B?L2dpQmp2Q0J1RUdBelNrZjhab05sdFlwS3hBWG5QNEg4QWlUS0ZOWk96dDdQ?= =?utf-8?B?enlHOU01ZjNpNWswS0Rwdjc1YTUzZ0VtcHdMMUtQSDJScU9BN2k1UjJFbTVS?= =?utf-8?B?L2R3Y1JUbEJMdXQ2SkFWdWhSMk1QcE5OaGpwRUJ0eXBDZEI5clIzV2UzTGJr?= =?utf-8?B?UTg3WmdTT3B6WU5HWWRQa3UxTkdXbGJkTVFWNXJmZWszWXhKcEJBVE40K3pM?= =?utf-8?B?bFpZaDREUEtqUzNUb3JRUjRnak5nVVh0U3oyOWQ5dFBWMS94SlVBdzY0MjNG?= =?utf-8?B?UmR3bERwbzlJdFRCRGZnRENBTUdvK1IvcFpJbVBjV0ZKTjMzY0ljU0JrSWY2?= =?utf-8?B?Q2ZjS0hMVDVISWgzUWtJWmNSbVJ4M2dhamtTRlZXQXN3TDZseWNIWm9wQno1?= =?utf-8?B?Kytzd2h2WlQ0a3k0MFZwUzZRNGJLbExaVnNBcm80bG8yaDlPckdqMTl5MXFk?= =?utf-8?B?VGdiRkdrRFoxMm9Jc3dHQmprQ0JaQys2elp6ZDNZdFU3OHJ6aURtWjdUdUdo?= =?utf-8?B?YzJTRlZtek4vMklHTVJWTDJhUnJSNlRobVRLZFBybis2L0FBZlovRjVtYXFj?= =?utf-8?B?OFlHN1BNUDh3dGg3WWZnWHVGdVAyeStHUExGNyt4Z0UxTEVVcFpCSUFpRm40?= =?utf-8?B?eWVBQWZobXdFRS9Tb0NGQVNrUmtvZVl2M2JQSlExSGc5WmxFQnk2aEVsbkM1?= =?utf-8?B?cWFLTXlvWktXYkorN2Zzd0dLeDR1T3QvYUdia2NmUndXdDJGV0pENHVTejEx?= =?utf-8?B?UWhaNHUyT0MyZVhOMmc0bitpOW9JN1dnYkpFUUJMaE81cmZhSXNGdEpMdGR5?= =?utf-8?B?c2VXUjcrS25rQnhXaTR1NlNrc3QwdThwekU4cms1a1VwTTBFcEFjbDloT012?= =?utf-8?B?L00rcGQzQ3ppZHpHK1kyc29uOWJlcVVxQVNnZmY1QnhGUUVXeFZWTzEyWGFk?= =?utf-8?B?MTJ3c3NnYStDaTJNVFhKRWdSRHVTVTNXalNwb2xXSEVEcktlMjYxU3dURmRt?= =?utf-8?B?aDh4Wng2SDFKYVFIZ2xqQWExaUZVdTBoS2V5WEpqU0k1VVNUV0V3MEJpd29E?= =?utf-8?B?cHM3d1pZT2gydmFWbDM2S1dLQlhlWnRFR3lRTDZiMkp2OTByVndnY3RaZ1pC?= =?utf-8?B?djdSenRmMmVHdlFwc3lOdnEyNHgwSk5oWHAxNFI5Z2pObVNUK1Y4bE5IdGht?= =?utf-8?B?bDVmZVgyTVhFRkp5YUl2eFEzRHpUSmZ4UEk4UGxhdDBLZHA5and3UFdzN2dC?= =?utf-8?Q?CjfU0esp49ZVsUiuSS4S38FkW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1de84574-833d-4afa-edd4-08dade76668c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 08:28:53.5771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MATJmlDmtgg86Zt2B9tTIL5NLDIuPHI5sUx/1LygvdDNhts1LumCfWgEbGnbsJmBPTT0aKRl01L6befh/f6vrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8248 X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.12.2022 17:58, Andrew Burgess wrote: > I think I understand the issue a little more now. I have a simple > reproducer which can be run outside the gdb testsuite (see below). > > It appears that the DWARF for macros now tries to associate the > instructions within the macro the source location within the macro > definition, rather than the macro use site. I'm not entirely convinced > this is a good idea (as a macro could be used multiple times), or even > if this was an intended change of this series. No, there was no intention to alter generated Dwarf. In fact I had put in place a test ahead of this change here (commit 6fdb723799e2) to have at least some proof of that. Quite likely that wasn't elaborate enough a test then. > If this is the direction gas is moving in then I guess we will need to > update the GDB test, but there is, I think, a bug in the generated > DWARF, in that it appears that the wrong file name is being used. While I would like to improve representation of .macro expansions, we first need to determine what the best way is for representing them. See also the post-commit-message remark in the submission of the patch here. Jan