From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cmx-mtlrgo002.bell.net (mta-mtl-008.bell.net [209.71.208.31]) by sourceware.org (Postfix) with ESMTP id 0D1E3385841D for ; Mon, 27 Jan 2025 22:50:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D1E3385841D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=bell.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bell.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0D1E3385841D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.71.208.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738018246; cv=none; b=awD1P/gs3fJQNYnvnvDgYJrDB32SYipT0EoDxB833SXdhJMF6x/yh/yLtmj63Xehf7g2JmulPkwQbJhTtkTdFDGLXJkPYj4FXqsVe9PvjwjjdEw4d+yLG23L4eg7bsYBaP0iG8X1FZlkyQwItACh0S+TeGCH69goKao42W5rrwI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738018246; c=relaxed/simple; bh=j3dHzeEO4g6jJNBGsapmjQHYKm0ZGqpQEJU9+x+9aDk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=n0DX7EQgrAaCPZYqMEwenZ0iXNQcmPpt5SqSOS/5M+TOETfoYUg6CqxBWzVE7z2G9LmxTUrsTBCntam74mrJALiPwLM6iIDA5emwYKGzh5aoq7f6ebecUFP2e0z217YNitckTb1521LGQqMNVj43K/ow84zwbePC9gRVBvNKH8Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D1E3385841D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=bell.net header.i=@bell.net header.a=rsa-sha256 header.s=selector1 header.b=RIDMXlZn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bell.net; s=selector1; t=1738018246; bh=P0MwGZYLRmQJBAUiSGDVX2ZNp/EJLd544jjPvY9Ta0k=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type; b=RIDMXlZnhjGtDbVsnWNRRbNelQjaz7fMJhh14+VnVaGhH0AxZwncWaOzeYcU2R92BKjrfN+BzmTmlaHb8/mMrO4MPFCaGrdprPa6GVU9otW95Yic38rXOUHKcfZ5i6HonJj/uvT7hMih95nkJw4+jefY8m3euToa7ghI39KHumT3cjs/z0iUfwkJctdRMizyDM+P43s5/zTUOPeZ8+vZUmXhNo2TTJPHXcD1cVjYGCiRr8XwvZ9nJgtp+d0/ZlSuB6WC1x50iclhDE+Jgoxogjvkk8CA2vGXlVwHVAh0Cos+TJMzJmou/oYBR90VNU2TBJ1fFg62BChBM1PY+zKc0w== X-RG-SOPHOS: Clean X-RG-VADE-SC: 0 X-RG-VADE: Clean X-Originating-IP: [142.126.150.186] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 678EFB0F00A872E8 X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeefuddrudejgedgudeggeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuuefgnffnpdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhhnhcuffgrvhhiugcutehnghhlihhnuceouggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtqeenucggtffrrghtthgvrhhnpefhieetueejheeuvdfhheeugfehheetudekteevheekudehledtieeuvdeuhedtgfenucfkphepudegvddruddviedrudehtddrudekieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedrvddrgeelngdpihhnvghtpedugedvrdduvdeirdduhedtrddukeeipdhmrghilhhfrhhomhepuggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtpdhnsggprhgtphhtthhopeefpdhrtghpthhtohepsghinhhuthhilhhssehsohhurhgtvgifrghrvgdrohhrghdprhgtphhtthhopegurghvvgdrrghnghhlihhnsegsvghllhdrnhgvthdprhgtphhtthhopehjsggvuhhlihgthhesshhushgvrdgtohhmpdhrvghvkffrpegsrhgrshdqsggrshgvqdhothifrghonhdtledtieifqdhgrhgtqddufedqudegvddquddviedqudehtddqudekiedrughslhdrsggvlhhlrdgtrgdprghuthhhpghushgvrhep uggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtpdhgvghokffrpeevtedpoffvtefjohhstheptghmgidqmhhtlhhrghhotddtvd X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.2.49] (142.126.150.186) by cmx-mtlrgo002.bell.net (authenticated as dave.anglin@bell.net) id 678EFB0F00A872E8; Mon, 27 Jan 2025 17:50:43 -0500 Message-ID: <4586c9d1-70de-4418-b473-f74c54b76fe9@bell.net> Date: Mon, 27 Jan 2025 17:50:43 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 21/65] HP-PA: use is_whitespace() To: Jan Beulich , Binutils References: <2316ac5c-7870-4b46-9c80-eaecaef93a31@suse.com> Content-Language: en-US From: John David Anglin Autocrypt: addr=dave.anglin@bell.net; keydata= xsFNBFJfN1MBEACxBrfJ+5RdCO+UQOUARQLSsnVewkvmNlJRgykqJkkI5BjO2hhScE+MHoTK MoAeKwoLfBwltwoohH5RKxDSAIWajTY5BtkJBT23y0hm37fN2JXHGS4PwwgHTSz63cu5N1MK n8DZ3xbXFmqKtyaWRwdA40dy11UfI4xzX/qWR3llW5lp6ERdsDDGHm5u/xwXdjrAilPDk/av d9WmA4s7TvM/DY3/GCJyNp0aJPcLShU2+1JgBxC6NO6oImVwW07Ico89ETcyaQtlXuGeXYTK UoKdEHQsRf669vwcV5XbmQ6qhur7QYTlOOIdDT+8zmBSlqBLLe09soATDciJnyyXDO1Nf/hZ gcI3lFX86i8Fm7lQvp2oM5tLsODZUTWVT1qAFkHCOJknVwqRZ8MfOvaTE7L9hzQ9QKgIKrSE FRgf+gs1t1vQMRHkIxVWb730C0TGiMGNn2oRUV5O5QEdb/tnH0Te1l+hX540adKZ8/CWzzW9 vcx+qD9IWLRyZMsM9JnmAIvYv06+YIcdpbRYOngWPd2BqvktzIs9mC4n9oU6WmUhBIaGOGnt t/49bTRtJznqm/lgqxtE2NliJN79dbZJuJWe5HkjVa7mP4xtsG59Rh2hat9ByUfROOfoZ0dS sVHF/N6NLWcf44trK9HZdT/wUeftEWtMV9WqxIwsA4cgSHFR2QARAQABzTdKb2huIERhdmlk IEFuZ2xpbiAoRGViaWFuIFBvcnRzKSA8ZGF2ZS5hbmdsaW5AYmVsbC5uZXQ+wsF3BBMBCAAh BQJSXzdTAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEF2/za5fGU3xs/4P/15sNizR ukZLNYoeGAd6keRtNcEcVGEpRgzc/WYlXCRTEjRknMvmCu9z13z8qB9Y9N4JrPdp+NQj5HEs ODPI+1w1Mjj9R2VZ1v7suFwhjxMTUQUjCsgna1H+zW/UFsrL5ERX2G3aUKlVdYmSWapeGeFL xSMPzawPEDsbWzBzYLSHUOZexMAxoJYWnpN9JceEcGvK1SU2AaGkhomFoPfEf7Ql1u3Pgzie ClWEr2QHl+Ku1xW0qx5OLKHxntaQiu30wKHBcsF0Zx2uVGYoINJl/syazfZyKTdbmJnEYyNa Bdbn7B8jIkVCShLOWJ8AQGX/XiOoL/oE9pSZ60+MBO9qd18TGYByj0X2PvH+OyQGul5zYM7Q 7lT97PEzh8xnib49zJVVrKDdJds/rxFwkcHdeppRkxJH0+4T0GnU2IZsEkvpRQNJAEDmEE8n uRfssr7RudZQQwaBugUGaoouVyFxzCxdpSYL6zWHA51VojvJYEBQDuFNlUCqet9LtNlLKx2z CAKmUPTaDwPcS3uOywOW7WZrAGva1kz9lzxZ+GAwgh38HAFqQT8DQvW8jnBBG4m4q7lbaum3 znERv7kcfKWoWS7fzxLNTIitrbpYA3E7Zl9D2pDV3v55ZQcO/M35K9teRo6glrtFDU/HXM+r ABbh8u9UnADbPmJr9nb7J0tZUSS/zsFNBFJfN1MBEADBzhVn4XyGkPAaFbLPcMUfwcIgvvPF UsLi9Q53H/F00cf7BkMY40gLEXvsvdUjAFyfas6z89gzVoTUx3HXkJTIDTiPuUc1TOdUpGYP hlftgU+UqW5O8MMvKM8gx5qn64DU0UFcS+7/CQrKOJmzktr/72g98nVznf5VGysa44cgYeoA v1HuEoqGO9taA3Io1KcGrzr9cAZtlpwj/tcUJlc6H5mqPHn2EdWYmJeGvNnFtxd0qJDmxp5e YVe4HFNjUwsb3oJekIUopDksAP41RRV0FM/2XaPatkNlTZR2krIVq2YNr0dMU8MbMPxGHnI9 b0GUI+T/EZYeFsbx3eRqjv1rnNg2A6kPRQpn8dN3BKhTR5CA7E/cs+4kTmV76aHpW8m/NmTc t7KNrkMKfi+luhU2P/sKh7Xqfbcs7txOWB2V4/sbco00PPxWr20JCA5hYidaKGyQxuXdPUlQ Qja4WJFnAtBhh3Oajgwhbvd6S79tz1acjNXZ89b8IN7yDm9sQ+4LhWoUQhB5EEUUUVQTrzYS yTGN1YTTO5IUU5UJHb5WGMnSPLLArASctOE01/FYnnOGeU+GFIeQp91p+Jhd07hUr6KWYeJY OgEmu+K8SyjfggCWdo8aGy0H3Yr0YzaHeK2HrfC3eZcUuo+yDW3tnrNwM1rd1i3F3+zJK18q GnBxEQARAQABwsFfBBgBCAAJBQJSXzdTAhsMAAoJEF2/za5fGU3xNDQP/ikzh1NK/UBrWtpN yXLbype4k5/zyQd9FIBxAOYEOogfKdkp+Yc66qNf36gO6vsokxsDXU9me1n8tFoB/DCdzKbQ /RjKQRMNNR4fT2Q9XV6GZYSL/P2A1wzDW06tEI+u+1dV40ciQULQ3ZH4idBW3LdN+nloQf/C qoYkOf4WoLyhSzW7xdNPZqiJCAdcz9djN79FOz8US+waBCJrL6q5dFSvvsYj6PoPJkCgXhiJ hI91/ERMuK9oA1oaBxCvuObBPiFlBDNXZCwmUk6qzLDjfZ3wdiZCxc5g7d2e2taBZw/MsKFc k+m6bN5+Hi1lkmZEP0L4MD6zcPuOjHmYYzX4XfQ61lQ8c4ztXp5cKkrvaMuN/bD57HJ6Y73Q Y+wVxs9x7srl4iRnbulCeiSOAqHmwBAoWaolthqe7EYL4d2+CjPCcfIuK7ezsEm8c3o3EqC4 /UpL1nTi0rknRTGc0VmPef+IqQUj33GGj5JRzVJZPnYyCx8sCb35Lhs6X8ggpsafUkuKrH76 XV2KRzaE359RgbM3pNEViXp3NclPYmeu+XI8Ls/y6tSq5e/o/egktdyJj+xvAj9ZS18b10Jp e67qK8wZC/+N7LGON05VcLrdZ+FXuEEojJWbabF6rJGN5X/UlH5OowVFEMhD9s31tciAvBwy T70V9SSrl2hiw38vRzsl In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Can't test without is_whitespace() being defined but it looks okay. Dave On 2025-01-27 11:20 a.m., Jan Beulich wrote: > Convert open-coded checks. At the same time use is_end_of_stmt() instead > of an open-coded check in adjacent code. > --- > v2: New. > > --- a/gas/config/tc-hppa.c > +++ b/gas/config/tc-hppa.c > @@ -2013,7 +2013,7 @@ pa_parse_number (char **s, int is_float) > bool have_prefix; > > /* Skip whitespace before the number. */ > - while (*p == ' ' || *p == '\t') > + while (is_whitespace (*p)) > p = p + 1; > > pa_number = -1; > @@ -2229,12 +2229,12 @@ pa_parse_fp_cmp_cond (char **s) > *s += strlen (fp_cond_map[i].string); > /* If not a complete match, back up the input string and > report an error. */ > - if (**s != ' ' && **s != '\t') > + if (!is_whitespace (**s)) > { > *s -= strlen (fp_cond_map[i].string); > break; > } > - while (**s == ' ' || **s == '\t') > + while (is_whitespace (**s)) > *s = *s + 1; > return cond; > } > @@ -2243,7 +2243,7 @@ pa_parse_fp_cmp_cond (char **s) > as_bad (_("Invalid FP Compare Condition: %s"), *s); > > /* Advance over the bogus completer. */ > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > > return 0; > @@ -2416,7 +2416,7 @@ pa_chk_field_selector (char **str) > char *s = *str; > > /* Read past any whitespace. */ > - while (*s == ' ' || *s == '\t') > + while (is_whitespace (*s)) > s++; > *str = s; > > @@ -2547,7 +2547,7 @@ pa_get_number (struct pa_it *insn, char > contain no whitespace. */ > > s = *strp; > - while (*s != ',' && *s != ' ' && *s != '\t') > + while (*s != ',' && !is_whitespace (*s)) > s++; > > c = *s; > @@ -2627,7 +2627,7 @@ pa_parse_nonneg_cmpsub_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -2697,7 +2697,7 @@ pa_parse_neg_cmpsub_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -2772,7 +2772,7 @@ pa_parse_cmpb_64_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -2865,7 +2865,7 @@ pa_parse_cmpib_64_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -2928,7 +2928,7 @@ pa_parse_nonneg_add_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -2997,7 +2997,7 @@ pa_parse_neg_add_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -3070,7 +3070,7 @@ pa_parse_addb_64_cmpltr (char **s) > if (**s == ',') > { > *s += 1; > - while (**s != ',' && **s != ' ' && **s != '\t') > + while (**s != ',' && !is_whitespace (**s)) > *s += 1; > c = **s; > **s = 0x00; > @@ -3178,7 +3178,7 @@ pa_ip (char *str) > > /* Convert everything up to the first whitespace character into lower > case. */ > - for (s = str; *s != ' ' && *s != '\t' && *s != '\n' && *s != '\0'; s++) > + for (s = str; !is_whitespace (*s) && !is_end_of_stmt (*s); s++) > *s = TOLOWER (*s); > > /* Skip to something interesting. */ > @@ -3198,11 +3198,13 @@ pa_ip (char *str) > > /*FALLTHROUGH */ > > - case ' ': > + zap_char: > *s++ = '\0'; > break; > > default: > + if (is_whitespace (*s)) > + goto zap_char; > as_bad (_("Unknown opcode: `%s'"), str); > return; > } > @@ -3239,7 +3241,7 @@ pa_ip (char *str) > for (args = insn->args;; ++args) > { > /* Absorb white space in instruction. */ > - while (*s == ' ' || *s == '\t') > + while (is_whitespace (*s)) > s++; > > switch (*args) > @@ -3264,11 +3266,15 @@ pa_ip (char *str) > case '(': > case ')': > case ',': > - case ' ': > if (*s++ == *args) > continue; > break; > > + case ' ': > + if (is_whitespace (*s++)) > + continue; > + break; > + > /* Handle a 5 bit register or control register field at 10. */ > case 'b': > case '^': > @@ -3282,7 +3288,7 @@ pa_ip (char *str) > is there. */ > case '!': > /* Skip whitespace before register. */ > - while (*s == ' ' || *s == '\t') > + while (is_whitespace (*s)) > s = s + 1; > > if (!strncasecmp (s, "%sar", 4)) > @@ -3956,7 +3962,7 @@ pa_ip (char *str) > break; > > name = s; > - while (*s != ',' && *s != ' ' && *s != '\t') > + while (*s != ',' && !is_whitespace (*s)) > s += 1; > c = *s; > *s = 0x00; > @@ -4131,7 +4137,7 @@ pa_ip (char *str) > break; > > name = s; > - while (*s != ',' && *s != ' ' && *s != '\t') > + while (*s != ',' && !is_whitespace (*s)) > s += 1; > c = *s; > *s = 0x00; > @@ -4279,7 +4285,7 @@ pa_ip (char *str) > break; > > name = s; > - while (*s != ',' && *s != ' ' && *s != '\t') > + while (*s != ',' && !is_whitespace (*s)) > s += 1; > c = *s; > *s = 0x00; > @@ -4353,7 +4359,7 @@ pa_ip (char *str) > break; > > name = s; > - while (*s != ',' && *s != ' ' && *s != '\t') > + while (*s != ',' && !is_whitespace (*s)) > s += 1; > c = *s; > *s = 0x00; > @@ -4497,7 +4503,7 @@ pa_ip (char *str) > s += 3; > } > /* ",*" is a valid condition. */ > - else if (*args != 'U' || (*s != ' ' && *s != '\t')) > + else if (*args != 'U' || !is_whitespace (*s)) > as_bad (_("Invalid Unit Instruction Condition.")); > } > /* 32-bit is default for no condition. */ > -- John David Anglin dave.anglin@bell.net