* The current assembler is broken
@ 2007-03-14 19:54 H. J. Lu
2007-03-15 5:24 ` Alexandre Oliva
0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2007-03-14 19:54 UTC (permalink / raw)
To: binutils; +Cc: aoliva
See
http://sources.redhat.com/bugzilla/show_bug.cgi?id=4184
H.J.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: The current assembler is broken
2007-03-14 19:54 The current assembler is broken H. J. Lu
@ 2007-03-15 5:24 ` Alexandre Oliva
2007-03-15 11:44 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Oliva @ 2007-03-15 5:24 UTC (permalink / raw)
To: H. J. Lu; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
On Mar 14, 2007, "H. J. Lu" <hjl@lucon.org> wrote:
> See
> http://sources.redhat.com/bugzilla/show_bug.cgi?id=4184
Thanks for the report and testcase. This patch fixes it. I could
reintroduce a state to output the blank, but... No point in doing it
if we don't need it, right?
Ok to install?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gas-line-0-fix.patch --]
[-- Type: text/x-patch, Size: 558 bytes --]
for gas/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* app.c (do_scrub_chars): PUT after setting states.
Index: trunk/gas/app.c
===================================================================
--- trunk.orig/gas/app.c 2007-03-09 20:25:22.000000000 -0300
+++ trunk/gas/app.c 2007-03-15 02:14:23.000000000 -0300
@@ -510,11 +510,10 @@ do_scrub_chars (int (*get) (char *, int)
ch = GET ();
if (ch == '"')
{
- PUT (' ');
- PUT (ch);
quotechar = ch;
state = 5;
old_state = 3;
+ PUT (ch);
}
else
{
[-- Attachment #3: Type: text/plain, Size: 249 bytes --]
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member http://www.fsfla.org/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: The current assembler is broken
2007-03-15 5:24 ` Alexandre Oliva
@ 2007-03-15 11:44 ` Nick Clifton
0 siblings, 0 replies; 3+ messages in thread
From: Nick Clifton @ 2007-03-15 11:44 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: H. J. Lu, binutils
Hi Alex,
>> See
>> http://sources.redhat.com/bugzilla/show_bug.cgi?id=4184
>
> Thanks for the report and testcase. This patch fixes it. I could
> reintroduce a state to output the blank, but... No point in doing it
> if we don't need it, right?
>
> Ok to install?
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-15 11:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-14 19:54 The current assembler is broken H. J. Lu
2007-03-15 5:24 ` Alexandre Oliva
2007-03-15 11:44 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).