* add objdump to TOOLS_PROGS
@ 2007-02-26 17:40 Nathan Sidwell
2007-03-15 9:39 ` Nathan Sidwell
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Sidwell @ 2007-02-26 17:40 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 574 bytes --]
uclinux systems use objdump when generating a FLT binary. Thus objdump should
be considered a TOOLS_PROGS on those systems and installed in the tools' bin
directory.
Currently, uclinux systems can pick up some tools from the tool bin directory
(correctly) and pick up objdump somewhat randomly (by hoping PATH is correct).
This patch adds objdump to TOOLS_PROGS when configuring a uclinux target, ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
[-- Attachment #2: tools.patch --]
[-- Type: text/x-patch, Size: 3720 bytes --]
2007-02-26 Nathan Sidwell <nathan@codesourcery.com>
* Makefile.am (TOOL_PROGS): Set from @TOOL_PROGS@.
(install-exec-local): Protect against TOOL_PROGS being empty.
* configure.in (TOOL_PROGS): New, set it appropriately.
* Makefile.in: Rebuilt.
* configure: Rebuilt.
Index: binutils/configure
===================================================================
Index: binutils/configure.in
===================================================================
RCS file: /cvs/src/src/binutils/configure.in,v
retrieving revision 1.73
diff -c -3 -p -r1.73 configure.in
*** binutils/configure.in 17 Feb 2007 13:33:54 -0000 1.73
--- binutils/configure.in 26 Feb 2007 16:18:36 -0000
*************** BUILD_WINDRES=
*** 225,230 ****
--- 225,231 ----
BUILD_DLLWRAP=
BUILD_MISC=
OBJDUMP_DEFS=
+ TOOL_PROGS="nm-new strip-new ar ranlib dlltool objdump"
for targ in $target $canon_targets
do
*************** do
*** 233,238 ****
--- 234,240 ----
BUILD_NLMCONV='$(NLMCONV_PROG)$(EXEEXT)'
BUILD_SRCONV='$(SRCONV_PROG)'
NLMCONV_DEFS="-DNLMCONV_I386 -DNLMCONV_ALPHA -DNLMCONV_POWERPC -DNLMCONV_SPARC"
+ TOOL_PROGS="$TOOL_PROGS objcopy"
else
case $targ in
changequote(,)dnl
*************** changequote([,])dnl
*** 372,377 ****
--- 374,384 ----
OBJDUMP_DEFS="-DSKIP_ZEROES=256 -DSKIP_ZEROES_AT_END=0"
;;
esac
+ case $targ in
+ *-uclinux)
+ TOOL_PROGS="$TOOL_PROGS objcopy"
+ ;;
+ esac
fi
done
*************** if test "${with_windres+set}" = set; the
*** 381,386 ****
--- 388,396 ----
BUILD_WINDRES='$(WINDRES_PROG)$(EXEEXT)'
fi
+ # Remove duplicates from TOOL_PROGS
+ TOOL_PROGS="`echo $TOOL_PROGS | tr ' ' '\012' | sort -u | tr '\012' ' '`"
+
AC_SUBST(NLMCONV_DEFS)
AC_SUBST(BUILD_NLMCONV)
AC_SUBST(BUILD_SRCONV)
*************** AC_SUBST(BUILD_WINDRES)
*** 390,395 ****
--- 400,406 ----
AC_SUBST(BUILD_DLLWRAP)
AC_SUBST(BUILD_MISC)
AC_SUBST(OBJDUMP_DEFS)
+ AC_SUBST(TOOL_PROGS)
AC_DEFINE_UNQUOTED(TARGET, "${target}", [Configured target name.])
Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.81
diff -c -3 -p -r1.81 Makefile.am
*** binutils/Makefile.am 17 Feb 2007 13:33:53 -0000 1.81
--- binutils/Makefile.am 26 Feb 2007 16:18:38 -0000
*************** noinst_PROGRAMS = $(NM_PROG) $(STRIP_PRO
*** 61,67 ****
EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
--- 61,67 ----
EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = @TOOL_PROGS@
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
*************** install-exec-local: install-binPROGRAMS
*** 413,420 ****
else :; fi; \
done
$(mkinstalldirs) $(DESTDIR)$(tooldir)/bin
! for i in $(TOOL_PROGS); do \
! if [ -f $$i$(EXEEXT) ]; then \
j=`echo $$i | sed -e 's/-new//'`; \
k=`echo $$j | sed '$(transform)'`; \
if [ "$(bindir)/$$k" != "$(tooldir)/bin/$$j" ]; then \
--- 413,420 ----
else :; fi; \
done
$(mkinstalldirs) $(DESTDIR)$(tooldir)/bin
! for i in . $(TOOL_PROGS); do \
! if [ $$i != . ] && [ -f $$i$(EXEEXT) ]; then \
j=`echo $$i | sed -e 's/-new//'`; \
k=`echo $$j | sed '$(transform)'`; \
if [ "$(bindir)/$$k" != "$(tooldir)/bin/$$j" ]; then \
Index: binutils/Makefile.in
===================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: add objdump to TOOLS_PROGS
2007-02-26 17:40 add objdump to TOOLS_PROGS Nathan Sidwell
@ 2007-03-15 9:39 ` Nathan Sidwell
2007-03-15 11:22 ` Daniel Jacobowitz
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Sidwell @ 2007-03-15 9:39 UTC (permalink / raw)
To: binutils
Nathan Sidwell wrote:
http://sourceware.org/ml/binutils/2007-02/msg00368.html
ping?
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: add objdump to TOOLS_PROGS
2007-03-15 9:39 ` Nathan Sidwell
@ 2007-03-15 11:22 ` Daniel Jacobowitz
2007-03-16 14:23 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Jacobowitz @ 2007-03-15 11:22 UTC (permalink / raw)
To: Nathan Sidwell; +Cc: binutils
On Thu, Mar 15, 2007 at 09:39:49AM +0000, Nathan Sidwell wrote:
> Nathan Sidwell wrote:
> http://sourceware.org/ml/binutils/2007-02/msg00368.html
Does anyone object to doing this unconditionally?
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: add objdump to TOOLS_PROGS
2007-03-15 11:22 ` Daniel Jacobowitz
@ 2007-03-16 14:23 ` Nick Clifton
2007-04-13 11:34 ` Nathan Sidwell
0 siblings, 1 reply; 6+ messages in thread
From: Nick Clifton @ 2007-03-16 14:23 UTC (permalink / raw)
To: Nathan Sidwell, binutils
Hi Daniel, Hi Nathan,
>> Nathan Sidwell wrote:
>> http://sourceware.org/ml/binutils/2007-02/msg00368.html
>
> Does anyone object to doing this unconditionally?
Not me, I think that it would be a good idea.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: add objdump to TOOLS_PROGS
2007-03-16 14:23 ` Nick Clifton
@ 2007-04-13 11:34 ` Nathan Sidwell
2007-04-13 11:36 ` Nick Clifton
0 siblings, 1 reply; 6+ messages in thread
From: Nathan Sidwell @ 2007-04-13 11:34 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Nick Clifton wrote:
> Hi Daniel, Hi Nathan,
>
>>> Nathan Sidwell wrote:
>>> http://sourceware.org/ml/binutils/2007-02/msg00368.html
>>
>> Does anyone object to doing this unconditionally?
>
> Not me, I think that it would be a good idea.
ok, here's a patch to do just that, ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk
[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 1923 bytes --]
2007-04-13 Nathan Sidwell <nathan@codesourcery.com>
* Makefile.am (TOOL_PROGS): Add objcopy.
* Makefile.in: Rebuilt.
Index: Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.86
diff -c -3 -p -r1.86 Makefile.am
*** Makefile.am 15 Mar 2007 14:17:16 -0000 1.86
--- Makefile.am 13 Apr 2007 11:10:27 -0000
*************** noinst_PROGRAMS = $(RENAMED_PROGS) @BUIL
*** 60,66 ****
EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
--- 60,66 ----
EXTRA_PROGRAMS = $(NLMCONV_PROG) srconv sysdump coffdump $(DLLTOOL_PROG) $(WINDRES_PROG) $(DLLWRAP_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump objcopy
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.in,v
retrieving revision 1.97
diff -c -3 -p -r1.97 Makefile.in
*** Makefile.in 15 Mar 2007 14:17:16 -0000 1.97
--- Makefile.in 13 Apr 2007 11:10:27 -0000
*************** SRCONV_PROG = srconv$(EXEEXT) sysdump$(E
*** 364,370 ****
RENAMED_PROGS = $(NM_PROG) $(STRIP_PROG) $(DEMANGLER_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
INCDIR = $(BASEDIR)/include
--- 364,370 ----
RENAMED_PROGS = $(NM_PROG) $(STRIP_PROG) $(DEMANGLER_PROG)
# Stuff that goes in tooldir/ if appropriate.
! TOOL_PROGS = nm-new strip-new ar ranlib dlltool objdump objcopy
BASEDIR = $(srcdir)/..
BFDDIR = $(BASEDIR)/bfd
INCDIR = $(BASEDIR)/include
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: add objdump to TOOLS_PROGS
2007-04-13 11:34 ` Nathan Sidwell
@ 2007-04-13 11:36 ` Nick Clifton
0 siblings, 0 replies; 6+ messages in thread
From: Nick Clifton @ 2007-04-13 11:36 UTC (permalink / raw)
To: Nathan Sidwell; +Cc: binutils
Hi Nathan,
> ok, here's a patch to do just that, ok?
> 2007-04-13 Nathan Sidwell <nathan@codesourcery.com>
>
> * Makefile.am (TOOL_PROGS): Add objcopy.
> * Makefile.in: Rebuilt.
>
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-04-13 11:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-26 17:40 add objdump to TOOLS_PROGS Nathan Sidwell
2007-03-15 9:39 ` Nathan Sidwell
2007-03-15 11:22 ` Daniel Jacobowitz
2007-03-16 14:23 ` Nick Clifton
2007-04-13 11:34 ` Nathan Sidwell
2007-04-13 11:36 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).