* [rfa] Do not expect frame base for inlined functions
@ 2007-03-06 15:02 Daniel Jacobowitz
2007-03-21 11:17 ` Nick Clifton
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2007-03-06 15:02 UTC (permalink / raw)
To: binutils
I'm pretty sure this is correct. Inlined subroutine DIEs should
generally not have a DW_AT_frame_base (the inlined instance does not
have a frame). But it's fine for them to have variables which use
DW_OP_fbreg, and they'll use the enclosing DW_TAG_subprogram's frame
base. OK to commit?
(Tested x86_64-linux, no regressions)
--
Daniel Jacobowitz
CodeSourcery
2007-03-06 Daniel Jacobowitz <dan@codesourcery.com>
* dwarf.c (process_debug_info): Do not require DW_AT_frame_base for
DW_TAG_inlined_subroutine.
Index: dwarf.c
===================================================================
RCS file: /cvs/src/src/binutils/dwarf.c,v
retrieving revision 1.11
diff -u -p -r1.11 dwarf.c
--- dwarf.c 6 Feb 2007 16:47:47 -0000 1.11
+++ dwarf.c 6 Mar 2007 14:02:56 -0000
@@ -1733,7 +1733,6 @@ process_debug_info (struct dwarf_section
need_base_address = 1;
break;
case DW_TAG_entry_point:
- case DW_TAG_inlined_subroutine:
case DW_TAG_subprogram:
need_base_address = 0;
/* Assuming that there is no DW_AT_frame_base. */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [rfa] Do not expect frame base for inlined functions
2007-03-06 15:02 [rfa] Do not expect frame base for inlined functions Daniel Jacobowitz
@ 2007-03-21 11:17 ` Nick Clifton
0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2007-03-21 11:17 UTC (permalink / raw)
To: binutils
Hi Daniel,
> 2007-03-06 Daniel Jacobowitz <dan@codesourcery.com>
>
> * dwarf.c (process_debug_info): Do not require DW_AT_frame_base for
> DW_TAG_inlined_subroutine.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-21 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-06 15:02 [rfa] Do not expect frame base for inlined functions Daniel Jacobowitz
2007-03-21 11:17 ` Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).