From: Nick Clifton <nickc@redhat.com>
To: binutils@sourceware.org
Subject: Re: [PATCH] don't strip symbols involved in relocations
Date: Tue, 24 Apr 2007 13:35:00 -0000 [thread overview]
Message-ID: <462DE314.2040805@redhat.com> (raw)
In-Reply-To: <20070423161109.GF26694@sparrowhawk.codesourcery.com>
Hi Nathan,
> binutils/
> 2007-04-23 Nathan Froyd <froydnj@codesourcery.com>
> Phil Edwards <phil@codesourcery.com>
>
> * objcopy.c (filter_symbols): Explicitly stripping a symbol
> used in relocations is an error.
>
> binutils/testsuite/
> 2007-04-23 Nathan Froyd <froydnj@codesourcery.com>
> Phil Edwards <phil@codesourcery.com>
>
> * binutils-all/objcopy.exp: Add test for stripping a symbol
> used in a relocation.
> * binutils-all/needed-reloc.s: New file.
Approved and applied.
Note: I also changed the type of the 'keep' variable to a bfd_boolean in
keeping with the rest of the code in that function. Also I enabled the
test for x86_64 targets (per H.J.'s request) and renamed the test file
to needed-by-reloc.s.
Cheers
Nick
prev parent reply other threads:[~2007-04-24 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 15:31 Nathan Froyd
2007-04-23 16:11 ` H. J. Lu
2007-04-23 18:57 ` Nathan Froyd
2007-04-23 23:07 ` H. J. Lu
2007-04-24 13:35 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462DE314.2040805@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).