public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* fix pecoff partial links
@ 2007-07-12 12:25 Nathan Sidwell
  2007-07-12 12:40 ` Kai Tietz
  2007-07-12 12:58 ` Alan Modra
  0 siblings, 2 replies; 4+ messages in thread
From: Nathan Sidwell @ 2007-07-12 12:25 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

This patch fixes a problem with partial links on pe-coff.  We shouldn't be 
merging .gcc_except_table and .eh_frame so early.

tested in i686-mingw32, ok?

nathan
-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


[-- Attachment #2: 1765.patch --]
[-- Type: text/x-patch, Size: 864 bytes --]

2007-07-12  Nathan Sidwell  <nathan@codesourcery.com>

	* scripttempl/pe.sc: Don't include .gcc_except_table and
	.eh_frame on partial links.

Index: ld/scripttempl/pe.sc
===================================================================
--- ld/scripttempl/pe.sc	(revision 176277)
+++ ld/scripttempl/pe.sc	(working copy)
@@ -73,7 +73,7 @@ SECTIONS
     /* ??? Why is .gcc_exc here?  */
     ${RELOCATING+ *(.gcc_exc)}
     ${RELOCATING+PROVIDE (etext = .);}
-    *(.gcc_except_table)
+    ${RELOCATING+ *(.gcc_except_table)}
   }
 
   /* The Cygwin32 library uses a section to avoid copying certain data
@@ -97,7 +97,7 @@ SECTIONS
   {
     *(.rdata)
     ${R_RDATA}
-    *(.eh_frame)
+    ${RELOCATING+ *(.eh_frame)}
     ${RELOCATING+___RUNTIME_PSEUDO_RELOC_LIST__ = .;}
     ${RELOCATING+__RUNTIME_PSEUDO_RELOC_LIST__ = .;}
     *(.rdata_runtime_pseudo_reloc)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fix pecoff partial links
  2007-07-12 12:25 fix pecoff partial links Nathan Sidwell
@ 2007-07-12 12:40 ` Kai Tietz
  2007-07-12 16:52   ` Nathan Sidwell
  2007-07-12 12:58 ` Alan Modra
  1 sibling, 1 reply; 4+ messages in thread
From: Kai Tietz @ 2007-07-12 12:40 UTC (permalink / raw)
  To: Nathan Sidwell; +Cc: binutils

> This patch fixes a problem with partial links on pe-coff.  We shouldn't 
be 
> merging .gcc_except_table and .eh_frame so early.
> 
> tested in i686-mingw32, ok?
> 

Could you do the same thing for pep-coff too ?

Cheers,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fix pecoff partial links
  2007-07-12 12:25 fix pecoff partial links Nathan Sidwell
  2007-07-12 12:40 ` Kai Tietz
@ 2007-07-12 12:58 ` Alan Modra
  1 sibling, 0 replies; 4+ messages in thread
From: Alan Modra @ 2007-07-12 12:58 UTC (permalink / raw)
  To: Nathan Sidwell; +Cc: binutils

On Thu, Jul 12, 2007 at 01:15:30PM +0100, Nathan Sidwell wrote:
> 	* scripttempl/pe.sc: Don't include .gcc_except_table and
> 	.eh_frame on partial links.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: fix pecoff partial links
  2007-07-12 12:40 ` Kai Tietz
@ 2007-07-12 16:52   ` Nathan Sidwell
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Sidwell @ 2007-07-12 16:52 UTC (permalink / raw)
  To: Kai Tietz; +Cc: binutils, Alan Modra

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Kai Tietz wrote:
>> This patch fixes a problem with partial links on pe-coff.  We shouldn't 
> be 
>> merging .gcc_except_table and .eh_frame so early.
>>
>> tested in i686-mingw32, ok?
>>
> 
> Could you do the same thing for pep-coff too ?

done.

nathan

-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk


[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 3151 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/ld/ChangeLog,v
retrieving revision 1.1732
diff -c -3 -p -r1.1732 ChangeLog
*** ChangeLog	12 Jul 2007 01:40:25 -0000	1.1732
--- ChangeLog	12 Jul 2007 12:56:19 -0000
***************
*** 1,3 ****
--- 1,9 ----
+ 2007-07-12  Nathan Sidwell  <nathan@codesourcery.com>
+ 
+ 	* scripttempl/pe.sc: Don't include .gcc_except_table and
+ 	.eh_frame on partial links.
+ 	* scripttempl/pep.sc: Likewise.
+ 
  2007-07-12  Alan Modra  <amodra@bigpond.net.au>
  
  	PR 4782
Index: scripttempl/pe.sc
===================================================================
RCS file: /cvs/src/src/ld/scripttempl/pe.sc,v
retrieving revision 1.15
diff -c -3 -p -r1.15 pe.sc
*** scripttempl/pe.sc	5 Oct 2005 08:07:51 -0000	1.15
--- scripttempl/pe.sc	12 Jul 2007 12:56:19 -0000
*************** SECTIONS
*** 71,77 ****
      /* ??? Why is .gcc_exc here?  */
      ${RELOCATING+ *(.gcc_exc)}
      ${RELOCATING+PROVIDE (etext = .);}
!     *(.gcc_except_table)
    }
  
    /* The Cygwin32 library uses a section to avoid copying certain data
--- 71,77 ----
      /* ??? Why is .gcc_exc here?  */
      ${RELOCATING+ *(.gcc_exc)}
      ${RELOCATING+PROVIDE (etext = .);}
!     ${RELOCATING+ *(.gcc_except_table)}
    }
  
    /* The Cygwin32 library uses a section to avoid copying certain data
*************** SECTIONS
*** 95,101 ****
    {
      *(.rdata)
      ${R_RDATA}
!     *(.eh_frame)
      ${RELOCATING+___RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      ${RELOCATING+__RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      *(.rdata_runtime_pseudo_reloc)
--- 95,101 ----
    {
      *(.rdata)
      ${R_RDATA}
!     ${RELOCATING+ *(.eh_frame)}
      ${RELOCATING+___RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      ${RELOCATING+__RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      *(.rdata_runtime_pseudo_reloc)
Index: scripttempl/pep.sc
===================================================================
RCS file: /cvs/src/src/ld/scripttempl/pep.sc,v
retrieving revision 1.1
diff -c -3 -p -r1.1 pep.sc
*** scripttempl/pep.sc	20 Sep 2006 11:35:09 -0000	1.1
--- scripttempl/pep.sc	12 Jul 2007 12:56:19 -0000
*************** SECTIONS
*** 71,77 ****
      /* ??? Why is .gcc_exc here?  */
      ${RELOCATING+ *(.gcc_exc)}
      ${RELOCATING+PROVIDE (etext = .);}
!     *(.gcc_except_table)
    }
  
    /* The Cygwin32 library uses a section to avoid copying certain data
--- 71,77 ----
      /* ??? Why is .gcc_exc here?  */
      ${RELOCATING+ *(.gcc_exc)}
      ${RELOCATING+PROVIDE (etext = .);}
!     ${RELOCATING+ *(.gcc_except_table)}
    }
  
    /* The Cygwin32 library uses a section to avoid copying certain data
*************** SECTIONS
*** 95,101 ****
    {
      *(.rdata)
      ${R_RDATA}
!     *(.eh_frame)
      ${RELOCATING+___RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      ${RELOCATING+__RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      *(.rdata_runtime_pseudo_reloc)
--- 95,101 ----
    {
      *(.rdata)
      ${R_RDATA}
!     ${RELOCATING+ *(.eh_frame)}
      ${RELOCATING+___RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      ${RELOCATING+__RUNTIME_PSEUDO_RELOC_LIST__ = .;}
      *(.rdata_runtime_pseudo_reloc)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-07-12 12:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-12 12:25 fix pecoff partial links Nathan Sidwell
2007-07-12 12:40 ` Kai Tietz
2007-07-12 16:52   ` Nathan Sidwell
2007-07-12 12:58 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).