From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1321 invoked by alias); 24 Jul 2007 12:47:57 -0000 Received: (qmail 1313 invoked by uid 22791); 24 Jul 2007 12:47:57 -0000 X-Spam-Check-By: sourceware.org Received: from mail1.nsc.com (HELO mailgate1.nsc.com) (12.151.32.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jul 2007 12:47:45 +0000 X-WSS-ID: 0JLOOXX-05-XDA-01 Received: from SCNTRDCSS8.nsc.com (unknown [192.168.7.27]) by mailgate1.nsc.com (Tumbleweed MailGate) with ESMTP id 1F239380123CF for ; Tue, 24 Jul 2007 05:49:09 -0700 (PDT) Received: from [139.187.179.130] by SCNTRDCSS6.nsc.com with ESMTP ( -Hi-); Tue, 24 Jul 2007 05:40:06 -0700 X-Server-Uuid: CDE0D3F6-4EC6-4DC9-81EF-DBBF12AF9A3C Received: from [139.187.83.131] by scmh1.nsc.com with ESMTP; Tue, 24 Jul 2007 05:47:21 -0700 Received: from [139.187.78.209] by malkauns.malkauns.nsc.com ( 8.8.8p2+Sun/SMI-SVR4) id SAA07788; Tue, 24 Jul 2007 18:15:05 +0530 ( IST) Message-ID: <46A5F474.2090606@nsc.com> Date: Tue, 24 Jul 2007 14:10:00 -0000 From: "M R Swami Reddy" User-Agent: Thunderbird 1.5.0.12 (Windows/20070509) MIME-Version: 1.0 To: "Nick Clifton" cc: binutils@sourceware.org Subject: Re: PATCH: Add CR16 support to readelf and replace NUM_ELEM with ARRAY_SIZE References: In-Reply-To: X-TMWD-Spam-Summary: TS=20070724124113; SEV=2.2.2; DFV=B2007072409; IFV=2.0.4,4.0-9; AIF=B2007072409; RPD=5.02.0125; ENG=IBF; RPDID=7374723D303030312E30413031303230362E34364135463444422E303034362C73733D312C6667733D30; CAT=NONE; CON=NONE X-MMS-Spam-Filter-ID: B2007072409_5.02.0125_4.0-9 X-WSS-ID: 6ABB2CAC0Q8556594-01-01 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00376.txt.bz2 Hi Nick, Thanks a lot for adding CR16 support in readelf and the CR16 support patch is fine. Thanks, Swami Nick Clifton wrote: > Hi Guys, > > I am being a bit naughty here by combining three patches to readelf > into one submission... > > I am applying the attached patch to fix a couple of minor things > with readelf. The first was that it did not recognize the newly > added CR16 target. The second was that there is no need for the > NUM_ELEM() macro since a standard alternative version - ARRAY_SIZE > - is defined in libiberty.h. Finally the third fix is to correct a > few formatting errors in recently added code. > > Cheers > Nick > > binutils/ChangeLog > 2007-07-24 Nick Clifton > > * readelf.c (NUM_ELEM): Remove redundant macro; replace references > to it with references to ARRAY_SIZE. > Add support for CR16. > Fix formatting. >