From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-51695-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 15747 invoked by alias); 26 Jul 2007 09:19:55 -0000
Received: (qmail 15739 invoked by uid 22791); 26 Jul 2007 09:19:54 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 26 Jul 2007 09:19:52 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6Q9JglA004195; 	Thu, 26 Jul 2007 05:19:42 -0400
Received: from pobox.fab.redhat.com (pobox.fab.redhat.com [10.33.63.12]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6Q9JfsF031161; 	Thu, 26 Jul 2007 05:19:42 -0400
Received: from [10.33.6.16] (vpn-6-16.fab.redhat.com [10.33.6.16]) 	by pobox.fab.redhat.com (8.13.1/8.13.1) with ESMTP id l6Q9Jexr028657; 	Thu, 26 Jul 2007 05:19:41 -0400
Message-ID: <46A8672D.1040301@redhat.com>
Date: Thu, 26 Jul 2007 09:37:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Thunderbird 1.5.0.10 (X11/20070301)
MIME-Version: 1.0
To: msnyder@sonic.net
CC: Andreas Schwab <schwab@suse.de>, Ian Lance Taylor <iant@google.com>,         binutils@sourceware.org
Subject: Re: [PATCH] aout relocs
References: <14938.12.7.175.2.1185390419.squirrel@webmail.sonic.net>     <m33azcdyxd.fsf@localhost.localdomain>     <10401.12.7.175.2.1185397487.squirrel@webmail.sonic.net>     <je3azcfa4v.fsf@sykes.suse.de> <24557.12.7.175.2.1185399290.squirrel@webmail.sonic.net>
In-Reply-To: <24557.12.7.175.2.1185399290.squirrel@webmail.sonic.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2007-07/txt/msg00445.txt.bz2

Hi Michael,

>> That's the only place where something needs to be done (the pointer must
>> still be valid even if the size is zero).
> 
> Alright -- that's enough to justify the patch, isn't it?

Certainly - please apply it.  Although you could simplify the second part of 
the patch by just checking to see if count is zero and returning, in the same 
way as you check reloc_size.  That way you do not need to check the return 
values of both allocs.

Cheers
   Nick