From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25173 invoked by alias); 30 Jul 2007 18:14:01 -0000 Received: (qmail 25158 invoked by uid 22791); 30 Jul 2007 18:14:01 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.134) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Jul 2007 18:13:54 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id 1CF9E305498; Mon, 30 Jul 2007 18:13:52 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [67.116.42.147]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Mon, 30 Jul 2007 18:13:51 +0000 (UTC) Received: from [192.168.7.26] ([192.168.7.26]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 30 Jul 2007 11:13:51 -0700 Message-ID: <46AE2A5E.5080408@avtrex.com> Date: Mon, 30 Jul 2007 18:36:00 -0000 From: David Daney User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: Thiemo Seufer Cc: binutils@sourceware.org, richard@codesourcery.com Subject: Re: Fix run_list_test for MIPS gas References: <87ejiz5orr.fsf@firetop.home> <20070730180352.GK26960@networkno.de> In-Reply-To: <20070730180352.GK26960@networkno.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00534.txt.bz2 Thiemo Seufer wrote: > Richard Sandiford wrote: > [snip] >> There are two problems: mips.exp uses run_list_test with no options >> argument, and cr16.exp overrides the gas-defs.exp definition before >> mips.exp runs. >> >> I think the best fix for the first problem is to make the options >> optional. For the second, it's trivially safe to delete the cr16.exp >> definition because cr16.exp contains no list tests. >> >> Tested on mipsisa64-elf. OK to install? >> >> Richard >> >> >> gas/testsuite/ >> * lib/gas-defs.exp (run_list_test): Make the options optional. >> * gas/cr16/cr16.exp (run_list_test): Delete. > > Could somebody please review this patch? It looks good to me, but I > can't approve it. > http://sourceware.org/ml/binutils/2007-07/msg00353.html > > Thiemo