PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Kai Tietz]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Hi,

this patch will fix the problem on secreloc32 tests for x86_64-mingw32. 
For this target the ctor/dtor elements are 8 bytes long. This caused the 
FAIL.

See bug-report: http://sourceware.org/bugzilla/show_bug.cgi?id=4877

I tested this patch for x86_64-pc-mingw32 test-suite without any 
regressions.

ChangeLog for ld/testsuite:

2007-08-02  Kai Tietz   <kai.tietz@onevision.com>

        * ld-pe/pe.exp: special diff file for x86_64-mingw target.
        * ld-pe/secrel_64.d: New.

Cheers,
 i.A. Kai Tietz



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger

[-- Attachment #2: pe_exp.txt --]
[-- Type: text/plain, Size: 609 bytes --]

? secrel_64.d
Index: pe.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-pe/pe.exp,v
retrieving revision 1.7
diff -u -r1.7 pe.exp
--- pe.exp	6 Jul 2007 14:09:44 -0000	1.7
+++ pe.exp	2 Aug 2007 09:06:00 -0000
@@ -30,8 +30,15 @@
 }
 
 set pe_tests {
+  {".secrel32" "" "" {secrel1.s secrel2.s}
+  {{objdump -s secrel_64.d}} "secrel.x"}
+}
+
+if {    ![istarget x86_64-*-mingw*] } {
+  set pe_tests {
     {".secrel32" "" "" {secrel1.s secrel2.s}
      {{objdump -s secrel.d}} "secrel.x"}
+  }
 }
 
 run_ld_link_tests $pe_tests

[-- Attachment #3: secrel_64.d --]
[-- Type: application/octet-stream, Size: 1486 bytes --]


tmpdir/secrel\.x: +file format pei-.*

Contents of section \.text:
 .*1000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c  >>>><<<<>>>>><<<
 .*1010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c  >>>>>><<>>>>>>><
 .*1020 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c  >>>><<<<>>>>><<<
 .*1030 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c  >>>>>><<>>>>>>><
 .*1040 ffffffff ffffffff 00000000 00000000  ................
 .*1050 ffffffff ffffffff 00000000 00000000  ................
Contents of section \.data:
 .*2000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c  >>>><<<<>>>>><<<
 .*2010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c  >>>>>><<>>>>>>><
 .*2020 3e3e3e3e 04000000 110d0000 00111600  >>>>............
 .*2030 0000111f 00000011 3c3c3c3c 3c3c3c3c  ........<<<<<<<<
 .*2040 3e3e3e3e 04000000 110d0000 00111600  >>>>............
 .*2050 0000111f 00000011 3c3c3c3c 3c3c3c3c  ........<<<<<<<<
 .*2060 3e3e3e3e 04000000 110d0000 00111600  >>>>............
 .*2070 0000111f 00000011 3c3c3c3c 3c3c3c3c  ........<<<<<<<<
 .*2080 3e3e3e3e 24000000 112d0000 00113600  >>>>\$....-....6.
 .*2090 0000113f 00000011 3c3c3c3c 3c3c3c3c  ...\?....<<<<<<<<
Contents of section \.rdata:
 .*3000 3e3e3e3e 3c3c3c3c 3e3e3e3e 3e3c3c3c  >>>><<<<>>>>><<<
 .*3010 3e3e3e3e 3e3e3c3c 3e3e3e3e 3e3e3e3c  >>>>>><<>>>>>>><
 .*3020 3e3e3e3e 00000000 00000000 00000000  >>>>............
Contents of section \.idata:
 .*4000 00000000 00000000 00000000 00000000  ................
 .*4010 00000000                             ....            

Re: PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Christopher Faylor]

On Mon, Aug 06, 2007 at 09:34:55AM +0200, Kai Tietz wrote:
>Hi,
>
>this patch will fix the problem on secreloc32 tests for x86_64-mingw32. 
>For this target the ctor/dtor elements are 8 bytes long. This caused the 
>FAIL.
>
>See bug-report: http://sourceware.org/bugzilla/show_bug.cgi?id=4877
>
>I tested this patch for x86_64-pc-mingw32 test-suite without any 
>regressions.
>
>ChangeLog for ld/testsuite:
>
>2007-08-02  Kai Tietz   <kai.tietz@onevision.com>
>
>        * ld-pe/pe.exp: special diff file for x86_64-mingw target.
>        * ld-pe/secrel_64.d: New.

Is there some reason why this wouldn't work under a potential
x86_64-cygwin target?  I haven't been paying enough attention to this
issue but it seems like whatever machinery works for mingw should also
work for cygwin eventually.

cgf

Re: PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Kai Tietz]

Hi Christopher,

> On Mon, Aug 06, 2007 at 09:34:55AM +0200, Kai Tietz wrote:
> >Hi,
> >
> >this patch will fix the problem on secreloc32 tests for x86_64-mingw32. 

> >For this target the ctor/dtor elements are 8 bytes long. This caused 
the 
> >FAIL.
> >
> >See bug-report: http://sourceware.org/bugzilla/show_bug.cgi?id=4877
> >
> >I tested this patch for x86_64-pc-mingw32 test-suite without any 
> >regressions.
> >
> >ChangeLog for ld/testsuite:
> >
> >2007-08-02  Kai Tietz   <kai.tietz@onevision.com>
> >
> >        * ld-pe/pe.exp: special diff file for x86_64-mingw target.
> >        * ld-pe/secrel_64.d: New.
> 
> Is there some reason why this wouldn't work under a potential
> x86_64-cygwin target?  I haven't been paying enough attention to this
> issue but it seems like whatever machinery works for mingw should also
> work for cygwin eventually.

If there would be a crt1 for cygwin, I am certain that it would work for 
x86_64-cygwin too.

Cheers,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger

Re: PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Christopher Faylor]

On Mon, Aug 06, 2007 at 01:57:37PM +0200, Kai Tietz wrote:
>Hi Christopher,
>
>> On Mon, Aug 06, 2007 at 09:34:55AM +0200, Kai Tietz wrote:
>> >Hi,
>> >
>> >this patch will fix the problem on secreloc32 tests for x86_64-mingw32. 
>
>> >For this target the ctor/dtor elements are 8 bytes long. This caused 
>the 
>> >FAIL.
>> >
>> >See bug-report: http://sourceware.org/bugzilla/show_bug.cgi?id=4877
>> >
>> >I tested this patch for x86_64-pc-mingw32 test-suite without any 
>> >regressions.
>> >
>> >ChangeLog for ld/testsuite:
>> >
>> >2007-08-02  Kai Tietz   <kai.tietz@onevision.com>
>> >
>> >        * ld-pe/pe.exp: special diff file for x86_64-mingw target.
>> >        * ld-pe/secrel_64.d: New.
>> 
>> Is there some reason why this wouldn't work under a potential
>> x86_64-cygwin target?  I haven't been paying enough attention to this
>> issue but it seems like whatever machinery works for mingw should also
>> work for cygwin eventually.
>
>If there would be a crt1 for cygwin, I am certain that it would work
>for x86_64-cygwin too.

Cygwin does have similar crt* mechanisms to every other platform out
there.  I'm not asking you to implement anything here but could you
maybe just keep cygwin in mind when making patches like this and not
just default to "mingw"?

cgf

Re: PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Kai Tietz]

Hi Christopher,

> >If there would be a crt1 for cygwin, I am certain that it would work
> >for x86_64-cygwin too.
> 
> Cygwin does have similar crt* mechanisms to every other platform out
> there.  I'm not asking you to implement anything here but could you
> maybe just keep cygwin in mind when making patches like this and not
> just default to "mingw"?
Ok, no problem about that. May somebody could add (at least to binutils 
and config.* as a first step) the x86_64-pc-cygwin target ?

Cheers,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

------------------------------------------------------------------------------------------
  OneVision Software Entwicklungs GmbH & Co. KG
  Dr.-Leo-Ritter-Straße 9 - 93049 Regensburg
  Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
  Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
  Handelsregister: HRA 6744, Amtsgericht Regensburg
  Komplementärin: OneVision Software Entwicklungs Verwaltungs GmbH
  Dr.-Leo-Ritter-Straße 9 – 93049 Regensburg
  Handelsregister: HRB 8932, Amtsgericht Regensburg - Geschäftsführer: 
Ulrike Döhler, Manuela Kluger

Re: PING: patch: PR-4877 testsuite fix for secreloc32 x86_64

[Nick Clifton]

Hi Kai,

> 2007-08-02  Kai Tietz   <kai.tietz@onevision.com>
> 
>         * ld-pe/pe.exp: special diff file for x86_64-mingw target.
>         * ld-pe/secrel_64.d: New.

Approved and applied.

Note - I changed around the logic inside pe.exp to test the target first and 
then set pe_tests as this seemed cleaner to me.

Cheers
   Nick