From: Luis Machado <luis.machado@arm.com>
To: Jan Beulich <jbeulich@suse.com>, Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: Move bfd_init to bfd.c
Date: Tue, 10 Jan 2023 09:57:36 +0000 [thread overview]
Message-ID: <471adc96-2f8b-de42-ce5f-f7f44cc7458e@arm.com> (raw)
In-Reply-To: <6fd40220-6dba-90f3-f31d-9c6859d22a3d@suse.com>
On 1/10/23 09:47, Jan Beulich via Binutils wrote:
> On 10.01.2023 00:18, Alan Modra via Binutils wrote:
>> init.c contains just one function that doesn't do much. Move it to
>> bfd.c and give it something to do, initialising static state. So far
>> the only initialisation is for bfd.c static variables.
>>
>> The idea behind reinitialising state is to see whether some set of
>> flaky oss-fuzz crashes go away. oss-fuzz stresses binutils in ways
>> that can't occur in reality, feeding multiple testcases into the
>> internals of binutils. So one testcase may affect the result of the
>> next testcase.
>>
>> * init.c: Delete file. Move bfd_init to..
>> * bfd.c (bfd_init): ..here. Init static variables.
>> * Makefile.am (BFD32_LIBS): Remove init.lo.
>> (BFD32_LIBS_CFILES, BFD_H_FILES): Remove init.c.
>> * doc/local.mk: Remove mention of init.texi and init.c.
>
> If I'm not mistaken this should also have touched bfd.texi to remove
> the inclusion of init.texi?
>
> Jan
>
I seem to be getting:
../../../repos/binutils-gdb/bfd/doc/bfd.texi:246: @include: could not find init.texi
next prev parent reply other threads:[~2023-01-10 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 23:18 Alan Modra
2023-01-10 9:47 ` Jan Beulich
2023-01-10 9:57 ` Luis Machado [this message]
2023-01-10 10:14 ` Alan Modra
2023-01-10 13:13 ` Luis Machado
2023-01-10 10:11 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471adc96-2f8b-de42-ce5f-f7f44cc7458e@arm.com \
--to=luis.machado@arm.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).