public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Bob Wilson <bwilson@tensilica.com>
To: binutils@sources.redhat.com
Subject: Re: [PATCH] fix DWARF for ia64
Date: Tue, 13 Nov 2007 21:47:00 -0000	[thread overview]
Message-ID: <473A1B4E.8030504@tensilica.com> (raw)
In-Reply-To: <473A01B5.30907@tensilica.com>

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Here is a follow-on patch.  I noticed that dwarf2_emit_label() can also use the 
new dwarf2_consume_line_info function.

Is this OK?

I forgot to say how I tested this.  I built binutils for xtensa-elf, 
ia64-unknown-linux-gnu and i686-pc-linux-gnu targets, all hosted on 
i686-pc-linux-gnu, and ran the testsuite.  I've rerun those tests now with this 
follow-on patch.  Everything passed as expected with one exception: the 
ld-ia64/line.exp test fails but I see the same failure without any of my 
changes.  ld fails to show the source line number in an error message.  That 
does seem suspicious.  Is this a known problem?

gas/
	* dwarf2dbg.c (dwarf2_emit_label): Use dwarf2_consume_line_info.


[-- Attachment #2: gas-debug-ia64-2.patch --]
[-- Type: text/x-diff, Size: 540 bytes --]

--- dwarf2dbg.c.2	2007-11-13 12:41:33.000000000 -0800
+++ dwarf2dbg.c	2007-11-13 12:42:42.000000000 -0800
@@ -419,17 +419,11 @@
   if (debug_type == DEBUG_DWARF2)
     dwarf2_where (&loc);
   else
-    {
-      loc = current;
-      dwarf2_loc_directive_seen = FALSE;
-    }
+    loc = current;
 
   loc.flags |= DWARF2_FLAG_BASIC_BLOCK;
 
-  current.flags &= ~(DWARF2_FLAG_BASIC_BLOCK
-		     | DWARF2_FLAG_PROLOGUE_END
-		     | DWARF2_FLAG_EPILOGUE_BEGIN);
-
+  dwarf2_consume_line_info ();
   dwarf2_gen_line_info_1 (label, &loc);
 }
 

  reply	other threads:[~2007-11-13 21:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13 19:57 Bob Wilson
2007-11-13 21:47 ` Bob Wilson [this message]
2007-11-16 11:34   ` Nick Clifton
2007-11-16 19:54     ` Bob Wilson
2007-11-17  8:50       ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473A1B4E.8030504@tensilica.com \
    --to=bwilson@tensilica.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).