From: Nick Clifton <nickc@redhat.com>
To: Bob Wilson <bwilson@tensilica.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] fix DWARF for ia64
Date: Fri, 16 Nov 2007 11:34:00 -0000 [thread overview]
Message-ID: <473D803C.1050700@redhat.com> (raw)
In-Reply-To: <473A1B4E.8030504@tensilica.com>
Hi Bob,
> Here is a follow-on patch. I noticed that dwarf2_emit_label() can also
> use the new dwarf2_consume_line_info function.
>
> Is this OK?
Your first patch and this follow on one both look OK, apart from the last part
of this second patch:
loc.flags |= DWARF2_FLAG_BASIC_BLOCK;
- current.flags &= ~(DWARF2_FLAG_BASIC_BLOCK
- | DWARF2_FLAG_PROLOGUE_END
- | DWARF2_FLAG_EPILOGUE_BEGIN);
-
+ dwarf2_consume_line_info ();
dwarf2_gen_line_info_1 (label, &loc);
Why are you deleting the update of current.flags ?
> Everything passed as expected with one
> exception: the ld-ia64/line.exp test fails but I see the same failure
> without any of my changes.
Hmm, I do not see that failure. In fact I get (trimmed slightly for email):
Running .../ld-ia64/line.exp ...
.../gas/as-new -o tmpdir/undefined.o -x .../ld-ia64/undefined.s
./ld-new -e start -o tmpdir/undefined tmpdir/undefined.o
ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
tmpdir/undefined.o: In function `function':
undefined.c:9: undefined reference to `this_function_is_not_defined'
ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
tmpdir/undefined.o: In function `function':
undefined.c:9: undefined reference to `this_function_is_not_defined'
ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0
tmpdir/undefined.o: In function `function':
undefined.c:9: undefined reference to `this_function_is_not_defined'
PASS: undefined line
testcase .../ld-ia64/line.exp completed in 0 seconds
> ld fails to show the source line number in
> an error message. That does seem suspicious. Is this a known problem?
Suspicious yes. Known problem no. The above test was run for an
ia64-unknown-linux-gnu toolchain, and I would hope that you would see the same
results. Can you investigate a little more please ?
Cheers
Nick
next prev parent reply other threads:[~2007-11-16 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 19:57 Bob Wilson
2007-11-13 21:47 ` Bob Wilson
2007-11-16 11:34 ` Nick Clifton [this message]
2007-11-16 19:54 ` Bob Wilson
2007-11-17 8:50 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473D803C.1050700@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=bwilson@tensilica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).