From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2371 invoked by alias); 16 Nov 2007 11:34:28 -0000 Received: (qmail 2360 invoked by uid 22791); 16 Nov 2007 11:34:27 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 16 Nov 2007 11:34:25 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAGBYNVr019805; Fri, 16 Nov 2007 06:34:24 -0500 Received: from pobox.fab.redhat.com (pobox.fab.redhat.com [10.33.63.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAGBYN4P008838; Fri, 16 Nov 2007 06:34:23 -0500 Received: from [10.32.4.124] (vpn-4-124.str.redhat.com [10.32.4.124]) by pobox.fab.redhat.com (8.13.1/8.13.1) with ESMTP id lAGBYLfw006662; Fri, 16 Nov 2007 06:34:22 -0500 Message-ID: <473D803C.1050700@redhat.com> Date: Fri, 16 Nov 2007 11:34:00 -0000 From: Nick Clifton User-Agent: Thunderbird 1.5.0.12 (X11/20071018) MIME-Version: 1.0 To: Bob Wilson CC: binutils@sources.redhat.com Subject: Re: [PATCH] fix DWARF for ia64 References: <473A01B5.30907@tensilica.com> <473A1B4E.8030504@tensilica.com> In-Reply-To: <473A1B4E.8030504@tensilica.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00189.txt.bz2 Hi Bob, > Here is a follow-on patch. I noticed that dwarf2_emit_label() can also > use the new dwarf2_consume_line_info function. > > Is this OK? Your first patch and this follow on one both look OK, apart from the last part of this second patch: loc.flags |= DWARF2_FLAG_BASIC_BLOCK; - current.flags &= ~(DWARF2_FLAG_BASIC_BLOCK - | DWARF2_FLAG_PROLOGUE_END - | DWARF2_FLAG_EPILOGUE_BEGIN); - + dwarf2_consume_line_info (); dwarf2_gen_line_info_1 (label, &loc); Why are you deleting the update of current.flags ? > Everything passed as expected with one > exception: the ld-ia64/line.exp test fails but I see the same failure > without any of my changes. Hmm, I do not see that failure. In fact I get (trimmed slightly for email): Running .../ld-ia64/line.exp ... .../gas/as-new -o tmpdir/undefined.o -x .../ld-ia64/undefined.s ./ld-new -e start -o tmpdir/undefined tmpdir/undefined.o ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0 tmpdir/undefined.o: In function `function': undefined.c:9: undefined reference to `this_function_is_not_defined' ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0 tmpdir/undefined.o: In function `function': undefined.c:9: undefined reference to `this_function_is_not_defined' ld-new: warning: cannot find entry symbol start; defaulting to 40000000000000b0 tmpdir/undefined.o: In function `function': undefined.c:9: undefined reference to `this_function_is_not_defined' PASS: undefined line testcase .../ld-ia64/line.exp completed in 0 seconds > ld fails to show the source line number in > an error message. That does seem suspicious. Is this a known problem? Suspicious yes. Known problem no. The above test was run for an ia64-unknown-linux-gnu toolchain, and I would hope that you would see the same results. Can you investigate a little more please ? Cheers Nick