From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from t03.bc.larksuite.com (t03.bc.larksuite.com [209.127.231.34]) by sourceware.org (Postfix) with UTF8SMTPS id D245B3858C5E for ; Tue, 22 Aug 2023 08:55:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D245B3858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1692694530; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=8IJhRpS9denbRaJCqZaCONmc3rWkFPGXvJBdk7jBO8c=; b=HLWJI/Mef6+uXFnRNeutNqlRTvhhpcdDTXt0G6IpLPpAiGkwxe0onZy2ibKlj3CoikQdQV 6ZVshukvo52SnkT3XyGjzBYPx9E+dhEF2MkApnoncREDqNuip5LyIQLlEvNJW2W+5DXNFe Zw3VbpzS3w20In+JyDJmkgZfz33cBJVQhzv6bCr4B5+EtOWgzISaqG3HjCfWhrIwrRErUI TK9Ow29GkQSYZOr4LioGcoerp4QF4cIi+0nh5wxVb8HoYij/8JCMJT678OSX72KbnnJd9e QBfzospP6bBdoqWC2xEutvh7UD6yomNGqbjQeBHK061vedZMH/Nw9hF4h5PKwg== Content-Transfer-Encoding: 8bit References: <114fe517229b8cc0e504238f0d8553dd3528f5e9.568cb3db.66b5.4ad3.826b.3b027f1ea47e@feishu.cn> <8725cca2-4c4d-f32d-fc8c-3c6c194c481c@oss.cipunited.com> Content-Language: en-US X-Lms-Return-Path: Cc: "libc-alpha" , , "binutils" From: "Ying Huang" X-Original-From: Ying Huang Date: Tue, 22 Aug 2023 16:55:27 +0800 Mime-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils Message-Id: <4765c662-1b02-d01a-77b6-8be4ca74719d@oss.cipunited.com> Content-Type: multipart/alternative; boundary=255581abe4bc2824bd827d6370d8dc9814e3fa9607ff1da737094877c15b To: "Maciej W. Rozycki" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --255581abe4bc2824bd827d6370d8dc9814e3fa9607ff1da737094877c15b Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Maciej, Thanks for your detailed reply, and I have some questions about them. =E5=9C=A8 2023/8/21 19:14, Maciej W. Rozycki =E5=86=99=E9=81=93: > On Mon, 21 Aug 2023, Ying Huang wrote: > >> Can you help commit=C2=A0 these two patchs? > To move forward you need to put the findings from the discussion in the= =20 > change description, especially given the difficulty to figure out what th= e=20 > correct naming convention for the ELF file header flags is supposed to be= .=20=20 > This is so that the next time this information is needed it is readily=20 > available rather than requiring chasing in the archives and/or depending= =20 > on the presence of people who may still remember it as on this occasion. > > I think it will help if you split the glibc patch into self-contained=20 > functional subsets: > > 1. File header flags -- need documentation, as noted above. > > 2. SHT_MIPS_ABIFLAGS section type -- obviously correct, no need to > elaborate on it. > > 3. Relocation types -- obviously correct, no need to elaborate on it. > > 4. GNU attribute stuff -- technically Tag_GNU_MIPS_ABI_FP along with the= =20 > enumeration it comes with is a bug fix for commit 0bd956720c45 ("Add=20 > support for MIPS O32 FPXX and .MIPS.abiflags") which, conservatively,= =20 > only added definitions actually used by the dynamic loader itself,=20 > despite that the header is a part of our public API for the MIPS psABI= .=20=20 > I think that either said definitions ought to have been provided=20 > internally only or the whole of the API should have been exported at=20 > once (this applies to #2 above too). Sorry, I am not very clear about this #4 above. What is the whole API? Did you mean not to submit the GNU attribute part or submit the whole API? > > Then the MSA stuff and Val_GNU_MIPS_ABI_FP_NAN2008 as later additions= =20 > are distinct changes each. I think it is worth mentioning in the=20 > inline comment that the latter attribute value has been superseded by= =20 > EF_MIPS_NAN2008. Only to add comments before enum Val_GNU_MIPS_ABI_FP_NAN2008? > > I'd be tempted to say these would best be three distint changes then,= =20 > but maybe other people would consider it overly pedantic. What are these threee changes? > > Then the binutils change needs to document the switch from E_* to EF_*=20 > definitions accordingly. > > Maciej I have submitted patch to binutils which is https://sourceware.org/pipermai= l/binutils/2023-August/129098.html. Did you mean append commit message? Thanks, Ying= --255581abe4bc2824bd827d6370d8dc9814e3fa9607ff1da737094877c15b--