more long long problems "objdump --debugging"

more long long problems "objdump --debugging"

[Greg McGary]

stabs.c uses bfd_vma to hold enum members.  That doesn't work when 
bfd_vma is 32-bits but the enum member needs 64.  This is a general 
problem that applies to debug readers of all formats.  Debug info needs 
to express integer values sized according to the source language, but 
binutils ties the internal representation to bfd_vma, which is 
determined by target machine arch.

dwarf.h makes an effort by defining dwarf_vma:

#if __STDC_VERSION__ >= 199901L || (defined(__GNUC__) && __GNUC__ >= 2)
/* We can't use any bfd types here since readelf may define BFD64 and
   objdump may not.  */
typedef unsigned long long dwarf_vma;
typedef unsigned long long dwarf_size_type;
#else
typedef unsigned long dwarf_vma;
typedef unsigned long dwarf_size_type;
#endif

I'd like to make invent a universal longest-int type used by all 
debug-info readers, and standardize on a conditional.  Is there any 
reason we shouldn't replace the test above with "#if 
BFD_HOST_64BIT_LONG_LONG" ??

G

Re: more long long problems "objdump --debugging"

[Andreas Schwab]

Greg McGary <greg@mcgary.org> writes:

> stabs.c uses bfd_vma to hold enum members.  That doesn't work when bfd_vma
> is 32-bits but the enum member needs 64.

Enumeration constants can only be in the range of an int.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: more long long problems "objdump --debugging"

[Greg McGary]

Andreas Schwab wrote:
> Greg McGary <greg@mcgary.org> writes:
>
>   
>> stabs.c uses bfd_vma to hold enum members.  That doesn't work when bfd_vma
>> is 32-bits but the enum member needs 64.
>>     
>
> Enumeration constants can only be in the range of an int.
>   

This is a GNU extension.  The only complaint comes with -pedantic:
    warning: ISO C restricts enumerator values to range of 'int'

If GCC generates debug info for enumerator constants bigger than int, 
binutils ought to support them.

G

Re: more long long problems "objdump --debugging"

[Alan Modra]

On Wed, Jan 09, 2008 at 07:12:41PM -0800, Greg McGary wrote:
> I'd like to make invent a universal longest-int type used by all 
> debug-info readers, and standardize on a conditional.  Is there any 
> reason we shouldn't replace the test above with "#if 
> BFD_HOST_64BIT_LONG_LONG" ??

That should work.  You could also just use bfd_int64_t.

-- 
Alan Modra
Australia Development Lab, IBM