From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id CF8923858D1E for ; Tue, 8 Feb 2022 08:37:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CF8923858D1E Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-38-FM_jlHUzNWeav5DVUA_uHg-1; Tue, 08 Feb 2022 09:37:32 +0100 X-MC-Unique: FM_jlHUzNWeav5DVUA_uHg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G72SUnfRL+JwratRiyf8zlEk/Ob9j8Mv696e3RNuwkRrZVPAxy+83MllKY/mUFdtuz5hg0PT6C/Un0Van3iySGMKZOlKVmUivs5txz7UMWZaZ4lbHa80aHGpVT3Kurgp050qbw6uSkj6yHD5kXvf3x+h2WzwTHyuw/wRbojT+S4UEiC4l51RSPWcWLxgdgO73hU72ryA6nsho35D8DPPNF90Nfz8rKdcmg/FWtO6Kar2esGk9pifroihgIXHspRkiGB0O6LE5cnMuJvV+WyWQBAIg4H04SdK7h8J1zj8s7iF58CZOikr4cwgHeZHymI9QH70amnN+Tmebd1eZy6L4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fCbmDHiRjHNyRDUVseRJJVMev1IGVY6QFo7xCcFbP4k=; b=AFrGGXTy9cnOqJpP6s5KnrF3yRa8BEHgfXbSzLrRl61JRiROm3bGKVOCFI8HRt2nPv+FqUEJvQt3S1DPG6RZtc9cLa9WNAcpIKDDvqCOW+8vWdtNV/yciFAGYE4jPzCBw1xwn6maJV2Csr/5Az5W5pzb5r5AifAvO3LVk799snB3AX/749BVHnCUx3CoZmpb5EG8RDsjxuNw/UIHCnIGmC+Davge3TQqu+NHWzEE24eYCscvAWEU+2KqBqMU7AX7l0cb9pX0kNAzErjgqySd5YDPW5DovBEcTgLMarw6miLf+meA7Ay4Sv2ZZr5SpN+6dZy3l0VP45e9cnpGjBcixA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by DB6PR0402MB2869.eurprd04.prod.outlook.com (2603:10a6:4:95::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb 2022 08:37:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5160:9fd7:9627:cb11%5]) with mapi id 15.20.4951.018; Tue, 8 Feb 2022 08:37:30 +0000 Message-ID: <4785d6f1-cd0c-2ad4-9a13-6a05f6557b69@suse.com> Date: Tue, 8 Feb 2022 09:37:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] i386: Allow GOT32 relocations against ABS symbols Content-Language: en-US To: "H.J. Lu" References: <20220208000322.4108601-1-hjl.tools@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220208000322.4108601-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0402CA0004.eurprd04.prod.outlook.com (2603:10a6:203:90::14) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ef90245-5437-49c7-560c-08d9eade3e90 X-MS-TrafficTypeDiagnostic: DB6PR0402MB2869:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0y7cLF3riz/L4SrgVNGyUrIH/CIL6cqVHIW6FHianMTVAiT4ClJJoCb0tI/g7DuJL3nHttZZMFM0XGrVwD0TkAoqTi0oTR5486IcrumzZRbasqLQ4eKHMFTMEx8SSoS4ZYMI+jvK2zbr4Lffg4IpjdDEROjyPAK/SMqlgSfkTtmdUK3fbRu34fiidmL1o3EaXBy7eQ+TG94S8mlk31YKquxX7JEFhn2L9pbGG6oYNoia2frf6jUAjF80Q5YVe+/9jKkgM4HscrEAlzPTOtkhIbdKHC723TJMTDMms3eLT/DFuoPgJSUvfWv0tEcUXk3m0vREILJK9Yn14z/QaPSkdC9JNE2OsmmGcDmFpNuptYQ23DGhsao+cup8tH2J8+xM7nj1B6xf+xC/rOk+W66m/lCgDBXFlFlSiSmb0OcOiLSRqQ6gdGfir1PiYlcyTOrGXRruOb+PGEdLCMTWFBdX2cvqGX2BGufGrawLCnSpNwj3jI8f76Vcb1+P8ycZcFSl2z19RiaIraevqOk1PCdMIMut+iN9zBmfnuHLQu1YEqi114gnHjd12uf4K+AsxaynR/29w3wttqkQ+SiXo8oF1G8I6NkDCJo/D4KjFX4eZi19/8ZTPHC8icc744m/roLCAG8OtF1R7dNPShE4D7EWQbpYXycN4fjHmRC3sCbrWVbZPlKcP2ZznmiYv3lPd4B9aqALbUJfhEc7uGAW/qlzPy/gUil8SDzAIHGfPoaGxEc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5600.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(5660300002)(8676002)(6506007)(66556008)(31696002)(4326008)(86362001)(508600001)(66946007)(8936002)(6486002)(6916009)(38100700002)(2616005)(36756003)(6512007)(186003)(53546011)(26005)(4744005)(316002)(31686004)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmFkNi9VMWpsYnYzVWRwUkpqL295b3BrY3Z2L2ZaYmdwckM0NUh5a2RnQ1Bs?= =?utf-8?B?TkNiUW5EbjFVcFJXQkIxVXUyUjJXVkJqQk5YQ3pmL2djUjQ1eEp3TDVncElB?= =?utf-8?B?NitiK1JGK29qejhsZEFCeTRzbGdYSHRxcDR2TVJ1ckxpT25hWWF3Rmd0a00y?= =?utf-8?B?ZFRpVlpkRGdYWXgwVE0rZ040MDFLb1IzWm9QQUVLeG4yUlkxUnRpS3JjSUdP?= =?utf-8?B?Qmx4MGEveEprR2M1cG13NlFkZmUzSlZ2RjQ5RXcweFVGSGZha1l3RWRHZmpM?= =?utf-8?B?c1FSWHErTzNYcU9Zb1lPV2Z2eUF3RzQ0S1hBR2l0Qm8wUEl0VHRuVlBPaDF3?= =?utf-8?B?N2JFcHBkcXV0ajZRamduVXJKTkMrQmh1Wmk5a1dGU3JsMFZPYnp1dXlFOGl3?= =?utf-8?B?elN0dWI2TWsva1dNUlZxTm9XejhDNUQra00zQm5WK1pCdW9scGRWTHNQNTRj?= =?utf-8?B?QndROUZobTl2UCtBSTIwQVZxcHhvVUtSalJwOXA2QzRuNXM0K28rN3oyL1U4?= =?utf-8?B?N0lISm9wY25YTGQzME9tRHVyZmdXVi8yaUlJYm40cG1VSm5USDBwMjk0K0Zy?= =?utf-8?B?UnQ4SU1JQTYwNWFzYm44ME1IL3pWQlVwaXpEcEp5Y09GdE05RU44RGQ0czNx?= =?utf-8?B?UnB4UlJXUzA2OFQrSDBqMFBMdmh5R1VMQkd5dUd5ZTdGdzl1TkV2S0VJQk1l?= =?utf-8?B?Qzc2NHRuWVliQnVDTEJqUkd5MmkyMnN3ZjRVZFRKb2ZaWHh3UVZ5NkNwMTRU?= =?utf-8?B?NFM4WG45MjB6WEpSdnpFSEFlUFdpWTZtWldYQjh4L2U2eWpZUW10STNvL0p2?= =?utf-8?B?QXAyZm53V0IvcWFZYlMxOUttQ3hTWFdjNjlWaElISS84RXhuVFNSQlE1Zllu?= =?utf-8?B?aXpnWFFmeTV2cm5xeXdIRE40aWpGcEZnSnNPbVlqNzZFS3V1bTFCbUg0RlJk?= =?utf-8?B?dVZxZWprSVRwZEQxT1g4TUp4M0w0clVUNHkrZDV6TllmUUhPTmpseFN3MFpR?= =?utf-8?B?TkFRaGVLNGcvbUhBSmVTdGJDTzNQK3ppYkx1VHIxQXpGWHNhM3FSQjZmUzlP?= =?utf-8?B?SkNNOXdGUVBYYUEyWitJbE41SVdkeDg2ME5LSTdhWGJiUXZ1NzZhRFJnSWlx?= =?utf-8?B?WFJ5RkVrQ1dSU2srMVpDOTRndG5CL0tuNUtsc3FvaXF1bnAxUXpUQitzZVBU?= =?utf-8?B?TXN2MzJ5ME51ZEtnUkoyOFQ1K21ldGx3Vk0wRFR0VWUvMHgyZ00ya1NaSG1v?= =?utf-8?B?VmhMRHZPQmRqdWxhdGdtejFwWlhMK08yMCt6L1NwTm5vTWY2WkNMTGpZMUxZ?= =?utf-8?B?QTlCcHNzenhOYTJibDZQbkJzUGVLTzl6RHE3RG0xZ2g0cWNDZEFFczdtVjNL?= =?utf-8?B?Q0JLYUpSRlMzaHN0aEs2L1A1UVVKZ1NpK3hFM3ptSGxUM0lJbnA1QXNleGcy?= =?utf-8?B?Sk51N0IzUm1QZVZsdHhPMjBFVkRadzUyV0liM3JpaG1mNXp3eTBRTFVETFVn?= =?utf-8?B?Z0gyaWhob1AwSWF6OWNrTGdyKzZxWVp6OWdSdmIyN3NXZlpyUU1yTDZEc25M?= =?utf-8?B?czNXblR5ckRaaGJsNGxJSXV0ZDJiUGVzcWo3ZUhsYjFHT2NFQUxGdktydEhQ?= =?utf-8?B?ODdWLy9Ia1JUaS9NODZUb0FTRFptYVYzajUxS0dMYWV1cHFDMUM1OVZlNWVE?= =?utf-8?B?cEp1T285N3lUellwQ1JPU1pYS21nV1Zua1BsVE1jeHdlVzMrZ0VuemxVS3pW?= =?utf-8?B?Uk9SQmZyN2FJZ2R4VG1RVDFzSzdmOHVwL09ad01yR2ozVk5vVWdCam10UXJl?= =?utf-8?B?TW8zWThXbW00WkRZS0V5UHEzQVRFTFVBL2h5WXBtdTJNR2lSWXBGVzFJeUVl?= =?utf-8?B?UElHemlobFlUQlMwNCtKWE9XNm1BZlVYWTduNXVxV2VNV3h0MWNhSWpuREdG?= =?utf-8?B?ZEZVcDNna1QxcXdHZklZQWZUTmtVS1hDeGVxb2Nkd2pQNmhJOUZKYVRiSXdY?= =?utf-8?B?VlFBYkZEdFhhSWpmbkdoaE9jVzlqWER5Zlp4R0pLSzZrejdmbGJBMjhTaWY2?= =?utf-8?B?a04wYW0rOFJCOXAvYllUWTY1dXRoYW9tSFpUbkhmODAyOTBoNUFCV0FJazZs?= =?utf-8?B?WWVXb0JTVXhJOE96SUxhYkt4UGdkWHNUek5GbVFRckZUMjBkcVRCcFd4Yko3?= =?utf-8?Q?tE5Cud+Lpwi+z8jUY19eycA=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ef90245-5437-49c7-560c-08d9eade3e90 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 08:37:30.6359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e2DttiRsJTWDsW0TrOGYipikpFNz7WwYyrHkSIJPbBvFEWUhY2BT3HCJeGPpl/bgZswbLU5VEWuTIgetJ3FuEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2869 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 08:37:38 -0000 On 08.02.2022 01:03, H.J. Lu via Binutils wrote: > GOT32 relocations are allowed since absolute value + addend is stored in > the GOT slot. Before permitting this and with you specifically mentioning addends here, I think it needs to be clarified what ... > --- /dev/null > +++ b/ld/testsuite/ld-i386/pr28870.s > @@ -0,0 +1,6 @@ > + .text > + .globl _start > +_start: > + addl foo@GOT(%ebx), %eax > + cmpl $0, foo@GOT(%ebx) > +foo = 2 ... missing (here) variants thereof actually mean (and whether the use of addends actually works as intended): mov $v@got+3, %eax # bogus, meaningless operand mov $(v+3)@got, %eax # wrong (gets treated same as above) Comments are my own, preliminary judgement. Jan