From: Nick Clifton <nickc@redhat.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Alan Modra <amodra@gmail.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 1/3] gas: sanitize FB- and dollar-label uses
Date: Tue, 26 Mar 2024 11:15:40 +0000 [thread overview]
Message-ID: <479872bf-60a9-4f50-bd1e-23dcbba95e7f@redhat.com> (raw)
In-Reply-To: <875485f7-395a-4348-9b76-c86d24941b52@suse.com>
Hi Jan,
>>> - int small; /* True if fits in 32 bits. */
>>> + int small; /* True if fits in 32 bits (64 bits with BFD64). */
>>
>> I think that this should be:
>>
>> bool small; /* True if fits in 32 bits (64 bits with BFD64). */
> actually I'm glad you mention it. I was meaning to switch to bool, but
> then I wasn't sure whether such would be liked as a "side effect" of
> another change. You indicating (as to my reading) that it would,
Right. As I see it, you fixing both the comment and the type for that
field, and both of these things are reasonable part of the patch.
> I'll
> be happy to make type adjustments here and elsewhere (there are a lot
> more places where in particular "bool" is meant when "int" is used),
> when touching stuff anyway.
Please do.
I have it in my head to take a week and just go through all of the binutils
code base, correcting types like this. All I need is a free week... :-)
Cheers
Nick
next prev parent reply other threads:[~2024-03-26 11:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 9:37 [PATCH 0/3] gas: FB and dollar labels Jan Beulich
2024-03-22 9:40 ` [PATCH 1/3] gas: sanitize FB- and dollar-label uses Jan Beulich
2024-03-26 9:58 ` Nick Clifton
2024-03-26 10:08 ` Jan Beulich
2024-03-26 11:15 ` Nick Clifton [this message]
2024-03-22 9:40 ` [PATCH 2/3] gas: drop dead check for double quote Jan Beulich
2024-03-22 9:40 ` [PATCH 3/3] gas: drop integer_constant()'s maxdig Jan Beulich
2024-03-26 9:53 ` [PATCH 0/3] gas: FB and dollar labels Nick Clifton
2024-03-23 5:11 [PATCH 1/3] gas: sanitize FB- and dollar-label uses dvalin
2024-03-25 6:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479872bf-60a9-4f50-bd1e-23dcbba95e7f@redhat.com \
--to=nickc@redhat.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).