From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 037C93857B8C for ; Wed, 3 Aug 2022 04:28:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 037C93857B8C Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 50F4D300089; Wed, 3 Aug 2022 04:28:38 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org Subject: [PATCH 3/4] RISC-V: Optimize riscv_disassemble_data printf Date: Wed, 3 Aug 2022 13:27:50 +0900 Message-Id: <47ce9991c367778b2684959b127b15fb034404a4.1659500861.git.research_trasio@irq.a4lg.com> In-Reply-To: References: <4919138bb21768d0cdc3a6da81dbbbd62cc96855.1657719581.git.research_trasio@irq.a4lg.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 04:28:41 -0000 This commit makes types of printf arguments on `riscv_disassemble_data' as small as possible (as long as we can preserve the portability) to reduce the cost of printf (especially on 32-bit host). opcodes/ChangeLog: * riscv-dis.c (riscv_disassemble_data): Use smallest possible type to printing data. --- opcodes/riscv-dis.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 220a16e294f..fe18c18642e 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -907,24 +907,22 @@ riscv_disassemble_data (bfd_vma memaddr ATTRIBUTE_UNUSED, (*info->fprintf_styled_func) (info->stream, dis_style_assembler_directive, ".byte\t"); (*info->fprintf_styled_func) - (info->stream, dis_style_immediate, "0x%02llx", - (unsigned long long) data); + (info->stream, dis_style_immediate, "0x%02x", (unsigned) data); break; case 2: info->bytes_per_line = 8; (*info->fprintf_styled_func) (info->stream, dis_style_assembler_directive, ".short\t"); (*info->fprintf_styled_func) - (info->stream, dis_style_immediate, "0x%04llx", - (unsigned long long) data); + (info->stream, dis_style_immediate, "0x%04x", (unsigned) data); break; case 4: info->bytes_per_line = 8; (*info->fprintf_styled_func) (info->stream, dis_style_assembler_directive, ".word\t"); (*info->fprintf_styled_func) - (info->stream, dis_style_immediate, "0x%08llx", - (unsigned long long) data); + (info->stream, dis_style_immediate, "0x%08lx", + (unsigned long) data); break; case 8: info->bytes_per_line = 8; -- 2.34.1