From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70077.outbound.protection.outlook.com [40.107.7.77]) by sourceware.org (Postfix) with ESMTPS id C27E03858435 for ; Tue, 25 Oct 2022 07:07:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C27E03858435 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iw73nqzUT8yOnCeVV5hmqrYNOo2cwoZLVHoGSqzForcClTQWD36LdC0UzRyIS/pRuiFOmIkueiHN13KEZ4ct9v89n/86TFML3C4I0sNTiWxhrnnCcNNBb5NzMMdfKrvNOBtrUkmxgV8qgXZD273+RNESXYumD1ciLkhlme4m1GtQAQ2bD6zARf+NZXYDYc86tq5/uzeirOZSfSKVlO1mTr6IKTWY3jpXEgOWvqH6T46TDI7oIbr8p0vLq5RYCASliw0ZnYqBm9RjwkKZtpIuUy4cgNmZ+j/S3O/9s5ucYCm5OW8b3rmW4BH5D4zENf9GSIJQtco2qi7krWBvjXZiHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7xBmWAKGsI6ceCO4fxC6kqhseImmnX7zakHJ5iRfiG4=; b=ABY4lQfKbNNlGni5H2eFID5c+jBvrI1rzFTomTcIe0EdTd3MC41o8t9n+Y40byfNxYvNDQqp88OzRUj9NKuHMEQ4Vun2Gu0aGoYga99zH+nWka2kn6zz2TIF17tBGRItVrCpA378gjEYop0YEnmFHnSzmFMKrvrvjkVeNsa06/a/gpm/YnPproIFZEBuvo+W7UVloDC7ezmciAa4/bo4GS4/b1MDe4DDYHnJf4CEqo6V7nJpz4aXwBzFQicWkTz5RMuPq+EiM5BorEhZuP9Th/ai54aWv5LA8ERQrFLggDHJe+Ggr/xmWNMzppdv57tJQyYJoVuzF37uxyFfBr480Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7xBmWAKGsI6ceCO4fxC6kqhseImmnX7zakHJ5iRfiG4=; b=RQBJopEJyp7FPBTLV6km4dUtxWYC3WiMnio4VXmsxH0dDdZjAQ3w26q8oP50V84Pegq2PLqgAl3jPkyctQqPYoDYboKMD8lwZKxRK386MYLQ1C5PKJiDg8vSKJS0KSO0zGzsDtZmkQM2L183aCraWbY7yZZpIV+Bov+Ynw36WHd0ZUe34pK6kEtJBowf+VbpEnKNzwNtTn2skl7oTOo9Du9OsyGC0BuYtv0rfwIP+hrRmCG+b+XyDo+WU4csQ9fEGh7nrn6gEB9WmrkDvwrDYPeo4HZ1CeKfON5S1k162/tjy5NpFZk+CdQyelt36NP+ySo87WIVdJbGHFrnvHJmGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8481.eurprd04.prod.outlook.com (2603:10a6:20b:349::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 07:07:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Tue, 25 Oct 2022 07:07:24 +0000 Message-ID: <482ab820-4508-2c28-476b-f1f0a4f7b60c@suse.com> Date: Tue, 25 Oct 2022 09:07:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 08/10] Support Intel MSRLIST Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "Hu, Lin1" , "binutils@sourceware.org" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-9-haochen.jiang@intel.com> <9d80838e-6b6a-339c-820d-90e3da899384@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8481:EE_ X-MS-Office365-Filtering-Correlation-Id: 09732aff-8fd6-41a2-c7cb-08dab657916f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0H9qhZJspk4s80pYWdQEq5Oce9Ge0c8PB40TuFAmWTjoxaAMjrSRPZgrQxsflBe/0mF4QeYcJ1axQV4LjzjCavsBKn0aCdjf2jBvdidhncfORoLrJEGciWx2XDYj8NHF+ZwDlyhFJdj9IHkhSZttBzK9wpAKgk2Ze+eavjsnWaCS6K6ArS5WELfmv7uQQUIVCwharVd8X7vKl0IlbvhdYpD5jauXG0rYmQGU+ijIbU8sygHJzu0MZY9tjnHIPVwLzvoY7DJfouqRyw85eAidOvKSbjfiafE1hBm9vlgyau1/8f2bXHU6d6HyCBA8uuUyOpSmTm0c3fHSslCRAQqXREmxcljEjjeOu3bRarqgmbo+4+rK4Ao5GVj3ZOpaenZhgANEnnRZsh9CMlkBbIrtIbRMdfWu6BzD/GNiQuhn1yPUM8AwS3sWG8+lR5L0dxuKaiwyUgxf5CiPJfZCeAceEBRJacnWdFaL/l1EfiEjOZPzHoDpT4Y9gCaxJCwrm3nFU8FYoKVwcziv08JMFYcxXoBtM9CROH5r7rqt93z8HbIEUfh19tcZ2kbhH7jHTC31Ce6QzY5kNBFG4J5b0kklmDPs3iwV4Rn/uM19vCAq+5MrQNlffHUdq1my0uXOHwRCHg17AkcLJ/dXIJFtko9imMhciX/G0783Zbe7Sn185mmvWPQXci9Pgg0vluA1gcjjMbZPLEKaDqvfe3LghtexaMemGtdpJtEw5a66hPHbQmZf7cdiC2ZhIIqFZTQGFDWjLmiLZIaKc5yy5QRzUDbwLi78PtVi5zOz9ucLH9iOTyY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(136003)(396003)(376002)(451199015)(31696002)(86362001)(36756003)(31686004)(38100700002)(2616005)(2906002)(53546011)(6506007)(6512007)(26005)(478600001)(186003)(83380400001)(6486002)(54906003)(6916009)(316002)(66946007)(66556008)(66476007)(8676002)(4326008)(5660300002)(41300700001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NS9CV3BjY1Z2djhBUDJLRGtJSXhORk9QQ0VreHNBMzZ1UGdZcjM1akJyRDBC?= =?utf-8?B?QUt1MG9Ldm9tOFpJUDBCemdNeXErOEJWTG13d3ZwQlFxMGMweFRndTY0MjI0?= =?utf-8?B?SE5JTUFzMjVBV2VNYkhZOXpwOXg5VkN1YmNhQlFrZlh1cTQ2dFdrQ2tBellJ?= =?utf-8?B?bEtvY0MybXA2TnZJemNvSzZXVWFsQURXT1NzdjRaSkJYUGhLY0NvTW1taVN6?= =?utf-8?B?U2Z6YU1rY1EzNnJ0UG1JVmJGaWxJZkZnMitscEJSSTlhOE1IUUtFQkVGdE8r?= =?utf-8?B?Yk1XVjZhK2lWaW1jeDhRUk10cFh6Q3J5VEhCc2lObHR2dDZuTnRXTkIrL0U5?= =?utf-8?B?STFSMzh3dVhlK3FTQWNsWnFIcHlHQVJEamRORkVZWHdXNUVML05XMGtaMkFO?= =?utf-8?B?dzVvUHE1S3A2cWlWbzhiakdBVkZiOG5FZ0swVElEWUUxdE9tUlR1Ti9GR2NS?= =?utf-8?B?c1E1NmpOZVhtZXNMNGo5NWkwY04yM2poLzBUdTdjOVZGdWhIYXg3dHh2SUl0?= =?utf-8?B?TmVuM1NqMHY2Sm5vUDVQMVN5TnBmdHJrWS9DMVhQZDJBaHFmT0hCVFZYeEE3?= =?utf-8?B?V0Y2Q2pKQ1pIUnpvMS9ITlEzQUtBeEFUY1N5Zklwd0cwZVlIS1pvYW1MWHlr?= =?utf-8?B?UEpDQWU3Rmw2OHFlVkVSTFVyS3d6M3BqSkpGbyt6dkkzaU5pd1ozK3VreW11?= =?utf-8?B?VGJlRVhXVzJsYkJVMGRkN1cxL3FtVDdsd2E3bTlvWmc4aUNERThlYVViMHVx?= =?utf-8?B?M2JzYTMzSTMvUktsY0tSS04rTE9aK29lYUl6U2pMMUp2SjBqSWxrQ3VYajY2?= =?utf-8?B?ZnVUZ3BCb2J0SjA0aFBJM2RrMHJoWUJGTkRqWUFJTDVZeEhQSSs0Y3RCM2lE?= =?utf-8?B?UmRxVVlwbFNmVGk3Ull3TldFWHE1RUVxc1FDQ1prWFpoM2gvUDV5UUVnaUd0?= =?utf-8?B?V25ZS0ljMmZXeDU1SWdlRTFmMnZpTHdwVHRyaXRyUjhQRjhnTTBYdHB4VjJ4?= =?utf-8?B?RTVkWHFDWE80eXVrS3AzTWlUODZaSmZuWjZ5YlZraXJZVG5GWlRIVzhzdjJt?= =?utf-8?B?eFZ6SVd3QnNmdExoSFZleDBveEFydjRqaHdZT3dnbkt5NFlTSlVuZ0J2VkZR?= =?utf-8?B?b1BQVXhQTmxiaUt6NDRCV1d4K1VocXJzNzNpRXhwaUM2MjVtQkgwVVdnbFVw?= =?utf-8?B?ZEtkUjFsVjFZWjFJTkU3YWhuYVBuNXRhOU41MVJZemp2S3FBZVhpditJSEU1?= =?utf-8?B?SGtJQUtLZGRDa1RyNE9hWTNUbWMyVmdJK3VTY0VlZ29STTRubFV1d3lSdkZm?= =?utf-8?B?c255Vk96dmRkbnkzbzJZWk5xdUwxdVozSS90OFM2eGNmN1hnakFua3hWU3RH?= =?utf-8?B?SHFTbW5CeTlHTUI2cjhrWWtTMWZ2Zkc5YXdTUTlxM1NzemZZZ2tTOEVnTXIv?= =?utf-8?B?VWFaL2dwNHVWcFVPWWRPT1owL3pRVmdnbGx3SFNzVDljbjZqZFZNN3BJOFN3?= =?utf-8?B?Y2M5ZzQxSTZlRU9EV2Fvb2dMTDRITkxjYk0xWjhud1ZJNFFwM0xESnNLd2Zv?= =?utf-8?B?M2xBb1J4TGtGUzBlV3UzS1B5MEk0R3FtOW9jUElwTTlRYnV0bDdnUjVwdzV6?= =?utf-8?B?bzN5T0JNMGVMWE41K0tjL2dTMVZiTFRxZXdlY0t6eFErclhwWlh4djdBOEpu?= =?utf-8?B?REZBaHBnVmdqV2trTTYweUgzSDVFU1c1RzkzVVEzNmo4azFtdmRsSFJjR2ov?= =?utf-8?B?aU5OY3RVVmRwbVVRbzZlQ0tlSS9lYnFoZGNwSXYwemVqMldrdkRPdHJ0ZDRH?= =?utf-8?B?MFVBUlk3RXovQWh4Mjd0ZU5pb21GMFpYV2U3ZkEyOFZRM2V2NFBhZzBiVG5j?= =?utf-8?B?eVhLdGk1eTZ0VFlrNy9jdGloUG1JVGJjMkNFMjA2ZGRvdXZlbnBJTkVNU1Fx?= =?utf-8?B?bG1Dc3dYa3VCaTNyY0toTStiSnI4RkRDajNmcUVITVRQdmpOelZpaW9qWVhX?= =?utf-8?B?MnlZeXVFN2MvQ2JudGdZNlIwUmRpME9CUzYyY2xPOUJRbDdDb0g3YWJoRGlQ?= =?utf-8?B?V2l3alExbytWVEVoN2czWTArRjBZa0pldkRpRUVMbXpoR2M1VFpkbXVZT0xu?= =?utf-8?Q?9hqeaBEQ1B+MSNdXRijpIvWOL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09732aff-8fd6-41a2-c7cb-08dab657916f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 07:07:24.6028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 14awQ4pN8QCKD74kOpWZk2C7gRrUAhru5wwRIgxfUfXa10yzTGt0kSv10dABNOmrcqS0jcjeM1/BdvZFG/Tr5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8481 X-Spam-Status: No, score=-3029.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.10.2022 07:56, Jiang, Haochen wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, October 17, 2022 3:20 PM >> To: Jiang, Haochen >> Cc: hjl.tools@gmail.com; Hu, Lin1 ; >> binutils@sourceware.org >> Subject: Re: [PATCH 08/10] Support Intel MSRLIST >> >> On 14.10.2022 11:12, Haochen Jiang wrote: >>> From: "Hu, Lin1" >>> >>> gas/ChangeLog: >>> >>> * NEWS: Support Intel MSRLIST. >>> * config/tc-i386.c: Add msrlist. >>> * doc/c-i386.texi: Document .msrlist and nomsrlist. >>> * testsuite/gas/i386/i386.exp: Add MSRLIST tests. >>> * testsuite/gas/i386/x86-64-lockbad-1.l: Add msrlist. >>> * testsuite/gas/i386/x86-64-lockbad-1.s: Ditto. >>> * testsuite/gas/i386/msrlist-inval.l: New test. >>> * testsuite/gas/i386/msrlist-inval.s: Ditto. >>> * testsuite/gas/i386/x86-64-msrlist-intel.d: Ditto. >>> * testsuite/gas/i386/x86-64-msrlist.d: Ditto. >>> * testsuite/gas/i386/x86-64-msrlist.s: Ditto. >>> >>> opcodes/ChangeLog: >>> >>> * i386-dis.c (X86_64_0F01_REG_0_MOD_3_RM_6_P_1): New. >>> (X86_64_0F01_REG_0_MOD_3_RM_6_P_3): Ditto. >>> (prefix_table): New entry for msrlist. >>> (x86_64_table): Add X86_64_0F01_REG_0_MOD_3_RM_6_P_1 >>> and X86_64_0F01_REG_0_MOD_3_RM_6_P_3. >>> * i386-gen.c (cpu_flag_init): Add CPU_MSRLIST_FLAGS >>> and CPU_ANY_MSRLIST_FLAGS. >>> * i386-init.h: Regenerated. >>> * i386-opc.h (CpuMSRLIST): New. >>> (i386_cpu_flags): Add cpumsrlist. >>> * i386-opc.tbl: Add MSRLIST instructions. >>> * i386-tbl.h: Regenerated. >>> --- >>> gas/NEWS | 2 + >>> gas/config/tc-i386.c | 1 + >>> gas/doc/c-i386.texi | 3 + >>> gas/testsuite/gas/i386/i386.exp | 3 + >>> gas/testsuite/gas/i386/msrlist-inval.l | 3 + >>> gas/testsuite/gas/i386/msrlist-inval.s | 7 + >>> gas/testsuite/gas/i386/x86-64-lockbad-1.l | 100 +- >>> gas/testsuite/gas/i386/x86-64-lockbad-1.s | 4 + >>> gas/testsuite/gas/i386/x86-64-msrlist-intel.d | 14 + >>> gas/testsuite/gas/i386/x86-64-msrlist.d | 14 + >>> gas/testsuite/gas/i386/x86-64-msrlist.s | 11 + >>> opcodes/i386-dis.c | 17 + >>> opcodes/i386-gen.c | 5 + >>> opcodes/i386-init.h | 516 +- >>> opcodes/i386-opc.h | 3 + >>> opcodes/i386-opc.tbl | 7 + >>> opcodes/i386-tbl.h | 7844 +++++++++-------- >>> 17 files changed, 4350 insertions(+), 4204 deletions(-) create mode >>> 100644 gas/testsuite/gas/i386/msrlist-inval.l >>> create mode 100644 gas/testsuite/gas/i386/msrlist-inval.s >>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist-intel.d >>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.d >>> create mode 100644 gas/testsuite/gas/i386/x86-64-msrlist.s >> >> See some of the comments to patch 7, which apply here equally. > > Changes are quite same as patch 7. > > In tc-i386.c, we changed ANY_MSRLIST to MSRLIST. > > Removed lockbad testcases. > > Removed not needed allow_index_reg. Thanks. Preferably also share dump output expectations here between the two new testcases. Jan